Remove casts now that our enums are the right size. #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-chip#7746 made the enums be sized correctly. Fixes project-chip#7622
saurabhst
approved these changes
Jun 23, 2021
mspang
approved these changes
Jun 23, 2021
Damian-Nordic
approved these changes
Jun 23, 2021
jmartinez-silabs
approved these changes
Jun 23, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
project-chip#7746 made the enums be sized correctly. Fixes project-chip#7622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7746 made the
enums be sized correctly.
Fixes #7622
Problem
We have
static_casts we no longer need.Change overview
Remove the casts, replace with
static_asserts.Testing
Tested compilation on Mac.