Replace custom include dirs in java/BUILD with src:includes #7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
Jun 21, 2021
mspang
approved these changes
Jun 21, 2021
saurabhst
approved these changes
Jun 22, 2021
|
Restyler seems stuck even after force push. |
bzbarsky-apple
approved these changes
Jun 22, 2021
a6e2060 to
053a28e
Compare
andy31415
approved these changes
Jun 22, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
java/BUILDuses a custom config so thatjava/gen/...files can access (for example)java/CHIPJNIError.hby writing#include "CHIPJNIError.h"Change overview
src:includesas config#include "CHIPJNIError.h"to#include <controller/java/CHIPJNIError.h>and similarTesting
No functionality change. Ran through Android commissioning and OnOff control.