-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32]fix get wrong MAC on SoftAP mode #7777
Merged
woody-apple
merged 1 commit into
project-chip:master
from
wqx6:random_hostname_SoftAP_mode
Jun 23, 2021
Merged
[ESP32]fix get wrong MAC on SoftAP mode #7777
woody-apple
merged 1 commit into
project-chip:master
from
wqx6:random_hostname_SoftAP_mode
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbc5d15
to
502cbd7
Compare
chshu
approved these changes
Jun 21, 2021
Required to pass TE3 3.4.1 step5. |
andy31415
reviewed
Jun 21, 2021
woody-apple
approved these changes
Jun 21, 2021
502cbd7
to
3c0ae9d
Compare
f677caf
to
eba85a8
Compare
andy31415
approved these changes
Jun 22, 2021
andy31415
reviewed
Jun 22, 2021
eba85a8
to
0ac2248
Compare
Size increase report for "esp32-example-build" from 90592a7
Full report output
|
dhrishi
reviewed
Jun 23, 2021
jmartinez-silabs
approved these changes
Jun 23, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The hostname is wrong when the Rendezvous Mode is SoftAP because
GetPrimaryWiFiMACAddress
gets wrong MAC.Change overview
Fix above problem
Testing
Tested manually with avahi-browse after connecting the SoftAP.