Make test_suites.sh run multiple iterations of the tests. #7433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is to run 20 times (which takes ~3 seconds on a Mac laptop), but it's configurable via the first command-line arg. The changes to the actual loop body over test_array are: 1. Removing all the sleeps. 2. Making it less likely that we will kill some unrelated process (due to us killing $background_pid and then exiting with an error from the kill command and trying to kill it again).
woody-apple
approved these changes
Jun 7, 2021
msandstedt
approved these changes
Jun 7, 2021
saurabhst
approved these changes
Jun 7, 2021
yunhanw-google
approved these changes
Jun 8, 2021
andy31415
approved these changes
Jun 8, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ip#7433) The default is to run 20 times (which takes ~3 seconds on a Mac laptop), but it's configurable via the first command-line arg. The changes to the actual loop body over test_array are: 1. Removing all the sleeps. 2. Making it less likely that we will kill some unrelated process (due to us killing $background_pid and then exiting with an error from the kill command and trying to kill it again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is to run 20 times (which takes ~3 seconds on a Mac
laptop), but it's configurable via the first command-line arg.
The changes to the actual loop body over test_array are:
killing $background_pid and then exiting with an error from the kill
command and trying to kill it again).
Problem
Intermittent failures are only caught by some test runs.
Change overview
Have each test run run the tests 20 of times, making it more likely to catch intermittent problems.
Testing
Ran the script locally to make sure that the new setup does not fail. Verified via the log that the tests did indeed get run 20 times.