[nrfconnect] Fixed compilation with dfu overlay error. #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhst
approved these changes
Jun 7, 2021
Due to the latest nRF Connect SDK version update few config names related to Bluetooth changed. Device firmware upgrade overlay that is used optionally was not aligned to those changes and now target will not be build because of the compilation errors. Changed Bluetooth configs names in DFU overlay to be compatible with the new nRF Connect SDK version.
3413bc6 to
ef7e996
Compare
andy31415
approved these changes
Jun 7, 2021
Damian-Nordic
approved these changes
Jun 7, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…7418) Due to the latest nRF Connect SDK version update few config names related to Bluetooth changed. Device firmware upgrade overlay that is used optionally was not aligned to those changes and now target will not be build because of the compilation errors. Changed Bluetooth configs names in DFU overlay to be compatible with the new nRF Connect SDK version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to the latest nRF Connect SDK version update few config names related to Bluetooth changed. Device firmware upgrade overlay that is used optionally was not aligned to those changes and now target will not be built because of the compilation errors.
Change overview
Changed Bluetooth configs names in DFU overlay to be compatible with the new nRF Connect SDK version.
Testing
Verified that it is possible to successfully build target with the
-DOVERLAY_CONFIG=third_party/connectedhomeip/config/nrfconnect/app/overlay-dfu_support.confoption that enables using Device Firmware Upgrade in nrfconnect examples.