Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CRMP to MRP (Message Reliability Protocol) #7351

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Rename CRMP to MRP (Message Reliability Protocol) #7351

merged 1 commit into from
Jun 3, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed?
CRMP has been rename to to MRP (Message Reliability Protocol) in spec.

Change overview

Rename CRMP to MRP (Message Reliability Protocol) to align with spec.

Testing

How was this tested? (at least one bullet point required)
Run ./gn_build and confirm nothing break.

@todo
Copy link

todo bot commented Jun 3, 2021

Issue #5833 - MRP retry intervals should be updated on the poll period value

// TODO: Issue #5833 - MRP retry intervals should be updated on the poll period value
// change or device type change.
#if CHIP_DEVICE_CONFIG_ENABLE_THREAD
if (chip::DeviceLayer::ConnectivityMgr().GetThreadDeviceType() ==


This comment was generated by todo based on a TODO comment in 9f48010 in #7351. cc @yufengwangca.

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Size increase report for "nrfconnect-example-build" from 4afd340

File Section File VM
chip-lock.elf rodata -8 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
rodata,-4,-8
.debug_str,0,-13
.debug_loc,0,-27

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,3
.debug_str,0,-3


@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Size increase report for "gn_qpg6100-example-build" from 4afd340

File Section File VM
chip-qpg6100-lighting-example.out .text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,4
.debug_line,0,1
.text,-4,-4
.debug_str,0,-13
.debug_loc,0,-24


@andy31415 andy31415 merged commit 43077a5 into project-chip:master Jun 3, 2021
@yufengwangca yufengwangca deleted the pr/messaging/mrp branch June 3, 2021 22:04
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants