-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Fix temperature-measurement app #7305
ESP32: Fix temperature-measurement app #7305
Conversation
Note that, this might still require adding the actual calls for temperature-measurement cluster. But, currently, we use this example for optimization of the Flash/RAM footprint and hence the build failure needs to be fixed sooner. |
…ure-measurement cluster
eeb4463
to
ebacd67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fill out the testing template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file looks to be in a 'gen' folder which implies generated file.
Is this true or not @vivien-apple
I have conflicting signals here: "gen" says generated, but our XML files do not contain 'events' as far as I am aware (at least https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/silabs/schema/zcl.xsd does not show it)
Approving assuming gen_event is not generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is originally generated by Simplicity Studio, but has not been migrated to ZAP yet. See #3637 (comment)
…ure-measurement cluster (project-chip#7305)
Problem
temperature-measurement-app for ESP32 cannot compile at ToT
This is due to the latest changes related to temeprature-measurement cluster #7026
Change overview
The APIs emberAfPluginTemperatureMeasurementServerReadEventControl and emberAfPluginTemperatureMeasurementServerReadEventHandler are removed from the above PR and hence removing them from here
Testing
Locally compiled the temperature-measurement app with CMake
Fixes #7302