Move the bootstrap output dir inside the environment #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting it at out/ causes problems: 1) Our scripts and docs use subdirectories of out/ as the build root to allow creating multiple output directories with different configurations. These directories are now nested inside the bootstrap dir which is likely to cause confusion. 2) Using a single location in and out of docker breaks. The vscode docker moves the environment to work around these conflicts. Using a common build directory will cause similar breakage. 3) Cleaning the environment without cleaning out/ results in errors. This indicates they should be co-located.
saurabhst
approved these changes
May 28, 2021
Damian-Nordic
approved these changes
May 28, 2021
andy31415
approved these changes
May 31, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Putting it at out/ causes problems: 1) Our scripts and docs use subdirectories of out/ as the build root to allow creating multiple output directories with different configurations. These directories are now nested inside the bootstrap dir which is likely to cause confusion. 2) Using a single location in and out of docker breaks. The vscode docker moves the environment to work around these conflicts. Using a common build directory will cause similar breakage. 3) Cleaning the environment without cleaning out/ results in errors. This indicates they should be co-located.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting it at out/ causes problems:
Our scripts and docs use subdirectories of out/ as the build
root to allow creating multiple output directories with different
configurations. These directories are now nested inside the
bootstrap dir which is likely to cause confusion.
Using a single location in and out of docker breaks. The vscode
docker moves the environment to work around these conflicts.
Using a common build directory will cause similar breakage.
Cleaning the environment without cleaning out/ results in errors.
This indicates they should be co-located.
Move it to a sub-directory of the environment.
Tested by running
scripts/bootstrap.sh