Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] NodeCredential should be initialized with nullptr #6843

Merged
merged 1 commit into from
May 15, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented May 14, 2021

Problem

We did not init NodeCredential with nullptr, thus is will be a random number, and device controller may crash in real device and cirque virtual test

Summary of Changes

Fix it.

@pan-apple pan-apple added the hotfix urgent fix needed, can bypass review label May 15, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from e5cb796

File Section File VM
chip-all-clusters-app.elf .flash.text 20 20
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,234
.debug_str,0,174
.debug_loc,0,130
.debug_line,0,59
.flash.text,20,20
.debug_ranges,0,8
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1


@woody-apple
Copy link
Contributor

Allowing hot fix as this is tested and confirmed by CSG.

@woody-apple woody-apple merged commit 9ca740f into project-chip:master May 15, 2021
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from e5cb796

File Section File VM
chip-lock.elf text 16 16
chip-lighting.elf text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,245
.debug_str,0,174
.debug_loc,0,118
.debug_line,0,23
.debug_ranges,0,16
text,16,16
.debug_frame,0,-8

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,245
.debug_str,0,174
.debug_loc,0,122
.debug_line,0,27
.debug_ranges,0,16
text,16,16
.debug_frame,0,-8

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants