-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Add fixes for lock-app #6658
Conversation
1ce1055
to
a08634a
Compare
/rebase |
Removing WIP title so Pull Approve is happy, this appears ready? |
@woody-apple I think a few changes are pending. Should we move it back to WIP, so that it isn't merged? |
Marking this as a draft given it's WIP then :) Please un-draft it when you're ready! |
dffc496
to
034c91b
Compare
640e319
to
e5cbb54
Compare
e5cbb54
to
db079cb
Compare
db079cb
to
4b41448
Compare
561f7c6
to
78381ed
Compare
Please add a section in the summary for how this was tested - what steps/tools did you use to validate the functionality update? |
f577561
to
cd3c075
Compare
cd3c075
to
c4931fc
Compare
@sweetymhaiske - this is almost ready to go in. Please update the PR summary with a 'how did you test this' section before we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the updated template, can you update the PR here?
#### Problem
What is being fixed? Examples:
* Fix crash on startup
* Fixes #12345 12345 Frobnozzle is leaky (exactly like that, so GitHub will auto-close the issue).
#### Change overview
What's in this PR
#### Testing
How was this tested? (at least one bullet point required)
• If unit tests were added, how do they cover this issue?
• If unit tests existed, how were they fixed/modified to prevent this in future?
• If integration tests were added, how do they verify this change?
• If manually tested, what platforms controller and device platforms were manually tested, and how?
• If no testing is required, why not?
c4931fc
to
67234df
Compare
Done |
Done |
@sweetymhaiske Is there anything pending here? |
No. |
@woody-apple Can you please take a look? |
Dismissing review for "summary content was updated according to the template"
Problem
Change overview
Testing