-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling list attriubtes on the app clusters and updating the TV example app #6582
Enabling list attriubtes on the app clusters and updating the TV example app #6582
Conversation
e81af0d
to
6412527
Compare
|
6412527
to
5d3b94f
Compare
@lazarkov conflicts here :( |
5d3b94f
to
53838c0
Compare
@woody-apple update the PR. Conflicts should be resolved now. |
/rebase |
@lazarkov Sorry, still failing build - and now conflicted again with tv app :( |
@lazarkov I would recommend splitting this into two changesets within the PR: one with the manual changes and one with the auto-generated changes. That will make review easier and also make merging/rebasing easier: the generated PR can just be dropped nad then regenerated after merging/rebasing the manual changes. |
53838c0
to
25914a2
Compare
Problem We do not have list attributes enabled on app clusters. Summary of Changes - Updated all the app clusters where list attributes are used - Updated the TV example app to use the new attributes Test - Tested locally using chip-tool client and newly created tv-server - Used the zap_regen_all.py and gn_build.sh to verify the building is successful
25914a2
to
91c71f5
Compare
@bzbarsky-apple I understand it's hard to follow as gen/ folder polutes the PR. Now regarding the PR, on how to follow what actually is the change:
Clusters who have now list attribute supported are: TV Channel, Content Launcher, Application Launcher, Audio Output, Media Input and Target navigator. If there's a good way to split PR, please advise. |
@lazarkov I did not say to split up into multiple _PR_s. I said to split up into multiple changesets within a single PR. This makes review significantly simpler, because instead of needing to find the non-generated files in the overall diff you just have two separate diffs: one with the manual changes, one with the generated ones. See #6804 for an example. If you look at https://github.com/project-chip/connectedhomeip/pull/6804/commits there are two commits: one with the manual changes, and one with the generated stuff. |
Problem
We do not have list attributes enabled on app clusters.
Summary of Changes
Note
Everything which is not supported by the CHIP framework currently is noted with TODO comment.
Test
./scripts/tools/zap_regen_all.py
and./gn_build.sh
to verify the building is successful