-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add config_enable_https_requests flag to examples/chip-to… #37409
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_DCL_Followup
Feb 5, 2025
Merged
[chip-tool] Add config_enable_https_requests flag to examples/chip-to… #37409
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_DCL_Followup
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #37409: Size comparison from f7226c1 to 00c3def Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 5, 2025
andy31415
approved these changes
Feb 5, 2025
soares-sergio
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
vivien-apple
force-pushed
the
ChipTool_DCL_Followup
branch
from
February 5, 2025 15:51
00c3def
to
15b0550
Compare
andy31415
approved these changes
Feb 5, 2025
Fast tracking post-merge fixes that only affect testing tooling functionality. |
PR #37409: Size comparison from f7226c1 to 15b0550 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
ChipTool_DCL_Followup
branch
2 times, most recently
from
February 5, 2025 19:50
eac073c
to
579849d
Compare
…ol/BUILD.gn and replace gethostbyname by getaddrinfo
vivien-apple
force-pushed
the
ChipTool_DCL_Followup
branch
from
February 5, 2025 19:52
579849d
to
b25a399
Compare
PR #37409: Size comparison from f7226c1 to b25a399 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
…ol/BUILD.gn and replace gethostbyname by getaddrinfo (project-chip#37409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ol/BUILD.gn and replace gethostbyname by getaddrinfo
Problem
This PR is a follow-up to #37049, introducing minor improvements:
gethostbyname
with the moderngetaddrinfo
for better compatibility and future-proofing.config_enabled_https_requests
) tochip-tool
that allows explicitly disabling HTTPS requests, even whenOpenSSL
/BoringSSL
is available. This flag is enabled by default but can be overridden to force HTTPS requests off.Testing