## Automation REFALM_2_2 ## #37108
Open
## Automation REFALM_2_2 ## #37108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
|
| * JSON Arguments: | ||
| * - "Name": Must be "SetRefDoorStatus" | ||
| * - "EndpointId": ID of endpoint having a switch cluster | ||
| * - "Status": Status of the door, open or closed. |
There was a problem hiding this comment.
Why is this an integer, not a boolean? And why not just "DoorOpen"?
There was a problem hiding this comment.
Updated to boolean as only 2 status are used. Changed name for better understanding.
|
As mentioned I raised an issue related to executing arbitrary commands. Link to issue: |
3ce3206 to
836c55d
Compare
| * JSON Arguments: | ||
| * - "Name": Must be "SetRefDoorStatus" | ||
| * - "EndpointId": ID of endpoint | ||
| * - "DoorOpen": Status of the door, open or closed. |
There was a problem hiding this comment.
Does not match the "Usage example" above.
| RefrigeratorAlarmServer::Instance().SetMaskValue(endpointId, doorStatus); | ||
| ChipLogDetail(NotSpecified, "Refrigeratoralarm status updated to :%d", doorStatus); | ||
| } | ||
| else if (doorStatus) |
There was a problem hiding this comment.
Why is this not just an else? A bool can't have a value other than true or false....
|
PR #37108: Size comparison from eea382e to 1b42ced Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
khodya
approved these changes
Feb 10, 2025
src/python_testing/TC_REFALM_2_2.py
Outdated
| @async_test_body | ||
| async def test_TC_REFALM_2_2(self): | ||
| """Run the test steps.""" | ||
| self.wait_thresshold_v = 5000 |
There was a problem hiding this comment.
Updated variable name to explain that wait time will be seconds. Also updated to take the attribute from the argument PIXIT.REFALM.AlarmThreshold.
This test verify the basic functionality of the DUT as a server. Added custom manual actions for Dooropen. Implemented Fake Methods to run disallowd commands. Assert Status Attribute. Assert Status attribute from the Notify event. Added TODO for FakeMethods. Issue raised to add method to run arbitraty commands.
… for wait threshold. Added missing copyright. Added missing docstring.
1b42ced to
f0138e4
Compare
|
PR #37108: Size comparison from da6a512 to f0138e4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the proposal to Automate the REFALM_2_2
This test case verifies the primary functionality of the Refrigerator Alarm Cluster server.
Manual actions are performed in order to verify the device Attributes.
Verify the commands from the device are Disallowed as described in the spec.
Subscribe to Notify event and wait for the event data.
Testing
Verified by ci with all clusters app:
./out/linux-x64-all-clusters/chip-all-clusters-appRun the tests providing the app-pid of the clusters to send manual actions.
python3 src/python_testing/TC_REFALM_2_2.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --PICS src/app/tests/suites/certification/ci-pics-values --int-arg PIXIT.REFALM.AlarmThreshold:5 --app-pid $(ps waux | grep all-clusters | grep -v grep | awk '{print $2}' )