Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invert boolean return in GetAcknowledgementsRequest #37014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swan-amazon
Copy link
Contributor

@swan-amazon swan-amazon commented Jan 9, 2025

The GetAcknowledgementsRequest was returning an incorrect boolean value, causing unexpected behavior. This change inverts the return value to fix the logical error.

Testing

  • Issue identified during test plan script development
  • Test plan changes will be referenced in a separate change

The GetAcknowledgementsRequest was returning an incorrect boolean value,
causing unexpected behavior. This change inverts the return value to
fix the logical error.

Testing:
- Issue identified during test plan script development
- Test plan changes will be referenced in a separate change
Copy link

Review changes with  SemanticDiff

Copy link

github-actions bot commented Jan 10, 2025

PR #37014: Size comparison from d3204f6 to 046c109

Increases above 0.2%:

platform target config section d3204f6 046c109 change % change
tizen chip-tool-ubsan arm unknown 10844 10924 80 0.7
FLASH 17999086 18121318 122232 0.7
RAM 7855832 7909272 53440 0.7
Full report (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
platform target config section d3204f6 046c109 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1354956 1355062 106 0.0
RAM 104152 104152 0 0.0
bl702 lighting-app bl702+eth FLASH 726512 726456 -56 -0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 913126 913070 -56 -0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1173960 1173904 -56 -0.0
RAM 23941 23941 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1083028 1082972 -56 -0.0
RAM 16612 16612 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840256 840328 72 0.0
RAM 123696 123712 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825796 825868 72 0.0
RAM 125584 125600 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772632 772756 124 0.0
RAM 114060 114076 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756812 756944 132 0.0
RAM 114260 114276 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540113 540181 68 0.0
RAM 205800 205816 16 0.0
lock CC3235SF_LAUNCHXL FLASH 574265 574349 84 0.0
RAM 205944 205960 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918156 918092 -64 -0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890664 890648 -16 -0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852220 852160 -60 -0.0
RAM 142244 142244 0 0.0
qpg lighting-app qpg6105+debug FLASH 664392 664336 -56 -0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 622204 622140 -64 -0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 485136 485072 -64 -0.0
RAM 144912 144912 0 0.0
telink bridge-app tlsr9258a FLASH 683698 683684 -14 -0.0
RAM 91248 91248 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623938 623926 -12 -0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772772 772758 -14 -0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777388 777374 -14 -0.0
RAM 99812 99812 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711380 711368 -12 -0.0
RAM 73544 73544 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628384 628370 -14 -0.0
RAM 142180 142180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814398 814384 -14 -0.0
RAM 99724 99724 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1781116 1781736 620 0.0
RAM 93684 93720 36 0.0
chip-tool-ubsan arm unknown 10844 10924 80 0.7
FLASH 17999086 18121318 122232 0.7
RAM 7855832 7909272 53440 0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants