ESP32: Fix building chip_gn for cmake v3.31.x and onwards #36606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
remove the WORKING_DIRECTORY from chip_gn target
For cmake v3.31.x, custom command generated for chip_gn-build in
build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and
it mess up the chip_gn step when building example.
COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32
For cmake version prior to v3.31, it do not prepend the
$WORKING_DIRECTORY path.
COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32
This could be becuase of Kitware/CMake@f5f8030
related issue - espressif/esp-matter#1157
044e697 to
e701731
Compare
|
PR #36606: Size comparison from 04e6a68 to e701731 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dhrishi
approved these changes
Nov 22, 2024
andy31415
approved these changes
Nov 22, 2024
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…ip#36606) remove the WORKING_DIRECTORY from chip_gn target For cmake v3.31.x, custom command generated for chip_gn-build in build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and it mess up the chip_gn step when building example. COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32 For cmake version prior to v3.31, it do not prepend the $WORKING_DIRECTORY path. COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32 This could be becuase of Kitware/CMake@f5f8030 related issue - espressif/esp-matter#1157
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…ip#36606) remove the WORKING_DIRECTORY from chip_gn target For cmake v3.31.x, custom command generated for chip_gn-build in build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and it mess up the chip_gn step when building example. COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32 For cmake version prior to v3.31, it do not prepend the $WORKING_DIRECTORY path. COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32 This could be becuase of Kitware/CMake@f5f8030 related issue - espressif/esp-matter#1157
andy31415
pushed a commit
that referenced
this pull request
Nov 25, 2024
…36631) remove the WORKING_DIRECTORY from chip_gn target For cmake v3.31.x, custom command generated for chip_gn-build in build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and it mess up the chip_gn step when building example. COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32 For cmake version prior to v3.31, it do not prepend the $WORKING_DIRECTORY path. COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32 This could be becuase of Kitware/CMake@f5f8030 related issue - espressif/esp-matter#1157
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ip#36606) remove the WORKING_DIRECTORY from chip_gn target For cmake v3.31.x, custom command generated for chip_gn-build in build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and it mess up the chip_gn step when building example. COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32 For cmake version prior to v3.31, it do not prepend the $WORKING_DIRECTORY path. COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32 This could be becuase of Kitware/CMake@f5f8030 related issue - espressif/esp-matter#1157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the WORKING_DIRECTORY from chip_gn target
For cmake v3.31.x, custom command generated for chip_gn-build in build.ninja concats the
$WORKING_DIRECTORYand$BUILD_DIRpaths and it mess up thechip_gnstep when building example.For cmake version prior to v3.31, it does not prepend the
$WORKING_DIRECTORYpath.This could be becuase of Kitware/CMake@f5f8030 which started using WORKING_DIRECTORY.
related issue - espressif/esp-matter#1157
Tests