data-model-provider: Add an interface to report attribute changes which are not caused by WriteAttribute. #36364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36364: Size comparison from 9c389ba to d88f83e Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36364: Size comparison from 9c389ba to 38b2fb2 Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
|
PR #36364: Size comparison from 9c389ba to 3005430 Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ch are not caused by WriteAttribute
3005430 to
00cb6e3
Compare
|
PR #36364: Size comparison from 123570c to 00cb6e3 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 5, 2024
andy31415
requested changes
Nov 5, 2024
There was a problem hiding this comment.
I am generally weary of adding things to DataModelProvider.
In particular its design is such that it is the interface to query for data and it owns all the underlying data.
Please provide a use case and design description in the summary at least, so I understand it. Right now the data model intentionally did not provide version updates as it is supposed to externally notify changes by using its context, however it is not designed to get pushes to version.
The underlying concept is that the DataModel::Provider owns its data and versions. So you cannot tell it "I changed your data" because you do not own it.
andy31415
reviewed
Nov 5, 2024
|
PR #36364: Size comparison from 2a7106f to e3e1ca9 Full report (3 builds for cc32xx, stm32)
|
|
PR #36364: Size comparison from 2a7106f to c74017e Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Nov 7, 2024
src/app/codegen-data-model-provider/CodegenDataModelProvider_Write.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
The deprecated mark will cause CI failures, as the lots of CI buildings are using -Werror=deprecated-declarations compile option. Removed the deprecated mark. |
|
PR #36364: Size comparison from d8ededa to 0f356bb Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 28, 2024
|
Fast tracking: comments were addressed and PR is open for 1 month. |
|
PR #36364: Size comparison from ca772d7 to b0dc126 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36364: Size comparison from e419e33 to c9a6c3e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36364: Size comparison from b0fd385 to 1dd4d46 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ch are not caused by WriteAttribute. (project-chip#36364) * data-model-provider: Add an interface to report attribute changes which are not caused by WriteAttribute * review changes * Restyled by clang-format * Update src/app/data-model-provider/Provider.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/Provider.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * review changes * remove the deprecated mark to fix CI issue * review changes * Restyled by clang-format * fix java build * move the report change callback to metadatatree * fix CI build --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term fix for #36353