Generate Conformance Data with Alchemy #36186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36186: Size comparison from 9ee0499 to 0d5943c Full report (3 builds for cc32xx, stm32)
|
0d5943c to
16f0467
Compare
16f0467 to
f88303a
Compare
f88303a to
a436efc
Compare
a436efc to
2d5612b
Compare
|
PR #36186: Size comparison from 0b93b0d to 2d5612b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 23, 2024
jmartinez-silabs
approved these changes
Oct 23, 2024
| <attribute code="0x0005" side="server" define="COMMISSIONING_ARL" type="array" entryType="CommissioningAccessRestrictionEntryStruct" optional="true">CommissioningARL</attribute> | ||
| <attribute code="0x0006" side="server" define="ARL" type="array" entryType="AccessRestrictionEntryStruct" optional="true">ARL</attribute> | ||
|
|
||
| <attribute side="server" code="0x0002" define="SUBJECTS_PER_ACCESS_CONTROL_ENTRY" type="int16u" min="4" default="4"> |
There was a problem hiding this comment.
I raised this on Slack, but this merged before I had a chance to comment on the PR @jmartinez-silabs @andy31415 @ethanzhouyc :
This attribute syntax is because it is really hard to tell where the attribute name should go. But now we forced it on all attributes, but adding lots of <mandatoryConform/> everywhere instead of just assuming M conformance if none is listed. Ideally we would just not have the noise, but if we really have to, we need to make the syntax make some sort of sense: the attribute name is not a "description".
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Oct 23, 2024
This reverts commit 334c669.
andy31415
added a commit
that referenced
this pull request
Oct 23, 2024
ethanzhouyc
added a commit
to ethanzhouyc/connectedhomeip
that referenced
this pull request
Oct 24, 2024
…36186)" (project-chip#36220)" This reverts commit a4a911c.
ethanzhouyc
added a commit
to ethanzhouyc/connectedhomeip
that referenced
this pull request
Oct 24, 2024
…36186)" (project-chip#36220)" This reverts commit a4a911c.
ethanzhouyc
added a commit
to ethanzhouyc/connectedhomeip
that referenced
this pull request
Oct 28, 2024
…36186)" (project-chip#36220)" This reverts commit a4a911c.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* generate conformance with Alchemy * add conform to color-control cluster extension
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ribute Description (project-chip#36233) * Revert "Revert "Generate Conformance Data with Alchemy (project-chip#36186)" (project-chip#36220)" This reverts commit a4a911c. * move attribute name - move attribute name from description to name inside attribute tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds conformance data to attributes, commands, and events in ZAP XMLs using automated generation from Alchemy.
Generation Method:
Since Alchemy does not provide a command to directly generate conformance, the changes in this PR were produced by generating the diff between running Alchemy commands with and without the conformance flag. As a result, some unrelated changes are also included: Alchemy removes attributes with default values inside
<attribute>tags. They are redundant and will not affect XML parsing. For example:optional="false"andmin="0"(for unsigned int types) are omitted.Validation and Discoveries:
To validate the generation result, Paul and I spent an entire day on reviewing and comparing all conformance-related updates against the spec element by element to ensure accuracy. Here are key findings:
color-control-cluster.xmlwas not generated by Alchemy and has been manually added based on the spec.mandatoryConformin XML.descin the spec, no conformance will be added to the XML. When combined with other conformance types, for example,P, desc, it translates to aprovisionalConforminsideotherwiseConform, anddesctranslates to nothing. It is wrong and should just beprovisionalConform