Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Adds refrigerator application (#35433) #36138

Conversation

shgutte
Copy link
Contributor

@shgutte shgutte commented Oct 18, 2024

Added Implementation of the application
PR-merged in CSA: #35433

* Added the refrigerator application

* Added Implementation of the application

* Added RefrigeratorManager

* Added changes for the callback and the attribute update

* Added changes fot attribute data type

* added changes for the refrigrator UI

* Updated the wifi args and open thread files

* Added changes for refrigerator UI

* Added build fixes

* Fixed build errors

* Added changes for new zap attributes

* Added changes for the readme file

* Added date and spelling mistake changes

* Added changes for spelling mistake

* Added updated zap matter file and removed the commented code

* Removed the unwanted services from gn file

* Added function header

* Updated task name and removed the incorrect data

* Added callbacks

* Modified the datat type and the removed the callback

* Removed unwated changes

* Added changes for authors

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Added changes according to comments

* Added the WiFi boards in the board list

* Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Fixed  the unint32_t alignment for the

* Added changes according to comment

* Removing warning

* Replaced the SILABS_LOGS with CHIPLog

* Corrected the application name

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/include/AppTask.h

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Removed commented code

* Updated read me for OTA documentation for SiWx917

* Adds changes for refrigerator modes and callbacks

* Added chip logs

* Updated the error message

* Restyled by whitespace

* Restyled by clang-format

* Updated refrigerator app matter file

* Added the changes related  to zap file and the mode supported

* Restyled by whitespace

* Restyled by clang-format

* Added changes for Temperature Controller feature Map

* Updated featureMap value for matter file

* Removed the temperature level

* Removed the startup and on mode from attributes

* Setting min and max temperature for the controlled cabinet

* Removed the Temperature level attribute from the Temperature controller

* Removed the min and max temperature

* Removed the attribute update for refrigerator and temperature cluster

* Added changes for the zap file

* Added restyle changes

* Updated matter file

* Added OTA requester

* Added changes for the attribute

* Added changes for the zap

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>
Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
@shgutte shgutte requested a review from a team as a code owner October 18, 2024 07:12
Copy link

semanticdiff-com bot commented Oct 18, 2024

Review changes with SemanticDiff.

Analyzed 2 of 26 files.

File Information
Filename Status
examples/refrigerator-app/silabs/BUILD.gn Unsupported file format
examples/refrigerator-app/silabs/README.md Unsupported file format
examples/refrigerator-app/silabs/build_for_wifi_args.gni Unsupported file format
examples/refrigerator-app/silabs/build_for_wifi_gnfile.gn Unsupported file format
✔️ examples/refrigerator-app/silabs/build_overrides Analyzed
examples/refrigerator-app/silabs/openthread.gn Unsupported file format
examples/refrigerator-app/silabs/openthread.gni Unsupported file format
✔️ examples/refrigerator-app/silabs/third_party/connectedhomeip Analyzed
examples/refrigerator-app/silabs/src/AppTask.cpp Unsupported file format
examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Unsupported file format
examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp Unsupported file format
examples/refrigerator-app/silabs/src/ZclCallbacks.cpp Unsupported file format
examples/refrigerator-app/silabs/src/refrigerator-and-temperature-controlled-cabinet-mode.cpp Unsupported file format
examples/refrigerator-app/silabs/include/AppConfig.h Unsupported file format
examples/refrigerator-app/silabs/include/AppEvent.h Unsupported file format
examples/refrigerator-app/silabs/include/AppTask.h Unsupported file format
examples/refrigerator-app/silabs/include/CHIPProjectConfig.h Unsupported file format
examples/refrigerator-app/silabs/include/RefrigeratorIcons.h Unsupported file format
examples/refrigerator-app/silabs/include/RefrigeratorManager.h Unsupported file format
examples/refrigerator-app/silabs/include/RefrigeratorUI.h Unsupported file format
examples/refrigerator-app/silabs/include/refrigerator-and-temperature-controlled-cabinet-mode.h Unsupported file format
examples/refrigerator-app/silabs/data_model/BUILD.gn Unsupported file format
examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter Unsupported file format
examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap Unsupported file format
examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter Unsupported file format
examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap Unsupported file format

Copy link

PR #36138: Size comparison from 284d193 to 4b89d89

Full report (1 build for stm32)
platform target config section 284d193 4b89d89 change % change
stm32 light STM32WB5MM-DK FLASH 481568 481568 0 0.0
RAM 144684 144684 0 0.0

@mkardous-silabs
Copy link
Contributor

@shgutte You need to regenerate the zap files.

@andy31415 andy31415 merged commit 803e819 into project-chip:v1.4-branch Oct 21, 2024
68 of 70 checks passed
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jan 16, 2025
…hip#35433) (project-chip#36138)

* [Silabs] Adds refrigerator application  (project-chip#35433)

* Added the refrigerator application

* Added Implementation of the application

* Added RefrigeratorManager

* Added changes for the callback and the attribute update

* Added changes fot attribute data type

* added changes for the refrigrator UI

* Updated the wifi args and open thread files

* Added changes for refrigerator UI

* Added build fixes

* Fixed build errors

* Added changes for new zap attributes

* Added changes for the readme file

* Added date and spelling mistake changes

* Added changes for spelling mistake

* Added updated zap matter file and removed the commented code

* Removed the unwanted services from gn file

* Added function header

* Updated task name and removed the incorrect data

* Added callbacks

* Modified the datat type and the removed the callback

* Removed unwated changes

* Added changes for authors

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Added changes according to comments

* Added the WiFi boards in the board list

* Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Fixed  the unint32_t alignment for the

* Added changes according to comment

* Removing warning

* Replaced the SILABS_LOGS with CHIPLog

* Corrected the application name

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Update examples/refrigerator-app/silabs/README.md

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/AppTask.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Update examples/refrigerator-app/silabs/include/AppTask.h

Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>

* Removed commented code

* Updated read me for OTA documentation for SiWx917

* Adds changes for refrigerator modes and callbacks

* Added chip logs

* Updated the error message

* Restyled by whitespace

* Restyled by clang-format

* Updated refrigerator app matter file

* Added the changes related  to zap file and the mode supported

* Restyled by whitespace

* Restyled by clang-format

* Added changes for Temperature Controller feature Map

* Updated featureMap value for matter file

* Removed the temperature level

* Removed the startup and on mode from attributes

* Setting min and max temperature for the controlled cabinet

* Removed the Temperature level attribute from the Temperature controller

* Removed the min and max temperature

* Removed the attribute update for refrigerator and temperature cluster

* Added changes for the zap file

* Added restyle changes

* Updated matter file

* Added OTA requester

* Added changes for the attribute

* Added changes for the zap

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>
Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Added changes for the zap files

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Rohan Sahay <Rohan.Sahay@silabs.com>
Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
(cherry picked from commit 803e819)
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants