-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NXP][third_party] Border router updates and fixes #36118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed selecting correct DnsSd implementation when Border Router is enabled. Fix an issue with the SRP client starting even when the device is running in Border Router mode. Removed ChipDnssdShutdown function, there is no use for it. Removed unused OpenThread define. Signed-off-by: Marius Preda <marius.preda@nxp.com>
Review changes with SemanticDiff. |
b53dd8d
to
35605be
Compare
Added submodule label because the check is triggered by changes in |
35605be
to
4edd6d3
Compare
axelnxp
approved these changes
Oct 17, 2024
PR #36118: Size comparison from 150db87 to 4edd6d3 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 17, 2024
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…ject-chip#36118) * [NXP][third_party] Border router updates and fixes Fixed selecting correct DnsSd implementation when Border Router is enabled. Fix an issue with the SRP client starting even when the device is running in Border Router mode. Removed ChipDnssdShutdown function, there is no use for it. Removed unused OpenThread define. Signed-off-by: Marius Preda <marius.preda@nxp.com> * Restyled by clang-format --------- Signed-off-by: Marius Preda <marius.preda@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 190c5c8)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
…xes (project-chip#36118)" This reverts commit 7035094. Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Dec 11, 2024
…ject-chip#36118) * [NXP][third_party] Border router updates and fixes Fixed selecting correct DnsSd implementation when Border Router is enabled. Fix an issue with the SRP client starting even when the device is running in Border Router mode. Removed ChipDnssdShutdown function, there is no use for it. Removed unused OpenThread define. Signed-off-by: Marius Preda <marius.preda@nxp.com> * Restyled by clang-format --------- Signed-off-by: Marius Preda <marius.preda@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 190c5c8)
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [NXP][third_party] Border router updates and fixes Fixed selecting correct DnsSd implementation when Border Router is enabled. Fix an issue with the SRP client starting even when the device is running in Border Router mode. Removed ChipDnssdShutdown function, there is no use for it. Removed unused OpenThread define. Signed-off-by: Marius Preda <marius.preda@nxp.com> * Restyled by clang-format --------- Signed-off-by: Marius Preda <marius.preda@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
examples
platform
review - approved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Fixed selecting correct DnsSd implementation when Border Router is enabled.
*Fix an issue with the SRP client starting even when the device is running in Border Router mode.
*Removed ChipDnssdShutdown function, there is no use for it.
*Removed unused OpenThread define.