-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Add _ById commands support for darwin-framework-tool #35996
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_DarwinFrameworkToolByIdPartialSupports
Oct 11, 2024
Merged
[YAML] Add _ById commands support for darwin-framework-tool #35996
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_DarwinFrameworkToolByIdPartialSupports
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 2 of 6 files. Overall, the semantic diff is 5% smaller than the GitHub diff.
|
32ef1f9
to
c8b5ff0
Compare
PR #35996: Size comparison from d4c2eaf to c8b5ff0 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 9, 2024
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Show resolved
Hide resolved
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/clusters/ClusterCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/clusters/ReportCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/clusters/ReportCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/clusters/WriteAttributeCommandBridge.h
Outdated
Show resolved
Hide resolved
c8b5ff0
to
89d3acb
Compare
PR #35996: Size comparison from 8a01f93 to 89d3acb Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
89d3acb
to
501a393
Compare
PR #35996: Size comparison from a0eafce to 501a393 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
501a393
to
aab8cef
Compare
PR #35996: Size comparison from 33991c5 to aab8cef Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces partial support for *ById YAML commands in the
darwin-framework-tool
backend.By partial I mean that while basic tests can be written, the complete tests (such as TestAttributesById.yaml and TestCommandsById.yaml) are not fully supported.
This is because
darwin-framework-tool
currently lacks features like handling multiple attributes, as well as the ability to returnUNSUPPORTED_ENDPOINT
when targeting a nonexistent endpoint.For now, this is mainly useful for testing specific code paths under certain scenarios that uses those commands.