Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Refactor Sensor code #35992

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[Silabs] Refactor Sensor code #35992

merged 1 commit into from
Oct 9, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description
Goal of the PR is to update the sensor software that was used by the Thermostat to make it more generic.

  • Transition the ThermostatSensor code to Si70xxSensor to represent physical leverage and make it less temperature specific. Humidity sensor is used in other sample apps now.
  • Update gn arguments and define to fit with the renaming
  • make WriteUI() public to avoid needing to set a boolean that had to no impact on the LCD
  • Update the thermostat app to always update the value attribute but only trigger a report if the temperature variation is over a given threshold.

PR is cherry-picked from #35979

####Tests
Manual tests

@mkardous-silabs
[Silabs] Refactor Sensor code (project-chip#35979)
ee70414 
* Refactor Sensor and LCD code

* Address review comments
@mkardous-silabs mkardous-silabs requested a review from a team as a code owner October 9, 2024 13:33
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 9, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 13 files.

Filename Status
❔ third_party/silabs/efr32_sdk.gni Unsupported file format
✔️ third_party/silabs/matter_support Analyzed
❔ third_party/silabs/silabs_board.gni Unsupported file format
❔ examples/thermostat/silabs/BUILD.gn Unsupported file format
❔ examples/thermostat/silabs/src/SensorManager.cpp Unsupported file format
❔ examples/platform/silabs/Si70xxSensor.cpp Unsupported file format
❔ examples/platform/silabs/Si70xxSensor.h Unsupported file format
❔ examples/platform/silabs/TemperatureSensor.cpp Unsupported file format
❔ examples/platform/silabs/TemperatureSensor.h Unsupported file format
❔ examples/platform/silabs/efr32/BUILD.gn Unsupported file format
❔ examples/platform/silabs/display/demo-ui.c Unsupported file format
❔ examples/platform/silabs/display/lcd.h Unsupported file format
❔ examples/platform/silabs/SiWx917/BUILD.gn Unsupported file format

@mkardous-silabs mkardous-silabs added the changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) label Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

PR #35992: Size comparison from 3ff8a03 to ee70414

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3ff8a03 ee70414 change % change
bl602 lighting-app bl602 FLASH 1280534 1280534 0 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308582 1308582 0 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335202 1335202 0 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957388 957388 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051092 1051092 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658066 658066 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824862 824862 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961870 961870 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974632 974632 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829284 829284 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814608 814608 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761156 761156 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745392 745392 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616882 616882 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656970 656970 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678237 678237 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698089 698089 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698089 698089 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655025 655025 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614581 614581 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634209 634209 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634209 634209 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633893 633893 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653609 653609 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653609 653609 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609197 609197 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629057 629057 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629057 629057 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933788 933664 -124 -0.0
RAM 135876 135876 0 0.0
lock-app BRD2605a FLASH 740176 740168 -8 -0.0
RAM 230240 230240 0 0.0
BRD4338a FLASH 740824 740816 -8 -0.0
RAM 230272 230272 0 0.0
window-app BRD4187C FLASH 1017192 1017068 -124 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1538374 1538374 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548838 1548838 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2778737 2778737 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6082682 6082682 0 0.0
RAM 510528 510528 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5415966 5415966 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4749386 4749386 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12652240 12652240 0 0.0
RAM 560626 560626 0 0.0
chip-tool-ipv6only arm64 unknown 20672 20672 0 0.0
FLASH 11290976 11290976 0 0.0
RAM 610944 610944 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11004893 11004893 0 0.0
RAM 560058 560058 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4572352 4572352 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5689201 5689201 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4798982 4798982 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4428370 4428370 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4567186 4567186 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3108765 3108765 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4317120 4317120 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6026821 6026821 0 0.0
RAM 584064 584064 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10848077 10848077 0 0.0
RAM 648912 648912 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914168 914168 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884952 884952 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847588 847588 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581928 581928 0 0.0
RAM 70784 70784 0 0.0
k32w1+release FLASH 596632 596632 0 0.0
RAM 63008 63008 0 0.0
mcxw71+release FLASH 596392 596392 0 0.0
RAM 63008 63008 0 0.0
light k32w0+release FLASH 618516 618516 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682632 682632 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682632 682632 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 704984 704984 0 0.0
RAM 67148 67148 0 0.0
mcxw71+release FLASH 704992 704992 0 0.0
RAM 67148 67148 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646044 1646044 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552100 1552100 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467572 1467572 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464644 1464644 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660272 660272 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618284 618284 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481568 481568 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620672 620672 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687868 687868 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780860 780860 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680770 680770 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620436 620436 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708376 708376 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625374 625374 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811134 811134 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656342 656342 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696746 696746 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634068 634068 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611258 611258 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467862 467862 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627586 627586 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653394 653394 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 637990 637990 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524132 524132 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725728 1725728 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10424 10424 0 0.0
FLASH 17520538 17520538 0 0.0
RAM 7626644 7626644 0 0.0

@andy31415 andy31415 merged commit 42efe9d into project-chip:v1.4-branch Oct 9, 2024
69 of 71 checks passed
@mkardous-silabs mkardous-silabs deleted the cherry-pick/sensor_update branch October 9, 2024 15:14
dinabenamar pushed a commit to NXP/matter that referenced this pull request Oct 24, 2024
@mkardous-silabs @andrei-menzopol
[nxp fromtree] [Silabs] Refactor Sensor code (project-chip#35979) (pr…
cf63957 
…oject-chip#35992)

* Refactor Sensor and LCD code

* Address review comments
(cherry picked from commit 42efe9d)
marius-alex-tache pushed a commit to NXP/matter that referenced this pull request Nov 14, 2024
@chapongatien
Revert "[nxp fromtree] [Silabs] Refactor Sensor code (project-chip#35979
a8d5ae8 
) (project-chip#35992)"

This reverts commit cf63957.

Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jan 16, 2025
@mkardous-silabs @adigie
[nrf fromtree] [Silabs] Refactor Sensor code (project-chip#35979) (pr…
e53ed43 
…oject-chip#35992)

* Refactor Sensor and LCD code

* Address review comments

(cherry picked from commit 42efe9d)
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees
No one assigned
Labels
changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) examples platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @andy31415 @jmartinez-silabs