esp32-fix-empty-logs(#35939) #35965
Merged
esp32-fix-empty-logs(#35939) #35965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
|
|
PR #35965: Size comparison from 1dadbe4 to fc2305f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 8, 2024
bzbarsky-apple
approved these changes
Oct 8, 2024
|
PR #35965: Size comparison from a854245 to 7009b63 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Hi @mokap13, The earlier changes (#26348) were made with specific requirements in mind. The The log format consists of three parts:
We intentionally added the printf statements to ensure we could apply colors to logs redirected to the console while optimizing the usage of buffer. These changes were introduced in this PR. Given this context, I believe the change in #35965 should be reverted. |
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Oct 11, 2024
This reverts commit 2a19f57.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Revert "esp32-fix-empty-logs(project-chip#35939) (project-chip#35965)" This reverts commit 2a19f57. * Add comment explaining why printf is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35939
Replaced
printfwithesp_log_write, that check log level