[ICD] Make optional spec checks mandatory with the launch of LongIdle… #35960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Time ICDs (project-chip#35956) * Remove optional spec check * Add static_assert for the slow poll config for SIT ICDs * Add missing include * fix restyler error * fix spacing * Remove client build flag since it is not used
|
Review changes with SemanticDiff. |
jmartinez-silabs
approved these changes
Oct 8, 2024
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…nch of LongIdleTime ICDs (project-chip#35956) (project-chip#35960) * Remove optional spec check * Add static_assert for the slow poll config for SIT ICDs * Add missing include * fix restyler error * fix spacing * Remove client build flag since it is not used (cherry picked from commit 8e0b710)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
… the launch of LongIdleTime ICDs (project-chip#35956) (project-chip#35960)" This reverts commit 57608da. Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jan 16, 2025
…nch of LongIdleTime ICDs (project-chip#35956) (project-chip#35960) * Remove optional spec check * Add static_assert for the slow poll config for SIT ICDs * Add missing include * fix restyler error * fix spacing * Remove client build flag since it is not used (cherry picked from commit 8e0b710) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the official launch of Long Idle Time ICD, the optionnal spec verification need to be enforced since the the SIT and LIT requirements are now mandatory.
Cherry-Pick of #35956 which is merged on master.
Testing
CI and manual