[AllClusters] If opened multiple times and something fails in Init, closing the app with Ctrl^C makes it crashes #35844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35844: Size comparison from f54e3c8 to 7c7b1d3 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Sep 30, 2024
bzbarsky-apple
approved these changes
Sep 30, 2024
7c7b1d3 to
17ec60c
Compare
|
PR #35844: Size comparison from aef88b6 to 17ec60c Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ing if someone calls Shutdown before Init
17ec60c to
333194b
Compare
|
PR #35844: Size comparison from 425b53c to a6fdde2 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 7, 2024
andy31415
approved these changes
Oct 8, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…losing the app with Ctrl^C makes it crashes (project-chip#35844) * [InteractionModelEngine] Add some checks to Shutdown to prevent crashing if someone calls Shutdown before Init * [CommissioningWindowManager] Ensure Shutdown does nothing if Init has not been called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Run:
Basically, Init is failing, but most of our objects don’t provide a way for the caller to know whether they’ve been initialized.
In this case, the caller (
src/app/server/Server.cpp) unconditionally calls the shutdown method. Since the shutdown method doesn’t perform any null checks, this results in crashes.This PR adds null checks to prevent these crashes.
Other solutions I’ve considered are:
• Updating the caller to track which objects have been initialized using custom variables. However, this approach adds more complexity to the calling code and increases the likelihood of errors.
• Modifying the objects to have internal states, allowing the caller to check whether they’ve been initialized. The caller would then need to check these states before calling the shutdown method.