-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebRTC clusters definitions #35839
Add WebRTC clusters definitions #35839
Conversation
Review changes with SemanticDiff. Analyzed 3 of 7 files.
|
PR #35839: Size comparison from 6bbe1d6 to 7bf58e6 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
7bf58e6
to
46ec890
Compare
PR #35839: Size comparison from 83159c2 to 46ec890 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
I think we may be trampling each others' work 😅 I originally had this PR as one big one, as they are all somewhat interlinked: #35773 But @bzbarsky-apple requested that I split it up to one-cluster-per-PR, and so I've done that & have a pending PR for one of the webrtc clustes: #35779 (was going to get that in first before doing the 2nd) It looks like you're not using the latest version of Alchemy, which also has some fixes which support typedef for the ID fields (so you don't have to hand-edit) |
ok, killing this one and will create a new pr just with requestor |
2 interlinked WebRTC clusters defined. The spec is in the cameras branch of the specs repo.
There is a StreamType enum added to one of the clusters (used in both) that is defined in the spec in a different cluster (AVStreamManagement). I have defined in here to unblock for now, and added an issue to remove as soon as AVStreamManagement cluster definition is merged.