Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove illegal Identify clusters from examples #35575

Merged
merged 11 commits into from
Sep 16, 2024
Merged

Remove illegal Identify clusters from examples #35575

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8da524c
Remove illegal Identify clusters from examples
tcarmelveilleux Sep 13, 2024
3ff9bbc
Fix CI
tcarmelveilleux Sep 13, 2024
cf1beb5
Update PairOnNetworkLongImInvokeCommand.kt
yunhanw-google Sep 13, 2024
9cb2c50
Update PairOnNetworkLongImInvokeCommand.kt
yunhanw-google Sep 13, 2024
d1efd8d
Update PairOnNetworkLongImInvokeCommand.kt
yunhanw-google Sep 14, 2024
2075e0e
Update PairOnNetworkLongImInvokeCommand.kt
yunhanw-google Sep 14, 2024
83fb09a
fix java/kotlin style
yunhanw-google Sep 14, 2024
4dfe979
Update PairOnNetworkLongImSubscribeCommand.kt
yunhanw-google Sep 15, 2024
4e0a415
Update PairOnNetworkLongImSubscribeCommand.kt
yunhanw-google Sep 16, 2024
3676f1d
fix tests
yunhanw-google Sep 16, 2024
6680f5f
restyle
yunhanw-google Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7798,16 +7798,6 @@ endpoint 0 {

binding cluster OtaSoftwareUpdateProvider;

server cluster Identify {
ram attribute identifyTime default = 0x0000;
ram attribute identifyType default = 0x0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;

handle command Identify;
handle command TriggerEffect;
}

server cluster Groups {
ram attribute nameSupport;
ram attribute featureMap default = 0;
Expand Down
92 changes: 0 additions & 92 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,98 +69,6 @@
"deviceTypeCode": 17,
"deviceTypeProfileId": 259,
"clusters": [
{
"name": "Identify",
"code": 3,
"mfgCode": null,
"define": "IDENTIFY_CLUSTER",
"side": "server",
"enabled": 1,
"commands": [
{
"name": "Identify",
"code": 0,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
},
{
"name": "TriggerEffect",
"code": 64,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
}
],
"attributes": [
{
"name": "IdentifyTime",
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "IdentifyType",
"code": 1,
"mfgCode": null,
"side": "server",
"type": "IdentifyTypeEnum",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "FeatureMap",
"code": 65532,
"mfgCode": null,
"side": "server",
"type": "bitmap32",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ClusterRevision",
"code": 65533,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "4",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
}
]
},
{
"name": "Groups",
"code": 4,
Expand Down
9 changes: 0 additions & 9 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6242,15 +6242,6 @@ endpoint 0 {

binding cluster OtaSoftwareUpdateProvider;

server cluster Identify {
ram attribute identifyTime default = 0x0000;
ram attribute identifyType default = 0x0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;

handle command Identify;
}

server cluster Groups {
ram attribute nameSupport;
ram attribute featureMap default = 0;
Expand Down
84 changes: 0 additions & 84 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,90 +69,6 @@
"deviceTypeCode": 17,
"deviceTypeProfileId": 259,
"clusters": [
{
"name": "Identify",
"code": 3,
"mfgCode": null,
"define": "IDENTIFY_CLUSTER",
"side": "server",
"enabled": 1,
"commands": [
{
"name": "Identify",
"code": 0,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
}
],
"attributes": [
{
"name": "IdentifyTime",
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "IdentifyType",
"code": 1,
"mfgCode": null,
"side": "server",
"type": "IdentifyTypeEnum",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "FeatureMap",
"code": 65532,
"mfgCode": null,
"side": "server",
"type": "bitmap32",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ClusterRevision",
"code": 65533,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "4",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
}
]
},
{
"name": "Groups",
"code": 4,
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3594,4 +3594,4 @@
"parentEndpointIdentifier": null
}
]
}
}
10 changes: 0 additions & 10 deletions examples/chef/devices/rootnode_dishwasher_cc105034fe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,16 +1368,6 @@ endpoint 0 {
device type ma_rootdevice = 22, version 1;


server cluster Identify {
ram attribute identifyTime default = 0x0000;
ram attribute identifyType default = 0x00;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;

handle command Identify;
handle command TriggerEffect;
}

server cluster Descriptor {
callback attribute deviceTypeList;
callback attribute serverList;
Expand Down
92 changes: 0 additions & 92 deletions examples/chef/devices/rootnode_dishwasher_cc105034fe.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,98 +61,6 @@
"deviceTypeCode": 22,
"deviceTypeProfileId": 259,
"clusters": [
{
"name": "Identify",
"code": 3,
"mfgCode": null,
"define": "IDENTIFY_CLUSTER",
"side": "server",
"enabled": 1,
"commands": [
{
"name": "Identify",
"code": 0,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
},
{
"name": "TriggerEffect",
"code": 64,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
}
],
"attributes": [
{
"name": "IdentifyTime",
"code": 0,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "IdentifyType",
"code": 1,
"mfgCode": null,
"side": "server",
"type": "IdentifyTypeEnum",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x00",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "FeatureMap",
"code": 65532,
"mfgCode": null,
"side": "server",
"type": "bitmap32",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ClusterRevision",
"code": 65533,
"mfgCode": null,
"side": "server",
"type": "int16u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "4",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
}
]
},
{
"name": "Descriptor",
"code": 29,
Expand Down
Loading
Loading