Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeviceSubscription for CADMIN cluster for bridged devices #35239

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Add DeviceSubscription for CADMIN cluster for bridged devices #35239

merged 9 commits into from
Aug 29, 2024

Conversation

tehampson
Copy link
Contributor

No description provided.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@tehampson tehampson mentioned this pull request Aug 28, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

PR #35239: Size comparison from 0944982 to 2f4efaa

Full report (61 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0944982 2f4efaa change % change
bl602 lighting-app bl602 FLASH 1279022 1279022 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292876 1292876 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317986 1317986 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944636 944636 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947036 947036 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039692 1039692 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647452 647452 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894866 894866 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961040 961040 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963662 963662 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672673 672673 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649469 649469 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611113 611113 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629153 629153 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603093 603093 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 930748 930740 -8 -0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740732 740724 -8 -0.0
RAM 208492 208492 0 0.0
window-app BRD4187C FLASH 1015808 1015800 -8 -0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1534122 1534122 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1544162 1544162 0 0.0
IRAM 117039 117039 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 910604 910604 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882564 882564 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841616 841616 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577732 577732 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590352 590352 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613160 613160 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 675024 675024 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641516 1641516 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1545132 1545132 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464636 1464636 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656300 656300 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614144 614144 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478640 478640 0 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620414 620414 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 682470 682470 0 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774652 774652 0 0.0
RAM 110712 110712 0 0.0
bridge-app tlsr9258a FLASH 679144 679144 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622006 622006 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708016 708016 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620950 620950 0 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 807082 807082 0 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654988 654988 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697272 697272 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631452 631452 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608962 608962 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628792 628792 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652944 652944 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635450 635450 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522948 522948 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1710276 1710276 0 0.0
RAM 89376 89376 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508630 17508630 0 0.0
RAM 7600684 7600684 0 0.0

@yufengwangca
Copy link
Contributor

Could we move those two files to folder device_manager? they are not implementing any of pairing command.

I will put another PR to to move DeviceDeviceSynchronizer

@tehampson
Copy link
Contributor Author

Could we move those two files to folder device_manager? they are not implementing any of pairing command.

I will put another PR to to move DeviceDeviceSynchronizer

After you post the PR I will update to the corresponding location

@mergify mergify bot added conflict and removed conflict labels Aug 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

PR #35239: Size comparison from a7dde85 to b9d8850

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a7dde85 b9d8850 change % change
bl602 lighting-app bl602 FLASH 1279022 1279022 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292876 1292876 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317986 1317986 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944636 944636 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947036 947036 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039692 1039692 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647452 647452 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894866 894866 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961040 961040 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963662 963662 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672673 672673 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649469 649469 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611113 611113 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629153 629153 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603093 603093 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 930748 930740 -8 -0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740732 740724 -8 -0.0
RAM 209516 209516 0 0.0
window-app BRD4187C FLASH 1015808 1015800 -8 -0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1534232 1534232 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1544250 1544250 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2760195 2760195 0 0.0
RAM 128520 128520 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6048894 6048894 0 0.0
RAM 510328 510328 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5383170 5383170 0 0.0
RAM 240232 240232 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4730458 4730458 0 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12648900 12648900 0 0.0
RAM 558418 558418 0 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11321036 11321036 0 0.0
RAM 608488 608488 0 0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10927255 10927255 0 0.0
RAM 556634 556634 0 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4554366 4554366 0 0.0
RAM 203856 203856 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5666705 5666705 0 0.0
RAM 228056 228056 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4785804 4785804 0 0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4425278 4425278 0 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4563896 4563896 0 0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3085661 3085661 0 0.0
RAM 159040 159040 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4323356 4323356 0 0.0
RAM 241888 241888 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6010325 6010325 0 0.0
RAM 583256 583256 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10853725 10853725 0 0.0
RAM 645832 645832 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 910676 910676 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882632 882632 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841616 841616 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577732 577732 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590352 590352 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613160 613160 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 675024 675024 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641596 1641596 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1545132 1545132 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464636 1464636 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656300 656300 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614144 614144 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478640 478640 0 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620414 620414 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 682574 682574 0 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774652 774652 0 0.0
RAM 110712 110712 0 0.0
bridge-app tlsr9258a FLASH 679144 679144 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622006 622006 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708016 708016 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620950 620950 0 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 807082 807082 0 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654988 654988 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697272 697272 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631452 631452 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608962 608962 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628792 628792 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652944 652944 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635450 635450 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522948 522948 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1710388 1710388 0 0.0
RAM 89376 89376 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508630 17508630 0 0.0
RAM 7600684 7600684 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

PR #35239: Size comparison from a7dde85 to 1b2f947

Full report (43 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section a7dde85 1b2f947 change % change
bl602 lighting-app bl602 FLASH 1279022 1279022 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292876 1292876 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317986 1317986 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944636 944636 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947036 947036 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039692 1039692 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647452 647452 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894866 894866 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961040 961040 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963662 963662 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672673 672673 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692533 692533 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649469 649469 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611113 611113 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630749 630749 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629153 629153 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648861 648861 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603093 603093 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622953 622953 0 0.0
RAM 70980 70980 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1534232 1534426 194 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1544250 1544454 204 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11321036 11320764 -272 -0.0
RAM 608488 608424 -64 -0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4323356 4323356 0 0.0
RAM 241888 241888 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 910676 910676 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882632 882632 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841616 841616 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577732 577732 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590352 590352 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613160 613160 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 675024 675024 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641596 1641596 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1545132 1545132 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464636 1464636 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656300 656300 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614144 614144 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478640 478640 0 0.0
RAM 144716 144716 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1710388 1710388 0 0.0
RAM 89376 89376 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508630 17507350 -1280 -0.0
RAM 7600684 7600020 -664 -0.0

saurabhst
saurabhst approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@saurabhst saurabhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editorial mostly for better understanding of comments

@tehampson @saurabhst
Apply suggestions from code review
5f5c4b6 
Co-authored-by: saurabhst <s.kumar9@samsung.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

PR #35239: Size comparison from a7dde85 to 5f5c4b6

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a7dde85 5f5c4b6 change % change
bl602 lighting-app bl602 FLASH 1279022 1279092 70 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292876 1293202 326 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317986 1318056 70 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944636 944678 42 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947036 947078 42 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039692 1039734 42 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647452 647494 42 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894866 894908 42 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961040 961082 42 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963662 963704 42 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672673 672761 88 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692533 692621 88 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692533 692621 88 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649469 649549 80 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611113 611193 80 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630749 630821 72 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630749 630821 72 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629153 629233 80 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648861 648941 80 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648861 648941 80 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603093 603165 72 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622953 623025 72 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622953 623025 72 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 930748 930812 64 0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740732 740844 112 0.0
RAM 209516 209516 0 0.0
window-app BRD4187C FLASH 1015808 1015896 88 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1534232 1534510 278 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1544250 1544510 260 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2760195 2761505 1310 0.0
RAM 128520 128520 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6048894 6055032 6138 0.1
RAM 510328 510312 -16 -0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5383170 5384480 1310 0.0
RAM 240232 240232 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4730458 4731800 1342 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12648900 12649906 1006 0.0
RAM 558418 558354 -64 -0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11321036 11321996 960 0.0
RAM 608488 608424 -64 -0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10927255 10929653 2398 0.0
RAM 556634 556602 -32 -0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4554366 4554580 214 0.0
RAM 203856 203984 128 0.1
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5666705 5668049 1344 0.0
RAM 228056 228056 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4785804 4787114 1310 0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4425278 4426652 1374 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4563896 4565206 1310 0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3085661 3086973 1312 0.0
RAM 159040 159040 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4323356 4324588 1232 0.0
RAM 241888 241888 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6010325 6011605 1280 0.0
RAM 583256 583192 -64 -0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10853725 10854733 1008 0.0
RAM 645832 645768 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 910676 910748 72 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882632 882680 48 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841616 841688 72 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577732 577796 64 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590352 590416 64 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613160 613224 64 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 675024 675104 80 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641596 1641724 128 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1545132 1545268 136 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464636 1464764 128 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463524 1463652 128 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656300 656348 48 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614144 614208 64 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478640 478696 56 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620414 620504 90 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 682574 682664 90 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774652 774742 90 0.0
RAM 110712 110712 0 0.0
bridge-app tlsr9258a FLASH 679144 679234 90 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622006 622096 90 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708016 708106 90 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620950 621040 90 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 807082 807172 90 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654988 655078 90 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697272 697362 90 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631452 631542 90 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608962 609052 90 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628792 628882 90 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652944 653034 90 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635450 635540 90 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522948 523038 90 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1710388 1711176 788 0.0
RAM 89376 89376 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508630 17508662 32 0.0
RAM 7600684 7600300 -384 -0.0

@tehampson tehampson enabled auto-merge (squash) August 29, 2024 18:34
@tehampson tehampson merged commit ac5dfee into project-chip:master Aug 29, 2024
66 of 67 checks passed
@tehampson tehampson mentioned this pull request Sep 9, 2024
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
@tehampson @restyled-commits
@saurabhst @shgutte
Add DeviceSubscription for CADMIN cluster for bridged devices (projec…
a1d7427 
…t-chip#35239)

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: saurabhst <s.kumar9@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @yufengwangca @saurabhst @restyled-commits