Get OnNetwork commissioning working #34978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #34978: Size comparison from 0ea43c9 to 2538710 Full report (3 builds for cc32xx, stm32)
|
|
PR #34978: Size comparison from 0ea43c9 to 831ef5a Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34978: Size comparison from b823a29 to 97e103b Full report (71 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34978: Size comparison from 9a90d8b to 29417c8 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34978: Size comparison from ff6863e to 3156be2 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34978: Size comparison from 8b97b28 to 81dfa8b Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Hey ! I don't know why Darwin / Run framework tests (tsan, -enableThreadSanitizer YES) (pull_request) always failed ? @Damian-Nordic @andy31415 any clue ? Edit : Seems to be good |
|
PR #34978: Size comparison from 0851382 to 49590a8 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34978: Size comparison from a296b66 to d9de09a Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34978: Size comparison from c305e3f to c336d2f Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@Damian-Nordic @andy31415 Is there someone who can review this PR ? My internship finish in a week and half, thanks ! |
Damian-Nordic
approved these changes
Aug 28, 2024
|
Hi @Damian-Nordic ! Is there something else missing or everything is good ? |
|
|
@Damian-Nordic Okay thanks ! I asked because it isn't merge actually |
|
PR #34978: Size comparison from 9bbf5b9 to 86134c7 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
It wasn't merged because PRs need two reviews from different companies to merge, and because it had a random CI failure. CI job retriggered.
Rubber-stamping; the changes I understand look reasonable, and I trust @Damian-Nordic checked the other bits carefully.
|
Hey @bzbarsky-apple, sorry to rush you a bit with this PR. I understand that revisions can take time, and there's also the vacations, but my internship ends in a week (and my account with it), so that's why I was in a bit of a hurry! Thank you for your understanding. |
|
PR #34978: Size comparison from 0e3434a to 25e14f7 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Update Zephyr platform to get working commissioning for onnetwork purposes * Restyled by whitespace * Remove unwanted and unnecessary comments Signed-off-by: Caldeira, Quentin <QuentinCaldeira@eaton.com> * Bring Openthread default config back * Bring back udp and tcp configurations --------- Signed-off-by: Caldeira, Quentin <QuentinCaldeira@eaton.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in many others issues, Zephyr platform doesn't handle well the OnNetwork Commissioning. This PR add some missing things like the Kconfig MBEDTLS_X509, and the patch for Multicast Join made by nRF (I guess). It seems that Zephyr platform doesn't required an Ethernet Driver, but it should be nice to have one which perform DHCP or static ipv6 address.
Now, the OnNetwork commissioning is working. I've a full application working with ethernet only. I don't have a Thread or WiFi board to develop it more. Should be nice to have a real Zephyr SDK based application.
The application and this PR were tested on a Nucleo h563zi, with the zephyr SDK, and Home Assistant on a Raspberry as a controller. No issues so far. Factory Reset is working, Zephyr handle the Ethernet disconnection, and you can power off, then power on the device with no connection lost.
I could provide the application in another PR if you want. I think we maybe should have a work on include specific Kconfig only when Ethernet or wifi is selected, to reduce the application size.
Also, I put OpenThread to false by default, because like Bluetooth the user shouldn't have to expect that theses components are enables, as this is not the only way to communicate in Matter. If it's a problem, I can put it back on