Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tv-casting-app fixed 32-bit vs 64-bit formatting issue #34866

Merged
merged 3 commits into from
Aug 8, 2024
Merged

tv-casting-app fixed 32-bit vs 64-bit formatting issue #34866

merged 3 commits into from
Aug 8, 2024

Conversation

pgregorr-amazon
Copy link
Contributor

In connectedhomeip/examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp

To ensure compatibility across both 32-bit and 64-bit platforms, using the %zu format specifier for size_t values, which are returned by the size() methods of STL containers. This approach is platform-independent and will work correctly on both 32-bit and 64-bit systems.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

PR #34866: Size comparison from befc990 to 6f09140

Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
platform target config section befc990 6f09140 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802972 802972 0 0.0
RAM 117628 117628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818800 818800 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 811156 811156 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763328 763328 0 0.0
RAM 113648 113648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747812 747812 0 0.0
RAM 113840 113840 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612202 612202 0 0.0
RAM 205388 205388 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654802 654802 0 0.0
RAM 205620 205620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908576 908576 0 0.0
RAM 142239 142239 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880596 880596 0 0.0
RAM 140378 140378 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 840168 840168 0 0.0
RAM 141058 141058 0 0.0
nxp contact k32w0+release FLASH 577196 577196 0 0.0
RAM 70468 70468 0 0.0
k32w1+release FLASH 592496 592496 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612640 612640 0 0.0
RAM 69940 69940 0 0.0
k32w1+release FLASH 677472 677472 0 0.0
RAM 83232 83232 0 0.0
qpg lighting-app qpg6105+debug FLASH 655716 655716 0 0.0
RAM 105152 105152 0 0.0
lock-app qpg6105+debug FLASH 613072 613072 0 0.0
RAM 99636 99636 0 0.0
stm32 light STM32WB5MM-DK FLASH 478120 478120 0 0.0
RAM 144764 144764 0 0.0
tizen all-clusters-app arm unknown 4796 4796 0 0.0
FLASH 1695932 1695932 0 0.0
RAM 89172 89172 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17308510 17308510 0 0.0
RAM 7562468 7562468 0 0.0

@sharadb-amazon sharadb-amazon enabled auto-merge (squash) August 8, 2024 04:26
@sharadb-amazon sharadb-amazon disabled auto-merge August 8, 2024 04:29
woody-apple and others added 2 commits August 7, 2024 21:32
@woody-apple @kiel-apple
Apply suggestions from code review
d1ad575 
Co-authored-by: Kiel Oleson <kielo@apple.com>
@restyled-commits @woody-apple
Restyled by clang-format
3a8a103
@woody-apple woody-apple requested a review from kiel-apple August 8, 2024 04:38
@woody-apple woody-apple merged commit eb93c42 into project-chip:master Aug 8, 2024
59 of 65 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

PR #34866: Size comparison from befc990 to 3a8a103

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section befc990 3a8a103 change % change
bl602 lighting-app bl602 FLASH 1278058 1278058 0 0.0
RAM 95912 95912 0 0.0
bl602+mfd FLASH 1292314 1292314 0 0.0
RAM 96064 96064 0 0.0
bl602+rpc FLASH 1317274 1317274 0 0.0
RAM 104336 104336 0 0.0
bl702 lighting-app bl702 FLASH 1099206 1099206 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1110154 1110154 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189528 1189528 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 882240 882240 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135410 1135410 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086360 1086360 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097620 1097620 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802972 802972 0 0.0
RAM 117628 117628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818800 818800 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 811156 811156 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763328 763328 0 0.0
RAM 113648 113648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747812 747812 0 0.0
RAM 113840 113840 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612202 612202 0 0.0
RAM 205388 205388 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654802 654802 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672097 672097 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691949 691949 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691949 691949 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648893 648893 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610537 610537 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630173 630173 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630173 630173 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628009 628009 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647725 647725 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647725 647725 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601261 601261 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621121 621121 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621121 621121 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 930024 930016 -8 -0.0
RAM 135144 135144 0 0.0
lock-app BRD4338a FLASH 737148 737140 -8 -0.0
RAM 208440 208440 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94152 94152 0 0.0
FLASH 1532968 1532968 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542790 1542790 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11167804 11167804 0 0.0
RAM 607408 607408 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360740 4360740 0 0.0
RAM 242240 242240 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908576 908576 0 0.0
RAM 142239 142239 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880596 880596 0 0.0
RAM 140378 140378 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 840168 840168 0 0.0
RAM 141058 141058 0 0.0
nxp contact k32w0+release FLASH 577196 577196 0 0.0
RAM 70468 70468 0 0.0
k32w1+release FLASH 592496 592496 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612640 612640 0 0.0
RAM 69940 69940 0 0.0
k32w1+release FLASH 677472 677472 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637572 1637572 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1543004 1543004 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1463540 1463540 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462188 1462188 0 0.0
RAM 225112 225112 0 0.0
qpg lighting-app qpg6105+debug FLASH 655716 655716 0 0.0
RAM 105152 105152 0 0.0
lock-app qpg6105+debug FLASH 613072 613072 0 0.0
RAM 99636 99636 0 0.0
stm32 light STM32WB5MM-DK FLASH 478120 478120 0 0.0
RAM 144764 144764 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619928 619928 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680272 680272 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 773274 773274 0 0.0
RAM 110736 110736 0 0.0
bridge-app tlsr9258a FLASH 678616 678616 0 0.0
RAM 91636 91636 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621524 621524 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707406 707406 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620450 620450 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806536 806536 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654396 654396 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 696632 696632 0 0.0
RAM 91320 91320 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630912 630912 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608422 608422 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628296 628296 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652292 652292 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 633300 633300 0 0.0
RAM 53384 53384 0 0.0
window-covering tlsr9118bdk40d FLASH 522456 522456 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4796 4796 0 0.0
FLASH 1695932 1695932 0 0.0
RAM 89172 89172 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17308510 17308510 0 0.0
RAM 7562468 7562468 0 0.0

@kiel-apple
Copy link
Contributor

see followup in #34869

austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Aug 12, 2024
@pgregorr-amazon @woody-apple
@kiel-apple @restyled-commits @austina-csa
tv-casting-app fixed 32-bit vs 64-bit formatting issue (project-chip#…
b684269 
…34866)

* tv-casting-app fixed 32-bit vs 64-bit formatting issue

* Apply suggestions from code review

Co-authored-by: Kiel Oleson <kielo@apple.com>

* Restyled by clang-format

---------

Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Kiel Oleson <kielo@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@woody-apple woody-apple Awaiting requested review from woody-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

Assignees
No one assigned
Labels
examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgregorr-amazon @kiel-apple @sharadb-amazon @woody-apple @restyled-commits