Add water heater management test scripts #34340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34340: Size comparison from 049f5b2 to f9dfb28 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34340: Size comparison from 049f5b2 to 3a803e0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34340: Size comparison from f4d9188 to 421f3f3 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, nxp, psoc6, stm32, telink, tizen)
|
|
PR #34340: Size comparison from 44c725d to 5749641 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34340: Size comparison from 13fe13a to 5dc0d93 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
jamesharrow
reviewed
Jul 28, 2024
jamesharrow
reviewed
Jul 28, 2024
Removed assert TankVolume >= 0
|
PR #34340: Size comparison from 13fe13a to 7b2de55 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Jul 29, 2024
doru91
approved these changes
Jul 29, 2024
|
PR #34340: Size comparison from 5e3127f to 5c3af52 Full report (4 builds for cc32xx, mbed, stm32)
|
…ate is in valid range.
|
PR #34340: Size comparison from 5e3127f to 4162238 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34340: Size comparison from decd9e9 to b02938d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add water heater management test scripts * Define runner commands for WHM tests * Specify --featureSet option on runner command line * Add the --featureSet option to the RUNNER command line * Apply suggestions from code review - corrected test step numbers to align to test plan PR. * Apply suggestions from code review - Changing TestSteps into 3 entries * Renamed EWATERHTRBase.py to TC_EWATERHTRBase.py. Changed TestStep to 3 args entries (to split out verification step for readability). * Restyle fix. * Update src/python_testing/TC_EWATERHTR_2_1.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Start addressing review comments from JamesH * Remove water heater management app * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Address review comments from JamesH * Restyled by autopep8 * Restyled by isort * Update src/python_testing/TC_EWATERHTR_2_1.py * Update src/python_testing/TC_EWATERHTR_2_1.py Removed assert TankVolume >= 0 * Restored TC_EEVSE_2_4.py from master * Fixed issue raised on TC_EWATERHTR_2_1.py about checking that BoostState is in valid range. --------- Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> Co-authored-by: James Harrow <james.harrow@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add water heater management test scripts * Define runner commands for WHM tests * Specify --featureSet option on runner command line * Add the --featureSet option to the RUNNER command line * Apply suggestions from code review - corrected test step numbers to align to test plan PR. * Apply suggestions from code review - Changing TestSteps into 3 entries * Renamed EWATERHTRBase.py to TC_EWATERHTRBase.py. Changed TestStep to 3 args entries (to split out verification step for readability). * Restyle fix. * Update src/python_testing/TC_EWATERHTR_2_1.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Start addressing review comments from JamesH * Remove water heater management app * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Update src/python_testing/TC_EWATERHTR_2_3.py Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> * Address review comments from JamesH * Restyled by autopep8 * Restyled by isort * Update src/python_testing/TC_EWATERHTR_2_1.py * Update src/python_testing/TC_EWATERHTR_2_1.py Removed assert TankVolume >= 0 * Restored TC_EEVSE_2_4.py from master * Fixed issue raised on TC_EWATERHTR_2_1.py about checking that BoostState is in valid range. --------- Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com> Co-authored-by: James Harrow <james.harrow@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add water heater management cluster test scripts (issue Fixes #34254)
The water heater management cluster test spec can be found here:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4015
This PR follows is related to #34333 and #34339
There will be a further PR for the water heater management example application.