Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice conformance: Add choice conformance markers #33854

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Choice conformance: Add choice conformance markers #33854

merged 10 commits into from
Jul 17, 2024

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jun 11, 2024

Adds the ability to set choice conformance markers on optional conformances.

Test: Included in PR.

@cecille cecille changed the title Choice conformance conformance only Choice conformance: Add choice conformance markers Jun 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

PR #33854: Size comparison from 2ee90eb to 766df0c

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2ee90eb 766df0c change % change
bl602 lighting-app bl602 FLASH 1268298 1268298 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282576 1282576 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307256 1307256 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088938 1088938 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099888 1099888 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1179018 1179018 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124146 1124146 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076080 1076080 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087342 1087342 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797596 797596 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813392 813392 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802756 802756 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755244 755244 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740900 740900 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661253 661253 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638033 638033 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603429 603429 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619229 619229 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638953 638953 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638953 638953 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587469 587469 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887832 887832 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701672 701664 -8 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968748 968740 -8 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466214 1466214 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535419 1535419 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532240 2532240 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568590 5568590 0 0.0
RAM 482296 482296 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052616 5052616 0 0.0
RAM 236888 236888 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477768 4477768 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11489463 11489463 0 0.0
RAM 533474 533474 0 0.0
chip-tool-ipv6only arm64 unknown 19728 19728 0 0.0
FLASH 10632852 10632852 0 0.0
RAM 581464 581464 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11259575 11259575 0 0.0
RAM 527058 527058 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347352 4347352 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366002 5366002 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543272 4543272 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177528 4177528 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301976 4301976 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799949 2799949 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149604 4149604 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5586952 5586952 0 0.0
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9537926 9537926 0 0.0
RAM 351968 351968 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497748 1497748 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873828 873828 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948512 948512 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821804 821804 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575220 575220 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590464 590464 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609216 609216 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673648 673648 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1610156 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534356 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460652 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462948 1462948 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650216 650216 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610196 610196 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 472124 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625098 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770308 770308 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668228 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626850 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712688 712688 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792896 792896 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660154 660154 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686564 686564 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609050 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599398 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633244 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642236 642236 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618300 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1552 1552 0 0.0
FLASH 1613128 1613128 0 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15705266 15705266 0 0.0
RAM 6889008 6889008 0 0.0

@pullapprove pullapprove bot requested a review from ReneJosefsen June 26, 2024 19:48
cecille
cecille commented Jul 2, 2024
View reviewed changes
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
andy31415
andy31415 previously requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe enums should be immutable. Using enums to contain a global variable seems off.

@pullapprove pullapprove bot requested review from axelnxp, chapongatien and doru91 July 4, 2024 20:50
@andy31415 andy31415 dismissed their stale review July 8, 2024 17:27

Changes to make singletons immutable were done.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

PR #33854: Size comparison from c6af674 to ec24b92

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c6af674 ec24b92 change % change
bl602 lighting-app bl602 FLASH 1271340 1271340 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285598 1285598 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310300 1310300 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092178 1092178 0 0.0
RAM 15265 15265 0 0.0
bl702+mfd FLASH 1102872 1102872 0 0.0
RAM 15417 15417 0 0.0
bl702+rpc FLASH 1181988 1181988 0 0.0
RAM 24285 24285 0 0.0
bl706-eth FLASH 875510 875510 0 0.0
RAM 27376 27376 0 0.0
bl706-wifi FLASH 1127608 1127608 0 0.0
RAM 14709 14709 0 0.0
bl702l lighting-app bl702l FLASH 1079060 1079060 0 0.0
RAM 21836 21836 0 0.0
bl702l+mfd FLASH 1090322 1090322 0 0.0
RAM 21996 21996 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798348 798348 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816320 816320 0 0.0
RAM 116956 116956 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 807820 807820 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760692 760692 0 0.0
RAM 105336 105336 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746412 746412 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606074 606074 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651118 651118 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667497 667497 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687341 687341 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687341 687341 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644277 644277 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609129 609129 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628765 628765 0 0.0
RAM 73348 73348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628765 628765 0 0.0
RAM 73348 73348 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624633 624633 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644349 644349 0 0.0
RAM 76364 76364 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644349 644349 0 0.0
RAM 76364 76364 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593221 593221 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613073 613073 0 0.0
RAM 70428 70428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613073 613073 0 0.0
RAM 70428 70428 0 0.0
efr32 lighting-app BRD4187C FLASH 924456 924456 0 0.0
RAM 137516 137516 0 0.0
lock-app BRD4338a FLASH 733228 733220 -8 -0.0
RAM 207900 207900 0 0.0
window-app BRD4187C FLASH 1012300 1012300 0 0.0
RAM 129620 129620 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90860 0 0.0
FLASH 1469090 1469090 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117412 117412 0 0.0
FLASH 1538087 1538087 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2529936 2529936 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5590606 5590606 0 0.0
RAM 492176 492176 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5061520 5061520 0 0.0
RAM 235488 235488 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4478256 4478256 0 0.0
RAM 212744 212744 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11769703 11769703 0 0.0
RAM 545946 545946 0 0.0
chip-tool-ipv6only arm64 unknown 20064 20064 0 0.0
FLASH 10882348 10882348 0 0.0
RAM 594728 594728 0 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10850375 10850375 0 0.0
RAM 542754 542754 0 0.0
fabric-bridge-app debug unknown 4528 4528 0 0.0
FLASH 4243776 4243776 0 0.0
RAM 198808 198808 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5382594 5382594 0 0.0
RAM 224096 224096 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4541600 4541600 0 0.0
RAM 200240 200240 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4197648 4197648 0 0.0
RAM 194520 194520 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4323200 4323200 0 0.0
RAM 199176 199176 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2804925 2804925 0 0.0
RAM 153000 153000 0 0.0
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4167996 4167996 0 0.0
RAM 235640 235640 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5605920 5605920 0 0.0
RAM 341760 341760 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9939582 9939582 0 0.0
RAM 402128 402128 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502500 1502500 0 0.0
RAM 226640 226640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882448 882448 0 0.0
RAM 142109 142109 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 952948 952948 0 0.0
RAM 140537 140537 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 827984 827984 0 0.0
RAM 141023 141023 0 0.0
nxp contact k32w0+release FLASH 576028 576028 0 0.0
RAM 70004 70004 0 0.0
k32w1+release FLASH 591368 591368 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610224 610224 0 0.0
RAM 69480 69480 0 0.0
k32w1+release FLASH 674968 674968 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615252 1615252 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536092 1536092 0 0.0
RAM 206580 206580 0 0.0
light cy8ckit_062s2_43012 FLASH 1462724 1462724 0 0.0
RAM 199852 199852 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463236 1463236 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 651244 651244 0 0.0
RAM 104560 104560 0 0.0
lock-app qpg6105+debug FLASH 611368 611368 0 0.0
RAM 99228 99228 0 0.0
stm32 light STM32WB5MM-DK FLASH 473576 473576 0 0.0
RAM 144204 144204 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632734 632734 0 0.0
RAM 50424 50424 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658574 658574 0 0.0
RAM 148296 148296 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778900 778900 0 0.0
RAM 113116 113116 0 0.0
bridge-app tlsr9258a FLASH 675720 675720 0 0.0
RAM 95200 95200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634318 634318 0 0.0
RAM 50468 50468 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720192 720192 0 0.0
RAM 77044 77044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613722 613722 0 0.0
RAM 144532 144532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801474 801474 0 0.0
RAM 102936 102936 0 0.0
lock-app-dfu tlsr9528a FLASH 665886 665886 0 0.0
RAM 69756 69756 0 0.0
ota-requestor-app tlsr9258a FLASH 695050 695050 0 0.0
RAM 94924 94924 0 0.0
pump-app tlsr9518adk80d FLASH 616582 616582 0 0.0
RAM 56848 56848 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606966 606966 0 0.0
RAM 56648 56648 0 0.0
shell tlsr9518adk80d FLASH 466316 466316 0 0.0
RAM 72460 72460 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640936 640936 0 0.0
RAM 52096 52096 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650792 650792 0 0.0
RAM 60284 60284 0 0.0
thermostat tlsr9518adk80d FLASH 625856 625856 0 0.0
RAM 56980 56980 0 0.0
window-covering tlsr9118bdk40d FLASH 519116 519116 0 0.0
RAM 97696 97696 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1638592 1638592 0 0.0
RAM 48540 48540 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16235438 16235438 0 0.0
RAM 7138096 7138096 0 0.0

@mergify mergify bot merged commit 351d6eb into project-chip:master Jul 17, 2024
68 checks passed
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@cecille @restyled-commits @j-ororke
Choice conformance: Add choice conformance markers (project-chip#33854)
3ad1472 
* Choice conformance: Add conformance parsing

* Add to tests.yaml

* Restyled by autopep8

* Restyled by isort

* linter

* Update .github/workflows/tests.yaml

* wrap enum to contain choice, address review comments

* remove equality operator and check the member directly

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@CKnoerzer CKnoerzer CKnoerzer approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@axelnxp axelnxp Awaiting requested review from axelnxp

@chapongatien chapongatien Awaiting requested review from chapongatien

@doru91 doru91 Awaiting requested review from doru91

Assignees
No one assigned
Labels
github review - approved tests workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cecille @andy31415 @CKnoerzer @jmartinez-silabs @restyled-commits