-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted unit tests in src/tracing/tests from NL to PW. #33390
Merged
mergify
merged 9 commits into
project-chip:master
from
feasel0:feature/unittest--tracing-tests
May 10, 2024
Merged
Converted unit tests in src/tracing/tests from NL to PW. #33390
mergify
merged 9 commits into
project-chip:master
from
feasel0:feature/unittest--tracing-tests
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/unittest--tracing-tests
…but that has since been replaced by a full path.
…nto feature/unittest--tracing-tests
PR #33390: Size comparison from cd85f36 to f9446d1 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33390: Size comparison from 307cffb to 68307a4 Decreases (2 builds for efr32)
Full report (70 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
May 9, 2024
PR #33390: Size comparison from 4cea6a9 to 369b8ad Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the unit tests in
src/tracing/tests
to use PW.These tests use the multiplexed version of tracing, so there are enabling conditions in
src/BUILD.gn
andsrc/tracing/tests/BUILD.gn
which cause the tests to only run if tracing is enabled and multiplexed is the configuration. However these conditions were looking for the wrong string -- they were looking for just the word "multiplexed" whereas now we are using full paths in the config string, so this has been fixed.