-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chip-tool] Not register LIT at default #33262
[Chip-tool] Not register LIT at default #33262
Conversation
PR #33262: Size comparison from 5570be9 to ada3db4 Full report (3 builds for cc32xx, stm32)
|
PR #33262: Size comparison from e01eb4e to 8f2d91b Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with @mkardous-silabs's change made.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
PR #33262: Size comparison from e01eb4e to 44f74b4 Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33262: Size comparison from e01eb4e to 011fa5b Increases above 0.2%:
Increases (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
Decreases (4 builds for bl702l, efr32, linux, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33262: Size comparison from e01eb4e to 462464d Increases above 0.2%:
Increases (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, telink)
Decreases (4 builds for bl702l, efr32, linux, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
462464d
to
30ec1ab
Compare
PR #33262: Size comparison from 6090618 to 30ec1ab Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
30ec1ab
to
83635e8
Compare
83635e8
to
1f523b7
Compare
PR #33262: Size comparison from 5078a93 to 7ab1cf7 Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33262: Size comparison from 5078a93 to 7f40dae Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Per #31992, at default, chip-tool would register LIT unless skip-icd-registration is false.