-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test setup functions terminate on error #33002
Conversation
PR #33002: Size comparison from 7b7af2f to 253a2d2 Decreases (1 build for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
253a2d2
to
7165375
Compare
PR #33002: Size comparison from 7b7af2f to 32e458a Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nxp, psoc6, qpg, stm32)
|
32e458a
to
1a54916
Compare
PR #33002: Size comparison from 9a81bed to 1a54916 Decreases (1 build for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LoopackTransportManager changes are suspect: we should not convert a class to an odd singleton with all methods static.
1a54916
to
d479e9b
Compare
PR #33002: Size comparison from 9ff29ed to b01ba68 Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
8e41681
to
726d941
Compare
PR #33002: Size comparison from 2edcdea to 726d941 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
@Alami-Amine - FYI |
PR #33002: Size comparison from 062e063 to a513155 Decreases (2 builds for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
PR #33002: Size comparison from d19798c to e22bca8 Decreases (2 builds for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
I changed test setup and teardown functions to take no arguments and return void, because that's what pw_unit_test expects. If an error occurs in the initialization / deinitialization code, I call
VerifyOrDie
instead of returning an error value.Followup:
VerifyOrDie(...)
should be replaced byASSERT_SOMETHING(...)
once transition to pw_unit_test is completed.EDIT: Following suggestions by @andy31415, the scope was reduced - I will make the necessary methods static and rename some context classes in followup PRs.