-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for persisting paired device information on CHIP controller #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e5c41d
to
5b99ac9
Compare
andy31415
reviewed
Oct 16, 2020
andy31415
reviewed
Oct 16, 2020
bzbarsky-apple
requested changes
Oct 16, 2020
rwalker-apple
approved these changes
Oct 16, 2020
Size increase report for "esp32-example-build"
Full report output
|
bzbarsky-apple
approved these changes
Oct 16, 2020
mspang
reviewed
Oct 19, 2020
@saurabhst, @jelderton, @BroderickCarlin do you have any feedback? |
mspang
approved these changes
Oct 19, 2020
@saurabhst, @jelderton, @BroderickCarlin do you have any feedback? |
saurabhst
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP controller applications cannot persist paired device state across reboots.
Summary of Changes
CHIP Controller API did not provide a mechanism to save pairing state of a device/accessory.
This PR adds
This PR is one step towards fixing #2797