-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turned on PowerSource and PowerTopology clusters in EnergyManagementApp for SVE DUTs #32329
Turned on PowerSource and PowerTopology clusters in EnergyManagementApp for SVE DUTs #32329
Conversation
PR #32329: Size comparison from d899019 to a9799ee Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…n BasicInfo. Added Initialization of PowerSource attributes.
PR #32329: Size comparison from d899019 to 074ae84 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32329: Size comparison from d899019 to 98b2469 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32329: Size comparison from d899019 to a93e184 Increases above 0.2%:
Increases (21 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…anufacturer class. Called PowerSource->SetEndpointList()
PR #32329: Size comparison from d899019 to 5e0fb1b Increases (4 builds for nrfconnect, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #32329: Size comparison from d899019 to 13f9c59 Increases above 0.2%:
Increases (21 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Tagging @naveenkommareddi @raju-apple. Does this require a re-spin of the TH, is this approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking CR until CSG confirms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Letting this land in mainline, but per CSG, no plan to spin a new TH, so this won't make it to SVE.
…pp for SVE DUTs (project-chip#32329) * Turned on PowerSource on EP0 with WIRED mandated attributes, and PowerTopology on EP1 * Added code into EvseMain to initialise the PowerTopology cluster on EP1 * Changed ClusterRevision of PowerTopology to 2, enabled SerialNumber in BasicInfo. Added Initialization of PowerSource attributes. * Added missing PowerTopologyDelegate.h & .cpp * Added power-source and power-topology to ESP32 CMakeList.txt * Updated PowerTopology to include an Instance, and also added to EvseManufacturer class. Called PowerSource->SetEndpointList() * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…pp for SVE DUTs (project-chip#32329) * Turned on PowerSource on EP0 with WIRED mandated attributes, and PowerTopology on EP1 * Added code into EvseMain to initialise the PowerTopology cluster on EP1 * Changed ClusterRevision of PowerTopology to 2, enabled SerialNumber in BasicInfo. Added Initialization of PowerSource attributes. * Added missing PowerTopologyDelegate.h & .cpp * Added power-source and power-topology to ESP32 CMakeList.txt * Updated PowerTopology to include an Instance, and also added to EvseManufacturer class. Called PowerSource->SetEndpointList() * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…pp for SVE DUTs (project-chip#32329) * Turned on PowerSource on EP0 with WIRED mandated attributes, and PowerTopology on EP1 * Added code into EvseMain to initialise the PowerTopology cluster on EP1 * Changed ClusterRevision of PowerTopology to 2, enabled SerialNumber in BasicInfo. Added Initialization of PowerSource attributes. * Added missing PowerTopologyDelegate.h & .cpp * Added power-source and power-topology to ESP32 CMakeList.txt * Updated PowerTopology to include an Instance, and also added to EvseManufacturer class. Called PowerSource->SetEndpointList() * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
Modified Energy Management App to help EVSE DUT in SVE
Turned on PowerSource on EP0 with WIRED mandated attributes,
added ElectricalSensor device type to EP1
Turned on PowerTopology on EP1 with NODE as the feature (no additional attributes)
added Example initialisation values to PowerSource
added Software Version / Serial Number into basic information