-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for encoding Field IDs with an MC source #32276
Support for encoding Field IDs with an MC source #32276
Conversation
Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
PR #32276: Size comparison from f2bdd1f to 04d5071 Increases above 0.2%:
Increases (10 builds for bl702, efr32, k32w, linux, telink)
Decreases (22 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, nrfconnect)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32276: Size comparison from f2bdd1f to 96823c5 Increases above 0.2%:
Increases (12 builds for bl702, efr32, k32w, linux, telink)
Decreases (21 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, nrfconnect)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32276: Size comparison from f2bdd1f to 1439730 Increases above 0.2%:
Increases (19 builds for bl702, efr32, k32w, linux, telink)
Decreases (23 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32276: Size comparison from f2bdd1f to 347d203 Increases above 0.2%:
Increases (19 builds for bl702, efr32, k32w, linux, telink)
Decreases (23 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32276: Size comparison from c49e784 to 05b6254 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
PR #32276: Size comparison from c49e784 to a3c11bb Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #32276: Size comparison from c49e784 to 7cdc2cc Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@yufengwangca could you update src/lib/support/jsontlv/README.md |
* Support for encoding Field IDs with an MC source * Update src/lib/support/jsontlv/JsonToTlv.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Address review comments * Fix linter * Fix linter * restyle --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Currently, we always use ImplicitProfile tag to encode field ID larger than UINT8_MAX, this is not aligned with the spec.
When the MEI prefix encodes a standard/scoped source, the tag is encoded using ContextSpecific tag if tag_id is less than or equal to UINT8_MAX, and ImplicitProfile tag if tag_id is larger than UINT8_MAX.
When the MEI prefix encodes a manufacturer code, the tag is encoded using FullyQualified_6Bytes tag, the Vendor ID SHALL be set to the manufacturer code, the profile number set to 0 and the tag number set to the MEI suffix.