Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment about what should be done for batch commands on timeout #32261

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove comment about what should be done for batch commands on timeout #32261

merged 1 commit into from
Feb 23, 2024

Conversation

tehampson
Copy link
Contributor

When a timeout occurs the expected behaviour is :

  • Call non-path specific error callback (OnErrorCallback) with CHIP_ERROR_TIMEOUT`, which is already happening here
  • No further callbacks to OnResponse, or OnNoResponse occur. This is already what we are doing today since we call Close() right after providing the non-path specific error. As seen here

@github-actions github-actions bot added the app label Feb 22, 2024
@tehampson tehampson mentioned this pull request Feb 22, 2024
Open
53 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

PR #32261: Size comparison from 8fbe0a7 to 3008782

Decreases (2 builds for efr32)
platform target config section 8fbe0a7 3008782 change % change
efr32 lighting-app BRD4187C (read/write) 1108352 1108344 -8 -0.0
.text 909772 909764 -8 -0.0
window-app BRD4187C (read/write) 1154744 1154736 -8 -0.0
.text 984012 984004 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 8fbe0a7 3008782 change % change
bl602 lighting-app bl602 (read/write) 1433818 1433818 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 157532 157532 0 0.0
.text 1100814 1100814 0 0.0
bl602+mfd (read/write) 1448218 1448218 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 156492 156492 0 0.0
.text 1116128 1116128 0 0.0
bl602+rpc (read/write) 1481442 1481442 0 0.0
.bss 93360 93360 0 0.0
.data 9872 9872 0 0.0
.rodata 165100 165100 0 0.0
.text 1132452 1132452 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1198803 1198803 0 0.0
.bss 11121 11121 0 0.0
.data 3680 3680 0 0.0
.rodata 106872 106872 0 0.0
.text 970262 970262 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1209599 1209599 0 0.0
.bss 11297 11297 0 0.0
.data 3656 3656 0 0.0
.rodata 105812 105812 0 0.0
.text 982016 982016 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1290271 1290271 0 0.0
.bss 19589 19589 0 0.0
.data 4224 4224 0 0.0
.rodata 122244 122244 0 0.0
.text 1044950 1044950 0 0.0
bl706-eth (read/write) 1016161 1016161 0 0.0
.bss 23680 23680 0 0.0
.data 3248 3248 0 0.0
.rodata 100216 100216 0 0.0
.text 761062 761062 0 0.0
bl706-wifi (read/write) 1250306 1250306 0 0.0
.bss 10565 10565 0 0.0
.data 3688 3688 0 0.0
.rodata 121216 121216 0 0.0
.text 992430 992430 0 0.0
bl702l lighting-app bl702l (read/write) 1168632 1168632 0 0.0
.bss 16316 16316 0 0.0
.data 5040 5040 0 0.0
.rodata 100876 100876 0 0.0
.text 963104 963104 0 0.0
bl702l+mfd (read/write) 1180040 1180040 0 0.0
.bss 16492 16492 0 0.0
.data 5024 5024 0 0.0
.rodata 99816 99816 0 0.0
.text 975426 975426 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 772636 772636 0 0.0
(read/write) 168600 168600 0 0.0
.bss 90604 90604 0 0.0
.data 3560 3560 0 0.0
.rodata 81652 81652 0 0.0
.text 690720 690720 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 789244 789244 0 0.0
(read/write) 178848 178848 0 0.0
.bss 100852 100852 0 0.0
.data 3560 3560 0 0.0
.rodata 75940 75940 0 0.0
.text 713040 713040 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 777908 777908 0 0.0
(read/write) 173288 173288 0 0.0
.bss 95292 95292 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 674944 674944 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 730076 730076 0 0.0
(read/write) 167568 167568 0 0.0
.bss 89336 89336 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 652440 652440 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 715700 715700 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89560 89560 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 642224 642224 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582010 582010 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86522 86522 0 0.0
.text 493368 493368 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627362 627362 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106978 106978 0 0.0
.text 518264 518264 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 567843 567843 0 0.0
.app_xip_area 457629 457629 0 0.0
.bss 65048 65048 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 550651 550651 0 0.0
.app_xip_area 435677 435677 0 0.0
.bss 69800 69800 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569443 569443 0 0.0
.app_xip_area 460733 460733 0 0.0
.bss 63584 63584 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564051 564051 0 0.0
.app_xip_area 452061 452061 0 0.0
.bss 66784 66784 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930736 930736 0 0.0
.bss 197912 197912 0 0.0
.data 1388 1388 0 0.0
.text 731412 731412 0 0.0
BRD4187C (read/write) 1108352 1108344 -8 -0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 909772 909764 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1121492 1121492 0 0.0
.bss 186764 186764 0 0.0
.data 2792 2792 0 0.0
.text 931916 931916 0 0.0
window-app BRD4187C (read/write) 1154744 1154736 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 984012 984004 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1210272 1210272 0 0.0
(read/write) 1748656 1748656 0 0.0
.dram0.bss 74296 74296 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 251200 251200 0 0.0
.flash.text 1210272 1210272 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1252403 1252403 0 0.0
(read/write) 534140 534140 0 0.0
.dram0.bss 81208 81208 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 281848 281848 0 0.0
.flash.text 1246239 1246239 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 611968 611968 0 0.0
(read/write) 80036 80036 0 0.0
.bss 67828 67828 0 0.0
.data 2224 2224 0 0.0
.text 611432 611432 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747092 747092 0 0.0
.bss 79188 79188 0 0.0
.data 2816 2816 0 0.0
.text 625720 625720 0 0.0
light k32w0+release (read only) 603560 603560 0 0.0
(read/write) 79492 79492 0 0.0
.bss 67308 67308 0 0.0
.data 2200 2200 0 0.0
.text 603024 603024 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 789216 789216 0 0.0
.bss 80580 80580 0 0.0
.data 2032 2032 0 0.0
.text 667248 667248 0 0.0
lock k32w0+release (read only) 582216 582216 0 0.0
(read/write) 77480 77480 0 0.0
.bss 65348 65348 0 0.0
.data 2148 2148 0 0.0
.text 581680 581680 0 0.0
linux air-purifier-app debug (read only) 2605981 2605981 0 0.0
(read/write) 128680 128680 0 0.0
.bss 46320 46320 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 184240 184240 0 0.0
.text 2244453 2244453 0 0.0
all-clusters-app debug (read only) 5900081 5900081 0 0.0
(read/write) 480088 480088 0 0.0
.bss 134656 134656 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 333560 333560 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1392 1392 0 0.0
.rodata 348464 348464 0 0.0
.text 5118467 5118467 0 0.0
all-clusters-minimal-app debug (read only) 5180849 5180849 0 0.0
(read/write) 236040 236040 0 0.0
.bss 127456 127456 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 97160 97160 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 287458 287458 0 0.0
.text 4658851 4658851 0 0.0
bridge-app debug (read only) 4577601 4577601 0 0.0
(read/write) 216944 216944 0 0.0
.bss 117984 117984 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86080 86080 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228066 228066 0 0.0
.text 4129443 4129443 0 0.0
chip-tool debug (read only) 11991777 11991777 0 0.0
(read/write) 521232 521232 0 0.0
.bss 94264 94264 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 414656 414656 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 447289 447289 0 0.0
.text 10838915 10838915 0 0.0
chip-tool-ipv6only arm64 (read only) 11488384 11488384 0 0.0
(read/write) 588512 588512 0 0.0
.bss 103352 103352 0 0.0
.data 4488 4488 0 0.0
.data.rel.ro 454416 454416 0 0.0
.dynamic 512 512 0 0.0
.got 20344 20344 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 352988 352988 0 0.0
.text 10247580 10247580 0 0.0
lighting-app debug+rpc+ui (read only) 5500009 5500009 0 0.0
(read/write) 225712 225712 0 0.0
.bss 118920 118920 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94480 94480 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 352916 352916 0 0.0
.text 4900899 4900899 0 0.0
lock-app debug (read only) 4645505 4645505 0 0.0
(read/write) 204600 204600 0 0.0
.bss 113440 113440 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80328 80328 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254114 254114 0 0.0
.text 4179907 4179907 0 0.0
ota-provider-app debug (read only) 4278297 4278297 0 0.0
(read/write) 193160 193160 0 0.0
.bss 113216 113216 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69712 69712 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 206754 206754 0 0.0
.text 3878787 3878787 0 0.0
ota-requestor-app debug (read only) 4404465 4404465 0 0.0
(read/write) 197568 197568 0 0.0
.bss 114112 114112 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72832 72832 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 212930 212930 0 0.0
.text 3994211 3994211 0 0.0
shell debug (read only) 2880113 2880113 0 0.0
(read/write) 156104 156104 0 0.0
.bss 62544 62544 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86384 86384 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 185024 185024 0 0.0
.text 2521922 2521922 0 0.0
thermostat-no-ble arm64 (read only) 4463840 4463840 0 0.0
(read/write) 248216 248216 0 0.0
.bss 121768 121768 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103544 103544 0 0.0
.dynamic 512 512 0 0.0
.got 12080 12080 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158660 158660 0 0.0
.text 3960748 3960748 0 0.0
tv-app debug (read only) 5654777 5654777 0 0.0
(read/write) 351344 351344 0 0.0
.bss 243248 243248 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94312 94312 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 287202 287202 0 0.0
.text 5125811 5125811 0 0.0
tv-casting-app debug (read only) 9842617 9842617 0 0.0
(read/write) 339944 339944 0 0.0
.bss 155984 155984 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174136 174136 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 381776 381776 0 0.0
.text 8995299 8995299 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531464 2531464 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1494148 1494148 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1101264 1101264 0 0.0
bss 130831 130831 0 0.0
rodata 112024 112024 0 0.0
text 810568 810568 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1221304 1221304 0 0.0
bss 122921 122921 0 0.0
rodata 141768 141768 0 0.0
text 806092 806092 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1049284 1049284 0 0.0
bss 129689 129689 0 0.0
rodata 99396 99396 0 0.0
text 772368 772368 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834464 834464 0 0.0
(read/write) 1795228 1795228 0 0.0
.bss 196212 196212 0 0.0
.data 2664 2664 0 0.0
.text 1587964 1587964 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1717316 1717316 0 0.0
.bss 193092 193092 0 0.0
.data 2632 2632 0 0.0
.text 1513204 1513204 0 0.0
light cy8ckit_062s2_43012 (read only) 844344 844344 0 0.0
(read/write) 1636436 1636436 0 0.0
.bss 186556 186556 0 0.0
.data 2440 2440 0 0.0
.text 1439052 1439052 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1666348 1666348 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1441804 1441804 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1127704 1127704 0 0.0
.bss 102456 102456 0 0.0
.data 820 820 0 0.0
.text 640088 640088 0 0.0
lock-app qpg6105+debug (read/write) 1087688 1087688 0 0.0
.bss 97200 97200 0 0.0
.data 840 840 0 0.0
.text 600068 600068 0 0.0
stm32 light STM32WB5MM-DK (read/write) 599157 599157 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 78772 78772 0 0.0
.text 381672 381672 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821970 821970 0 0.0
bss 49660 49660 0 0.0
text 615770 615770 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1090772 1090772 0 0.0
bss 101780 101780 0 0.0
text 792876 792876 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1048268 1048268 0 0.0
bss 110084 110084 0 0.0
text 764224 764224 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 909020 909020 0 0.0
bss 93116 93116 0 0.0
text 651692 651692 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823642 823642 0 0.0
bss 49708 49708 0 0.0
text 617508 617508 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 929368 929368 0 0.0
bss 77708 77708 0 0.0
text 697666 697666 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1071644 1071644 0 0.0
bss 100196 100196 0 0.0
text 776558 776558 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 901720 901720 0 0.0
bss 69172 69172 0 0.0
text 652888 652888 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 927508 927508 0 0.0
bss 92696 92696 0 0.0
text 670212 670212 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 826202 826202 0 0.0
bss 49816 49816 0 0.0
text 620464 620464 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 789916 789916 0 0.0
bss 56016 56016 0 0.0
text 591214 591214 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676816 676816 0 0.0
bss 73672 73672 0 0.0
text 462298 462298 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 830686 830686 0 0.0
bss 51340 51340 0 0.0
text 623578 623578 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 849221 849221 0 0.0
bss 59492 59492 0 0.0
text 635270 635270 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 815576 815576 0 0.0
bss 56304 56304 0 0.0
text 610922 610922 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 833680 833680 0 0.0
bss 68080 68080 0 0.0
text 626178 626178 0 0.0

@mergify mergify bot merged commit 524b8a8 into project-chip:master Feb 23, 2024
58 checks passed
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@tehampson @huangxuyong
comment removed (project-chip#32261)
09522c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tehampson @bzbarsky-apple @jmartinez-silabs