-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Fix BLE infinite advertising #32211
Merged
woody-apple
merged 1 commit into
1.3-sve
from
cherry-pick-1.3-sve-f5b7a1d54497e9f9838d1b9b590b20334260aa12
Feb 19, 2024
Merged
[Linux] Fix BLE infinite advertising #32211
woody-apple
merged 1 commit into
1.3-sve
from
cherry-pick-1.3-sve-f5b7a1d54497e9f9838d1b9b590b20334260aa12
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Linux] Fix BLE infinite advertising According to BlueZ documentation, discoverable timeout of 0 should disable the timeout. However, due to a bug, setting timeout to 0 stops advertising immediately after sending ADV frame. * Add comments for commented-out properties * Add comments to D-Bus interfaces which are owned by us * Update the comment so it will be easier to understand the meaning
PR #32211: Size comparison from c4688b8 to b3324e8 Decreases (13 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
According to BlueZ documentation, discoverable timeout of 0 should disable the timeout. However, due to a bug on RPi, setting timeout to 0 stops advertising immediately after sending ADV frame. Also, we can not set this property to a big value, because it is
uint16
which can count only 65535 seconds which is ~18.2 hours (not enough for 48 h extended advertising).Regression introduced in bd6c4ab
Fixes #32033
Changes
DiscoverableTimeout
property, so BlueZ will set it internally to 0Testing
Tested connection between
linux-x64-chip-tool
andlinux-arm64-all-clusters-clang
.