[Linux] Lock CHIP stack before calling WiFi diagnostic delegate #32137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
andy31415
approved these changes
Feb 15, 2024
|
PR #32137: Size comparison from 274719d to dca9fcc Increases above 0.2%:
Increases (14 builds for linux)
Decreases (14 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Feb 15, 2024
cjandhyala
approved these changes
Feb 19, 2024
|
This PR is needed to fix the BLE pairing issue that affects a lot of tests. |
raju-apple
approved these changes
Feb 19, 2024
woody-apple
approved these changes
Feb 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Get rid of static functions by wrapping glib callbacks with lambda * Get rid of the rest of static functions * Keep sWiFiIfName as an instance member * Lock CHIP stack before calling WiFi diagnostic delegate * Do not use sInstance internally in ConnectivityManagerImpl * Fix signatures for properties-changed and scan-done callbacks * Keep all members of ConnectivityManagerImpl as instance members * Fix freeing char objects allocated by glib * Restyled by clang-format * Fix compilation warnings --------- Co-authored-by: Restyled.io <commits@restyled.io>
bhmanda-silabs
pushed a commit
to bhmanda-silabs/connectedhomeip
that referenced
this pull request
Feb 22, 2024
…ect-chip#32137) * Get rid of static functions by wrapping glib callbacks with lambda * Get rid of the rest of static functions * Keep sWiFiIfName as an instance member * Lock CHIP stack before calling WiFi diagnostic delegate * Do not use sInstance internally in ConnectivityManagerImpl * Fix signatures for properties-changed and scan-done callbacks * Keep all members of ConnectivityManagerImpl as instance members * Fix freeing char objects allocated by glib * Restyled by clang-format * Fix compilation warnings --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported here: #32033 (comment)
Problem
All glib callback runs on glib thread. In order to call function which changes internal CHIP state, we need to lock CHIP stack lock beforehand. Due to changes in 86977c2, WiFi connection on Linux causes abort.
Changes
ConnectivityManagerImplto instance membersTesting
Locally tested WiFi connection/disconnection during BLE commissioning.