-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC-SC-4.3] Discovery [DUT as Commissionee] #31982
[TC-SC-4.3] Discovery [DUT as Commissionee] #31982
Conversation
PR #31982: Size comparison from 86977c2 to e0df481 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31982: Size comparison from 86977c2 to dfd560e Increases (1 build for k32w)
Decreases (3 builds for efr32, k32w)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31982: Size comparison from 1a6bd3b to d9a66d7 Full report (4 builds for cc32xx, mbed, stm32)
|
PR #31982: Size comparison from 1a6bd3b to b08c906 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31982: Size comparison from 18bf8c0 to ba72381 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31982: Size comparison from 18bf8c0 to 5d6912f Increases (2 builds for esp32)
Decreases (3 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31982: Size comparison from 3d80093 to 30efb6c Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #31982: Size comparison from ebfd212 to 57dee9f Full report (5 builds for cc32xx, stm32, tizen)
|
PR #31982: Size comparison from 59d7388 to 41ffddc Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
PR #31982: Size comparison from 59d7388 to 78a768a Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #31982: Size comparison from 73ff58f to ef874d0 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm good with this one the last two comments are addressed.
…onnectedhomeip into TC-SC-4.3-python-test
PR #31982: Size comparison from 334b1d9 to 719c152 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #31982: Size comparison from 093aff8 to 94adc9c Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Adds TC_SC_4_3.py * Fixes TXT record not available when making direct query with name and type * Fixes restyle, adds comments to operational service logic * Fix restlye for mdns class * Adds get_service_types to mdns class * Fix restyle * Steps progress * Fix restyle * Fix restyle * Adds test to tests.yaml * Fix lint * Fix lit-icd-app path in tests.yaml * Fix SII key logic * Addresses latest review comments * Fix lint * Replaces 1 sec fixed sleep in operational service logic with service listener event wait time * Merge from master * MDNS class update progress * Adds MdnsAsyncServiceInfo class * Adds get_service_by_record_type to mdns class * TC progress * Fix restyle * Fix restyle * Fix lint * Fix restyle * tests.yaml from master * tests.yaml from master * Updates steps output and test runner configs * Adds tc to tests.yaml * Update * Updates to make a fresh question each time * Update progress * Fix restyle * Fix Lint * Fix restyle * Fix lint * Adds CI task tags * Completes step 11 * Fix restyled * Steps 8,11 * Fix restyled * Adds timeout to get_service_types * Updates get_service_types description * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Adds clarifying comment * Adds MCORE.COM PICS checks * Updates contains_ipv6_address * Removes listener dealy * Fix restyled * Fix restyled * Fix lint * Updates ipv6 check * Fixes ipv6 checks * Restore ms delay * continue * Step 9 - Updates hostname character length check, other adjustments * removes temp test file * Restyled by autopep8 * Removes test case YAML and manualTests.json reference * Fix restyle * Updates CI python test arguments * Fix typo * matter_testing import update * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Addresses latest * Fix restyle * Testing zeroconf class imports * service info refactor * Fix restyle * Fix restyle * Updates mdns service info init * Fix restyle * Updates MdnsAsyncServiceInfo --------- Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
…orts TCP) (#37429) * [TC-SC-4.3] Discovery [DUT as Commissionee] (#31982) * Adds TC_SC_4_3.py * Fixes TXT record not available when making direct query with name and type * Fixes restyle, adds comments to operational service logic * Fix restlye for mdns class * Adds get_service_types to mdns class * Fix restyle * Steps progress * Fix restyle * Fix restyle * Adds test to tests.yaml * Fix lint * Fix lit-icd-app path in tests.yaml * Fix SII key logic * Addresses latest review comments * Fix lint * Replaces 1 sec fixed sleep in operational service logic with service listener event wait time * Merge from master * MDNS class update progress * Adds MdnsAsyncServiceInfo class * Adds get_service_by_record_type to mdns class * TC progress * Fix restyle * Fix restyle * Fix lint * Fix restyle * tests.yaml from master * tests.yaml from master * Updates steps output and test runner configs * Adds tc to tests.yaml * Update * Updates to make a fresh question each time * Update progress * Fix restyle * Fix Lint * Fix restyle * Fix lint * Adds CI task tags * Completes step 11 * Fix restyled * Steps 8,11 * Fix restyled * Adds timeout to get_service_types * Updates get_service_types description * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Adds clarifying comment * Adds MCORE.COM PICS checks * Updates contains_ipv6_address * Removes listener dealy * Fix restyled * Fix restyled * Fix lint * Updates ipv6 check * Fixes ipv6 checks * Restore ms delay * continue * Step 9 - Updates hostname character length check, other adjustments * removes temp test file * Restyled by autopep8 * Removes test case YAML and manualTests.json reference * Fix restyle * Updates CI python test arguments * Fix typo * matter_testing import update * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Addresses latest * Fix restyle * Testing zeroconf class imports * service info refactor * Fix restyle * Fix restyle * Updates mdns service info init * Fix restyle * Updates MdnsAsyncServiceInfo --------- Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Restyled.io <commits@restyled.io> * TC-SC-4.3: Clear cache before sending request (#37362) * Fix imports (changed post 1.4, before this test was written) * Move back to old style CI arguments --------- Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
TC-SC-4.3 TEST CASE DETAILS
Category
Functional conformance
Purpose
The purpose of this test case is to verify that a Matter node is discoverable and can advertise its services in a Matter network.
Test Plan
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/securechannel.adoc#343-tc-sc-43-discovery-dut_commissionee
MdnsDiscovery class
Description
This pull request includes the MdnsDiscovery class, a solution for discovering mDNS (Multicast DNS) services in a network environment. The class is designed to leverage the Zeroconf library, enabling the detection and querying of various service types as defined by the MDNS types and subtypes used in Matter.
Methods
get_commissioner_service
get_commissionable_service
get_operational_service
get_border_router_service
get_all_services
get_service_types
get_service_by_record_type
All accept 2 optional parameters:
log_output (bool)
: Logs the discovered services to the console, defaults to False.discovery_timeout_sec (float)
: The duration in seconds to wait for the discovery process, defaults to 15 seconds.Example usage for Operational Service
Example usage for Get Service By Record Type
RECORD QUERIES/ANSWERS
To verify the correct functioning of the MdnsDiscovery class, I captured the questions/answers with Wireshark in an excel sheet (relevant entries are color coded for easier identification).
For this test case, queries for SRV, TXT, AAAA, and PTR records were performed. This is just informational as it's the first test case using this class.
Link to the logs:
Wireshark Logs