-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some APIs for defining local endpoints to Matter.framework. #31673
Merged
mergify
merged 5 commits into
project-chip:master
from
bzbarsky-apple:darwin-framework-server-objects
Jan 31, 2024
Merged
Add some APIs for defining local endpoints to Matter.framework. #31673
mergify
merged 5 commits into
project-chip:master
from
bzbarsky-apple:darwin-framework-server-objects
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31673: Size comparison from 490286b to ed4adfd Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/darwin/Framework/CHIP/EndpointDescription/MTRAccessGrant.mm
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAccessGrant.mm
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAccessGrant.mm
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAccessGrant.mm
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAttributeDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTREndpointDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTREndpointDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTREndpointDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRServerClusterDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRServerClusterDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAttributeDescription.h
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/EndpointDescription/MTRAttributeDescription.mm
Outdated
Show resolved
Hide resolved
These are not hooked up to anything yet, in the sense that you can create an MTREndpointDescription but then can't do anything with it. APIs on MTRDeviceController that take an MTREndpointDescription and hook up the endpoint to actually be exposed will come later.
ed4adfd
to
78b2f15
Compare
PR #31673: Size comparison from 7456670 to 78b2f15 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jaredgrubb
reviewed
Jan 26, 2024
PR #31673: Size comparison from 7456670 to 1234033 Increases (3 builds for esp32, linux)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/darwin/Framework/CHIP/ServerEndpoint/MTRServerEndpoint_Internal.h
Outdated
Show resolved
Hide resolved
1234033
to
5b60d08
Compare
PR #31673: Size comparison from 48e7bae to 5b60d08 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
ksperling-apple
approved these changes
Jan 30, 2024
Fast-tracking platform-specific fix with platform owner review. |
PR #31673: Size comparison from 48e7bae to 06febe9 Increases above 0.2%:
Increases (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (53 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not hooked up to anything yet, in the sense that you can create an MTREndpointDescription but then can't do anything with it. APIs on MTRDeviceController that take an MTREndpointDescription and hook up the endpoint to actually be exposed will come later.