Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tv-casting-app: simplified Android discovery API #31112

Merged
merged 4 commits into from
Dec 29, 2023
Merged

tv-casting-app: simplified Android discovery API #31112

merged 4 commits into from
Dec 29, 2023

Conversation

pgregorr-amazon
Copy link
Contributor

This change implements and demonstrates the use of a simplified Casting Player discovery API on Android. This simplified API delegates the work to the common discovery implantation in Native.

Change summary

  1. CastingPlayerDiscovery.java and its inner class CastingPlayerChangeListener are now responsible for controlling discovery and passing the callbacks to the Native layer. The CastingPlayerChangeListener interface provides the onAdded(), onChanged() and onRemoved() callbacks, which are called from the Native layer. These callbacks provide the Casting Players to be consumed by the UX/CX.
  2. Implemented the corresponding JNI functions defined in CastingPlayerDiscovery.java. These delegate to the common implementation.
  3. Provided an example of how to use the simplified discovery API in DiscoveryExampleFragment.java

Testing
Verified and tested locally with the Android tv-casting-app example app. The example app is able to discover and display the Casting Players on screen.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

PR #31112: Size comparison from b38d140 to 18ffa4c

Decreases (1 build for efr32)
platform target config section b38d140 18ffa4c change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114848 1114840 -8 -0.0
.text 923300 923292 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b38d140 18ffa4c change % change
bl602 lighting-app bl602 (read/write) 1417794 1417794 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156912 156912 0 0.0
.text 1085664 1085664 0 0.0
bl602+mfd (read/write) 1432522 1432522 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155872 155872 0 0.0
.text 1101288 1101288 0 0.0
bl602+rpc (read/write) 1465578 1465578 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164536 164536 0 0.0
.text 1117408 1117408 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182811 1182811 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106288 106288 0 0.0
.text 955366 955366 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1193943 1193943 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105228 105228 0 0.0
.text 967430 967430 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274823 1274823 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121708 121708 0 0.0
.text 1030428 1030428 0 0.0
bl706-eth (read/write) 1002437 1002437 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99620 99620 0 0.0
.text 748262 748262 0 0.0
bl706-wifi (read/write) 1240574 1240574 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120600 120600 0 0.0
.text 975558 975558 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152516 1152516 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100292 100292 0 0.0
.text 948492 948492 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1163968 1163968 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99232 99232 0 0.0
.text 960868 960868 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771712 771712 0 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89536 89536 0 0.0
.text 681908 681908 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787816 787816 0 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83792 83792 0 0.0
.text 703760 703760 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776032 776032 0 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110392 110392 0 0.0
.text 665376 665376 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728648 728648 0 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85112 85112 0 0.0
.text 643268 643268 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714184 714184 0 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80944 80944 0 0.0
.text 632972 632972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566994 566994 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83938 83938 0 0.0
.text 480932 480932 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620322 620322 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105810 105810 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561023 561023 0 0.0
.app_xip_area 451273 451273 0 0.0
.bss 64664 64664 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543247 543247 0 0.0
.app_xip_area 428761 428761 0 0.0
.bss 69360 69360 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561983 561983 0 0.0
.app_xip_area 453689 453689 0 0.0
.bss 63280 63280 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557423 557423 0 0.0
.app_xip_area 445905 445905 0 0.0
.bss 66400 66400 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017020 1017020 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841712 841712 0 0.0
BRD4187C (read/write) 1100980 1100980 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901460 901460 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114848 1114840 -8 -0.0
.bss 188816 188816 0 0.0
.data 2712 2712 0 0.0
.text 923300 923292 -8 -0.0
window-app BRD4187C (read/write) 1135744 1135744 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964320 964320 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137758 1137758 0 0.0
(read/write) 1671524 1671524 0 0.0
.dram0.bss 72872 72872 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241792 241792 0 0.0
.flash.text 1137758 1137758 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182755 1182755 0 0.0
(read/write) 520716 520716 0 0.0
.dram0.bss 79520 79520 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272828 272828 0 0.0
.flash.text 1177371 1177371 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605208 605208 0 0.0
(read/write) 81896 81896 0 0.0
.bss 69744 69744 0 0.0
.data 2168 2168 0 0.0
.text 604672 604672 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690680 690680 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576888 576888 0 0.0
light k32w0+release (read only) 594912 594912 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594376 594376 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782484 782484 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659824 659824 0 0.0
lock k32w0+release (read only) 576312 576312 0 0.0
(read/write) 79376 79376 0 0.0
.bss 67296 67296 0 0.0
.data 2096 2096 0 0.0
.text 575776 575776 0 0.0
linux air-purifier-app debug (read only) 2525829 2525829 0 0.0
(read/write) 127208 127208 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72824 72824 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2171285 2171285 0 0.0
all-clusters-app debug (read only) 5413889 5413889 0 0.0
(read/write) 455432 455432 0 0.0
.bss 131632 131632 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 312712 312712 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1264 1264 0 0.0
.rodata 312252 312252 0 0.0
.text 4691731 4691731 0 0.0
all-clusters-minimal-app debug (read only) 4952889 4952889 0 0.0
(read/write) 234688 234688 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95960 95960 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272749 272749 0 0.0
.text 4447779 4447779 0 0.0
bridge-app debug (read only) 4416625 4416625 0 0.0
(read/write) 215928 215928 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85280 85280 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219061 219061 0 0.0
.text 3979091 3979091 0 0.0
chip-tool debug (read only) 11682033 11682033 0 0.0
(read/write) 504208 504208 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 397776 397776 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 425193 425193 0 0.0
.text 10567123 10567123 0 0.0
chip-tool-ipv6only arm64 (read only) 11407440 11407440 0 0.0
(read/write) 571024 571024 0 0.0
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436648 436648 0 0.0
.dynamic 512 512 0 0.0
.got 19808 19808 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 345608 345608 0 0.0
.text 10194040 10194040 0 0.0
lighting-app debug+rpc+ui (read only) 5302441 5302441 0 0.0
(read/write) 225000 225000 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340276 340276 0 0.0
.text 4717475 4717475 0 0.0
lock-app debug (read only) 4501649 4501649 0 0.0
(read/write) 203648 203648 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246901 246901 0 0.0
.text 4044819 4044819 0 0.0
ota-provider-app debug (read only) 4165817 4165817 0 0.0
(read/write) 192728 192728 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69296 69296 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201205 201205 0 0.0
.text 3772835 3772835 0 0.0
ota-requestor-app debug (read only) 4255305 4255305 0 0.0
(read/write) 197008 197008 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205045 205045 0 0.0
.text 3854083 3854083 0 0.0
shell debug (read only) 2788217 2788217 0 0.0
(read/write) 152272 152272 0 0.0
.bss 62312 62312 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83400 83400 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 181824 181824 0 0.0
.text 2435474 2435474 0 0.0
thermostat-no-ble arm64 (read only) 4405248 4405248 0 0.0
(read/write) 245216 245216 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102352 102352 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162236 162236 0 0.0
.text 3902712 3902712 0 0.0
tv-app debug (read only) 5385993 5385993 0 0.0
(read/write) 349120 349120 0 0.0
.bss 244544 244544 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92280 92280 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272885 272885 0 0.0
.text 4875267 4875267 0 0.0
tv-casting-app debug (read only) 9560897 9560897 0 0.0
(read/write) 338176 338176 0 0.0
.bss 156352 156352 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 172504 172504 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 363144 363144 0 0.0
.text 8734355 8734355 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525992 2525992 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488676 1488676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1067700 1067700 0 0.0
bss 129393 129393 0 0.0
rodata 105396 105396 0 0.0
text 785344 785344 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1193808 1193808 0 0.0
bss 121603 121603 0 0.0
rodata 139156 139156 0 0.0
text 782712 782712 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1040168 1040168 0 0.0
bss 129348 129348 0 0.0
rodata 98872 98872 0 0.0
text 764324 764324 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835864 835864 0 0.0
(read/write) 1750980 1750980 0 0.0
.bss 195004 195004 0 0.0
.data 2472 2472 0 0.0
.text 1545116 1545116 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705940 1705940 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502124 1502124 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630924 1630924 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433796 1433796 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657812 1657812 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433564 1433564 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116596 1116596 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 628972 628972 0 0.0
lock-app qpg6105+debug (read/write) 1080588 1080588 0 0.0
.bss 97512 97512 0 0.0
.data 784 784 0 0.0
.text 592968 592968 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821378 821378 0 0.0
bss 55064 55064 0 0.0
text 613736 613736 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086600 1086600 0 0.0
bss 100404 100404 0 0.0
text 767126 767126 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1084036 1084036 0 0.0
bss 109764 109764 0 0.0
text 753368 753368 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934668 934668 0 0.0
bss 94272 94272 0 0.0
text 646786 646786 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821614 821614 0 0.0
bss 55108 55108 0 0.0
text 614106 614106 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978700 978700 0 0.0
bss 79092 79092 0 0.0
text 694196 694196 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1093016 1093016 0 0.0
bss 99836 99836 0 0.0
text 769678 769678 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 965332 965332 0 0.0
bss 97356 97356 0 0.0
text 647872 647872 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948344 948344 0 0.0
bss 92380 92380 0 0.0
text 662894 662894 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 880412 880412 0 0.0
bss 69084 69084 0 0.0
text 622116 622116 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 821024 821024 0 0.0
bss 57320 57320 0 0.0
text 588992 588992 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705600 705600 0 0.0
bss 73588 73588 0 0.0
text 462094 462094 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823350 823350 0 0.0
bss 55244 55244 0 0.0
text 616850 616850 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878117 878117 0 0.0
bss 60796 60796 0 0.0
text 630732 630732 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845396 845396 0 0.0
bss 57616 57616 0 0.0
text 607458 607458 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839672 839672 0 0.0
bss 57968 57968 0 0.0
text 601492 601492 0 0.0

sharadb-amazon
sharadb-amazon requested changes Dec 19, 2023
View reviewed changes
...casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayerDiscovery.java Outdated Show resolved Hide resolved
...casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayerDiscovery.java Show resolved Hide resolved
...casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayerDiscovery.java Outdated Show resolved Hide resolved
...tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java Outdated Show resolved Hide resolved
...tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
examples/tv-casting-app/android/App/app/src/main/AndroidManifest.xml Show resolved Hide resolved
sharadb-amazon
sharadb-amazon reviewed Dec 27, 2023
View reviewed changes
examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayer.java Outdated Show resolved Hide resolved
...casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayerDiscovery.java Outdated Show resolved Hide resolved
...casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayerDiscovery.java Outdated Show resolved Hide resolved
...tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java Outdated Show resolved Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayer.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Outdated Show resolved Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2023 •
edited
Loading

PR #31112: Size comparison from 4855f58 to 9583781

Decreases (1 build for efr32)
platform target config section 4855f58 9583781 change % change
efr32 window-app BRD4187C (read/write) 1136272 1136264 -8 -0.0
.text 964784 964776 -8 -0.0
Full report (62 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4855f58 9583781 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 772000 772000 0 0.0
(read/write) 168164 168164 0 0.0
.bss 90500 90500 0 0.0
.data 3460 3460 0 0.0
.rodata 89560 89560 0 0.0
.text 682176 682176 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 788096 788096 0 0.0
(read/write) 178392 178392 0 0.0
.bss 100676 100676 0 0.0
.data 3488 3488 0 0.0
.rodata 83808 83808 0 0.0
.text 704020 704020 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776344 776344 0 0.0
(read/write) 172848 172848 0 0.0
.bss 95132 95132 0 0.0
.data 3488 3488 0 0.0
.rodata 110416 110416 0 0.0
.text 665660 665660 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728936 728936 0 0.0
(read/write) 167160 167160 0 0.0
.bss 89272 89272 0 0.0
.data 3448 3448 0 0.0
.rodata 85136 85136 0 0.0
.text 643536 643536 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714480 714480 0 0.0
(read/write) 167340 167340 0 0.0
.bss 89456 89456 0 0.0
.data 3444 3444 0 0.0
.rodata 80968 80968 0 0.0
.text 633248 633248 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 567426 567426 0 0.0
(read/write) 207716 207716 0 0.0
.bss 201180 201180 0 0.0
.data 1412 1412 0 0.0
.rodata 83970 83970 0 0.0
.text 481336 481336 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620746 620746 0 0.0
(read/write) 208112 208112 0 0.0
.bss 201544 201544 0 0.0
.data 1448 1448 0 0.0
.rodata 105834 105834 0 0.0
.text 512792 512792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561383 561383 0 0.0
.app_xip_area 451569 451569 0 0.0
.bss 64728 64728 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543623 543623 0 0.0
.app_xip_area 429073 429073 0 0.0
.bss 69424 69424 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562343 562343 0 0.0
.app_xip_area 453985 453985 0 0.0
.bss 63344 63344 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557791 557791 0 0.0
.app_xip_area 446209 446209 0 0.0
.bss 66464 66464 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017540 1017540 0 0.0
.bss 172664 172664 0 0.0
.data 2688 2688 0 0.0
.text 842168 842168 0 0.0
BRD4187C (read/write) 1101356 1101356 0 0.0
.bss 196268 196268 0 0.0
.data 3296 3296 0 0.0
.text 901772 901772 0 0.0
lock-app BRD4161A+wf200 (read/write) 1115200 1115200 0 0.0
.bss 188880 188880 0 0.0
.data 2712 2712 0 0.0
.text 923588 923588 0 0.0
window-app BRD4187C (read/write) 1136272 1136264 -8 -0.0
.bss 168300 168300 0 0.0
.data 3168 3168 0 0.0
.text 964784 964776 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1139076 1139076 0 0.0
(read/write) 1671916 1671916 0 0.0
.dram0.bss 72992 72992 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 242056 242056 0 0.0
.flash.text 1139076 1139076 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1184087 1184087 0 0.0
(read/write) 521100 521100 0 0.0
.dram0.bss 79648 79648 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 273084 273084 0 0.0
.flash.text 1178703 1178703 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605504 605504 0 0.0
(read/write) 81960 81960 0 0.0
.bss 69808 69808 0 0.0
.data 2168 2168 0 0.0
.text 604968 604968 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 691072 691072 0 0.0
.bss 67664 67664 0 0.0
.data 2716 2716 0 0.0
.text 577216 577216 0 0.0
light k32w0+release (read only) 595208 595208 0 0.0
(read/write) 79176 79176 0 0.0
.bss 67072 67072 0 0.0
.data 2120 2120 0 0.0
.text 594672 594672 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782900 782900 0 0.0
.bss 77340 77340 0 0.0
.data 1928 1928 0 0.0
.text 660176 660176 0 0.0
lock k32w0+release (read only) 576600 576600 0 0.0
(read/write) 79440 79440 0 0.0
.bss 67360 67360 0 0.0
.data 2096 2096 0 0.0
.text 576064 576064 0 0.0
linux air-purifier-app debug (read only) 2527397 2527397 0 0.0
(read/write) 127240 127240 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179304 179304 0 0.0
.text 2172693 2172693 0 0.0
all-clusters-app debug (read only) 5421585 5421585 0 0.0
(read/write) 456696 456696 0 0.0
.bss 131760 131760 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 313832 313832 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1280 1280 0 0.0
.rodata 313052 313052 0 0.0
.text 4697427 4697427 0 0.0
all-clusters-minimal-app debug (read only) 4954105 4954105 0 0.0
(read/write) 234720 234720 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95992 95992 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272461 272461 0 0.0
.text 4449187 4449187 0 0.0
bridge-app debug (read only) 4418225 4418225 0 0.0
(read/write) 215960 215960 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219157 219157 0 0.0
.text 3980499 3980499 0 0.0
chip-tool debug (read only) 11735793 11735793 0 0.0
(read/write) 505872 505872 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 399440 399440 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 426313 426313 0 0.0
.text 10616979 10616979 0 0.0
chip-tool-ipv6only arm64 (read only) 11457576 11457576 0 0.0
(read/write) 574152 574152 0 0.0
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 438384 438384 0 0.0
.dynamic 512 512 0 0.0
.got 19856 19856 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 346864 346864 0 0.0
.text 10239928 10239928 0 0.0
lighting-app debug+rpc+ui (read only) 5304025 5304025 0 0.0
(read/write) 225032 225032 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340340 340340 0 0.0
.text 4718899 4718899 0 0.0
lock-app debug (read only) 4503249 4503249 0 0.0
(read/write) 203680 203680 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246997 246997 0 0.0
.text 4046227 4046227 0 0.0
ota-provider-app debug (read only) 4167385 4167385 0 0.0
(read/write) 192728 192728 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201269 201269 0 0.0
.text 3774243 3774243 0 0.0
ota-requestor-app debug (read only) 4256857 4256857 0 0.0
(read/write) 197040 197040 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72320 72320 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205077 205077 0 0.0
.text 3855507 3855507 0 0.0
shell debug (read only) 2793833 2793833 0 0.0
(read/write) 152664 152664 0 0.0
.bss 62440 62440 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83656 83656 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1096 1096 0 0.0
.rodata 182272 182272 0 0.0
.text 2440258 2440258 0 0.0
thermostat-no-ble arm64 (read only) 4406744 4406744 0 0.0
(read/write) 247824 247824 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102384 102384 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162276 162276 0 0.0
.text 3904072 3904072 0 0.0
tv-app debug (read only) 5403353 5403353 0 0.0
(read/write) 349208 349208 0 0.0
.bss 244608 244608 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92312 92312 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 273141 273141 0 0.0
.text 4892371 4892371 0 0.0
tv-casting-app debug (read only) 9612017 9612017 0 0.0
(read/write) 339232 339232 0 0.0
.bss 156384 156384 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 173536 173536 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 363912 363912 0 0.0
.text 8782499 8782499 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526328 2526328 0 0.0
.bss 220280 220280 0 0.0
.data 5144 5144 0 0.0
.text 1489012 1489012 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1068908 1068908 0 0.0
bss 129488 129488 0 0.0
rodata 105580 105580 0 0.0
text 786244 786244 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1194980 1194980 0 0.0
bss 121698 121698 0 0.0
rodata 139336 139336 0 0.0
text 783608 783608 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1040608 1040608 0 0.0
bss 129412 129412 0 0.0
rodata 98896 98896 0 0.0
text 764600 764600 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835752 835752 0 0.0
(read/write) 1752516 1752516 0 0.0
.bss 195108 195108 0 0.0
.data 2480 2480 0 0.0
.text 1546540 1546540 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837848 837848 0 0.0
(read/write) 1706444 1706444 0 0.0
.bss 193020 193020 0 0.0
.data 2472 2472 0 0.0
.text 1502564 1502564 0 0.0
light cy8ckit_062s2_43012 (read only) 844536 844536 0 0.0
(read/write) 1631428 1631428 0 0.0
.bss 186444 186444 0 0.0
.data 2360 2360 0 0.0
.text 1434236 1434236 0 0.0
lock cy8ckit_062s2_43012 (read only) 817416 817416 0 0.0
(read/write) 1658340 1658340 0 0.0
.bss 213540 213540 0 0.0
.data 2384 2384 0 0.0
.text 1434028 1434028 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116940 1116940 0 0.0
.bss 101280 101280 0 0.0
.data 740 740 0 0.0
.text 629316 629316 0 0.0
lock-app qpg6105+debug (read/write) 1080860 1080860 0 0.0
.bss 97576 97576 0 0.0
.data 784 784 0 0.0
.text 593240 593240 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821726 821726 0 0.0
bss 55096 55096 0 0.0
text 614014 614014 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087872 1087872 0 0.0
bss 100504 100504 0 0.0
text 768100 768100 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1084416 1084416 0 0.0
bss 109828 109828 0 0.0
text 753650 753650 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935048 935048 0 0.0
bss 94336 94336 0 0.0
text 647068 647068 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821962 821962 0 0.0
bss 55140 55140 0 0.0
text 614384 614384 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 979048 979048 0 0.0
bss 79124 79124 0 0.0
text 694474 694474 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1093396 1093396 0 0.0
bss 99900 99900 0 0.0
text 769960 769960 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 965680 965680 0 0.0
bss 97388 97388 0 0.0
text 648150 648150 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948724 948724 0 0.0
bss 92444 92444 0 0.0
text 663176 663176 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 880760 880760 0 0.0
bss 69116 69116 0 0.0
text 622394 622394 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 821372 821372 0 0.0
bss 57352 57352 0 0.0
text 589270 589270 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705600 705600 0 0.0
bss 73588 73588 0 0.0
text 462094 462094 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823690 823690 0 0.0
bss 55276 55276 0 0.0
text 617128 617128 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878465 878465 0 0.0
bss 60828 60828 0 0.0
text 631010 631010 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845744 845744 0 0.0
bss 57648 57648 0 0.0
text 607736 607736 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840020 840020 0 0.0
bss 58000 58000 0 0.0
text 601770 601770 0 0.0

@chrisdecenzo chrisdecenzo enabled auto-merge (squash) December 29, 2023 17:16
@chrisdecenzo chrisdecenzo merged commit 420e6d4 into project-chip:master Dec 29, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@hawk248 hawk248 hawk248 approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved tv-casting
Projects
[Device Type] TV & Media
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgregorr-amazon @CLAassistant @sharadb-amazon @hawk248 @chrisdecenzo