-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVSE Delegate callbacks to user application #30999
Merged
mergify
merged 97 commits into
project-chip:master
from
jamesharrow:30997-complete-evse-delegate-implementation
Dec 20, 2023
Merged
EVSE Delegate callbacks to user application #30999
mergify
merged 97 commits into
project-chip:master
from
jamesharrow:30997-complete-evse-delegate-implementation
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed to use amperage_mA, energy_mWh - removed max on epoch_s - removed access for operate - removed side for events
…ogen, but still fails with some parts of regen_all
…ement-to-use-new-types-and-clean-up-other-comments-with-optional-xml' into 30727-add-evse-to-examplesenergy-management-app
…rgy Managament app.
…test with chip-tool
…function names in energy-management-app.
…0997-complete-evse-delegate-implementation
PR #30999: Size comparison from 0a5f3d3 to 55eedc3 Increases (6 builds for linux, nrfconnect, psoc6, telink)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…hese are handled in the IM Commands handler
PR #30999: Size comparison from 7cbac91 to a133b95 Increases (6 builds for linux, nrfconnect, psoc6, telink)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30999: Size comparison from 9310a37 to 73ecb1b Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/all-clusters-app/all-clusters-common/include/EVSECallbacks.h
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/src/EnergyEvseDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/EnergyEvseDelegateImpl.h
Outdated
Show resolved
Hide resolved
examples/energy-management-app/energy-management-common/energy-management-app.matter
Outdated
Show resolved
Hide resolved
examples/energy-management-app/energy-management-common/include/EVSECallbacks.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #30999: Size comparison from 9310a37 to 3f62fea Increases (6 builds for linux, nrfconnect, psoc6, telink)
Decreases (14 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30999: Size comparison from 9310a37 to e8833d9 Increases (44 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…er CommandHandlerInterfaceOnlyClusters. Then turned on EVSE commands in ZAP.
bzbarsky-apple
approved these changes
Dec 19, 2023
PR #30999: Size comparison from 9643ea4 to 4c93db2 Increases (8 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Dec 20, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
energy evse
Issue related to EVSE feature
energy
examples
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #30997 - but does not fix all issues.
Raising this PR to make a small change easier to review.
Also changed all-clusters-app & energy-management-app ZAP file to enable EVSE commands and added config-data.yaml to avoid emberAf...Command linker errors.
Sync'd files in all-clusters-app and energy-management-app where appropriate.
NOT DONE YET: