Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] fix issues in #30260 #30864

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[controller] fix issues in #30260 #30864

merged 2 commits into from
Dec 7, 2023

Conversation

erjiaqing
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

PR #30864: Size comparison from 6907eaa to b9e801d

Increases (3 builds for linux)
platform target config section 6907eaa b9e801d change % change
linux chip-tool debug (read only) 11424113 11424145 32 0.0
.rodata 418281 418313 32 0.0
chip-tool-ipv6only arm64 (read only) 11145520 11145616 96 0.0
.rodata 341016 341080 64 0.0
.text 9950104 9950136 32 0.0
tv-app debug (read only) 5381553 5381585 32 0.0
.rodata 272789 272821 32 0.0
Decreases (3 builds for efr32, linux)
platform target config section 6907eaa b9e801d change % change
efr32 lighting-app BRD4187C (read/write) 1100676 1100668 -8 -0.0
.text 901188 901180 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1114008 1114000 -8 -0.0
.text 922652 922644 -8 -0.0
linux chip-tool-ipv6only arm64 (read/write) 562496 562400 -96 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6907eaa b9e801d change % change
bl602 lighting-app bl602 (read/write) 1413494 1413494 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156900 156900 0 0.0
.text 1081370 1081370 0 0.0
bl602+mfd (read/write) 1427958 1427958 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155860 155860 0 0.0
.text 1096734 1096734 0 0.0
bl602+rpc (read/write) 1461270 1461270 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1113114 1113114 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1178167 1178167 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106272 106272 0 0.0
.text 950738 950738 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1189299 1189299 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105212 105212 0 0.0
.text 962802 962802 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1270179 1270179 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121692 121692 0 0.0
.text 1025800 1025800 0 0.0
bl706-eth (read/write) 998121 998121 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99604 99604 0 0.0
.text 743962 743962 0 0.0
bl706-wifi (read/write) 1234758 1234758 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120584 120584 0 0.0
.text 969760 969760 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1147872 1147872 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100276 100276 0 0.0
.text 943864 943864 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1159324 1159324 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99216 99216 0 0.0
.text 956240 956240 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742268 742268 0 0.0
(read/write) 167116 167116 0 0.0
.bss 89532 89532 0 0.0
.data 3420 3420 0 0.0
.rodata 84656 84656 0 0.0
.text 657224 657224 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759412 759412 0 0.0
(read/write) 177344 177344 0 0.0
.bss 99708 99708 0 0.0
.data 3448 3448 0 0.0
.rodata 79720 79720 0 0.0
.text 679304 679304 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746396 746396 0 0.0
(read/write) 171800 171800 0 0.0
.bss 94164 94164 0 0.0
.data 3448 3448 0 0.0
.rodata 105496 105496 0 0.0
.text 640508 640508 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 699988 699988 0 0.0
(read/write) 166120 166120 0 0.0
.bss 88312 88312 0 0.0
.data 3408 3408 0 0.0
.rodata 80424 80424 0 0.0
.text 619176 619176 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685508 685508 0 0.0
(read/write) 166292 166292 0 0.0
.bss 88488 88488 0 0.0
.data 3404 3404 0 0.0
.rodata 76264 76264 0 0.0
.text 608856 608856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566562 566562 0 0.0
(read/write) 207620 207620 0 0.0
.bss 201084 201084 0 0.0
.data 1412 1412 0 0.0
.rodata 83906 83906 0 0.0
.text 480536 480536 0 0.0
lock CC3235SF_LAUNCHXL (read only) 619810 619810 0 0.0
(read/write) 208016 208016 0 0.0
.bss 201448 201448 0 0.0
.data 1448 1448 0 0.0
.rodata 105778 105778 0 0.0
.text 511912 511912 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561015 561015 0 0.0
.app_xip_area 451305 451305 0 0.0
.bss 64624 64624 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543071 543071 0 0.0
.app_xip_area 428625 428625 0 0.0
.bss 69320 69320 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561927 561927 0 0.0
.app_xip_area 453673 453673 0 0.0
.bss 63240 63240 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557239 557239 0 0.0
.app_xip_area 445761 445761 0 0.0
.bss 66360 66360 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016380 1016380 0 0.0
.bss 172568 172568 0 0.0
.data 2688 2688 0 0.0
.text 841104 841104 0 0.0
BRD4187C (read/write) 1100676 1100668 -8 -0.0
.bss 196172 196172 0 0.0
.data 3296 3296 0 0.0
.text 901188 901180 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1114008 1114000 -8 -0.0
.bss 188624 188624 0 0.0
.data 2712 2712 0 0.0
.text 922652 922644 -8 -0.0
window-app BRD4187C (read/write) 1135000 1135000 0 0.0
.bss 168204 168204 0 0.0
.data 3168 3168 0 0.0
.text 963608 963608 0 0.0
esp32 all-clusters-app c3devkit (read only) 1136036 1136036 0 0.0
(read/write) 1670548 1670548 0 0.0
.dram0.bss 72536 72536 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241152 241152 0 0.0
.flash.text 1136036 1136036 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1181239 1181239 0 0.0
(read/write) 519736 519736 0 0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272176 272176 0 0.0
.flash.text 1175855 1175855 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594784 594784 0 0.0
(read/write) 88128 88128 0 0.0
.bss 71376 71376 0 0.0
.data 2128 2128 0 0.0
.text 594248 594248 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690416 690416 0 0.0
.bss 67584 67584 0 0.0
.data 2716 2716 0 0.0
.text 576640 576640 0 0.0
light k32w0+release (read only) 594496 594496 0 0.0
(read/write) 87804 87804 0 0.0
.bss 71064 71064 0 0.0
.data 2116 2116 0 0.0
.text 593960 593960 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782236 782236 0 0.0
.bss 77252 77252 0 0.0
.data 1928 1928 0 0.0
.text 659600 659600 0 0.0
lock k32w0+release (read only) 565904 565904 0 0.0
(read/write) 85600 85600 0 0.0
.bss 68920 68920 0 0.0
.data 2056 2056 0 0.0
.text 565368 565368 0 0.0
linux air-purifier-app debug (read only) 2524381 2524381 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2169781 2169781 0 0.0
all-clusters-app debug (read only) 5364321 5364321 0 0.0
(read/write) 447648 447648 0 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 306520 306520 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 307964 307964 0 0.0
.text 4652947 4652947 0 0.0
all-clusters-minimal-app debug (read only) 4949441 4949441 0 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272781 272781 0 0.0
.text 4444211 4444211 0 0.0
bridge-app debug (read only) 4414177 4414177 0 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3976499 3976499 0 0.0
chip-tool debug (read only) 11424113 11424145 32 0.0
(read/write) 496008 496008 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 389696 389696 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 418281 418313 32 0.0
.text 10328691 10328691 0 0.0
chip-tool-ipv6only arm64 (read only) 11145520 11145616 96 0.0
(read/write) 562496 562400 -96 -0.0
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 428408 428408 0 0.0
.dynamic 512 512 0 0.0
.got 19584 19584 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 341016 341080 64 0.0
.text 9950104 9950136 32 0.0
lighting-app debug+rpc+ui (read only) 5300201 5300201 0 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340212 340212 0 0.0
.text 4715219 4715219 0 0.0
lock-app debug (read only) 4499809 4499809 0 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4042787 4042787 0 0.0
ota-provider-app debug (read only) 4163449 4163449 0 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3770291 3770291 0 0.0
ota-requestor-app debug (read only) 4252873 4252873 0 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3851507 3851507 0 0.0
shell debug (read only) 2777129 2777129 0 0.0
(read/write) 149792 149792 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82608 82608 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180992 180992 0 0.0
.text 2425426 2425426 0 0.0
thermostat-no-ble arm64 (read only) 4401536 4401536 0 0.0
(read/write) 244824 244824 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3898856 3898856 0 0.0
tv-app debug (read only) 5381553 5381585 32 0.0
(read/write) 348896 348896 0 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272789 272821 32 0.0
.text 4870931 4870931 0 0.0
tv-casting-app debug (read only) 9335905 9335905 0 0.0
(read/write) 334776 334776 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 169272 169272 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 359976 359976 0 0.0
.text 8520595 8520595 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525648 2525648 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488332 1488332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060828 1060828 0 0.0
bss 129029 129029 0 0.0
rodata 104172 104172 0 0.0
text 779956 779956 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187388 1187388 0 0.0
bss 121239 121239 0 0.0
rodata 138304 138304 0 0.0
text 777524 777524 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046460 1046460 0 0.0
bss 129316 129316 0 0.0
rodata 99436 99436 0 0.0
text 770040 770040 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836224 836224 0 0.0
(read/write) 1741012 1741012 0 0.0
.bss 194644 194644 0 0.0
.data 2472 2472 0 0.0
.text 1535508 1535508 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837944 837944 0 0.0
(read/write) 1705316 1705316 0 0.0
.bss 192924 192924 0 0.0
.data 2472 2472 0 0.0
.text 1501532 1501532 0 0.0
light cy8ckit_062s2_43012 (read only) 844632 844632 0 0.0
(read/write) 1630364 1630364 0 0.0
.bss 186348 186348 0 0.0
.data 2360 2360 0 0.0
.text 1433268 1433268 0 0.0
lock cy8ckit_062s2_43012 (read only) 817512 817512 0 0.0
(read/write) 1657260 1657260 0 0.0
.bss 213444 213444 0 0.0
.data 2384 2384 0 0.0
.text 1433044 1433044 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116356 1116356 0 0.0
.bss 101200 101200 0 0.0
.data 740 740 0 0.0
.text 628732 628732 0 0.0
lock-app qpg6105+debug (read/write) 1079996 1079996 0 0.0
.bss 97336 97336 0 0.0
.data 784 784 0 0.0
.text 592376 592376 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819986 819986 0 0.0
bss 54904 54904 0 0.0
text 612678 612678 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077840 1077840 0 0.0
bss 100072 100072 0 0.0
text 760564 760564 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083084 1083084 0 0.0
bss 109764 109764 0 0.0
text 752574 752574 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933820 933820 0 0.0
bss 94272 94272 0 0.0
text 646090 646090 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820154 820154 0 0.0
bss 54948 54948 0 0.0
text 612972 612972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 977188 977188 0 0.0
bss 78932 78932 0 0.0
text 693004 693004 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092152 1092152 0 0.0
bss 99836 99836 0 0.0
text 768974 768974 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 963468 963468 0 0.0
bss 97196 97196 0 0.0
text 646710 646710 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 947472 947472 0 0.0
bss 92380 92380 0 0.0
text 662180 662180 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878980 878980 0 0.0
bss 68924 68924 0 0.0
text 621014 621014 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819584 819584 0 0.0
bss 57160 57160 0 0.0
text 587890 587890 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705416 705416 0 0.0
bss 73588 73588 0 0.0
text 461916 461916 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821822 821822 0 0.0
bss 55084 55084 0 0.0
text 615644 615644 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876653 876653 0 0.0
bss 60636 60636 0 0.0
text 629586 629586 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843796 843796 0 0.0
bss 57456 57456 0 0.0
text 606216 606216 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838208 838208 0 0.0
bss 57808 57808 0 0.0
text 600350 600350 0 0.0

@erjiaqing erjiaqing marked this pull request as ready for review December 7, 2023 08:19
@yunhanw-google yunhanw-google enabled auto-merge (squash) December 7, 2023 16:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

PR #30864: Size comparison from 6907eaa to 9528dac

Increases above 0.2%:

platform target config section 6907eaa 9528dac change % change
linux thermostat-no-ble arm64 (read/write) 244824 247656 2832 1.2
Increases (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
platform target config section 6907eaa 9528dac change % change
bl602 lighting-app bl602 (read/write) 1413494 1413734 240 0.0
.text 1081370 1081626 256 0.0
bl602+mfd (read/write) 1427958 1428198 240 0.0
.text 1096734 1096990 256 0.0
bl602+rpc (read/write) 1461270 1461518 248 0.0
.text 1113114 1113370 256 0.0
bl702 lighting-app bl702 (read/write) 1178167 1178411 244 0.0
.text 950738 950994 256 0.0
bl702+rpc (read/write) 1270179 1270423 244 0.0
.text 1025800 1026056 256 0.0
bl706-eth (read/write) 998121 998365 244 0.0
.text 743962 744218 256 0.0
bl706-wifi (read/write) 1234758 1235002 244 0.0
.text 969760 970016 256 0.0
bl702l lighting-app bl702l (read/write) 1147872 1148116 244 0.0
.text 943864 944120 256 0.0
bl702l+mfd (read/write) 1159324 1159568 244 0.0
.text 956240 956496 256 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742268 742284 16 0.0
.text 657224 657256 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561015 561039 24 0.0
.app_xip_area 451305 451329 24 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561927 561943 16 0.0
.app_xip_area 453673 453689 16 0.0
switch cyw930739m2evb_01 (read/write) 557239 557255 16 0.0
.app_xip_area 445761 445777 16 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016380 1016516 136 0.0
.text 841104 841240 136 0.0
BRD4187C (read/write) 1100676 1100692 16 0.0
.text 901188 901204 16 0.0
window-app BRD4187C (read/write) 1135000 1135120 120 0.0
.text 963608 963728 120 0.0
esp32 all-clusters-app c3devkit (read only) 1136036 1136088 52 0.0
.flash.text 1136036 1136088 52 0.0
m5stack (read only) 1181239 1181279 40 0.0
.flash.text 1175855 1175895 40 0.0
k32w contact k32w0+release (read only) 594784 594800 16 0.0
.text 594248 594264 16 0.0
k32w1+release (read/write) 690416 690440 24 0.0
.text 576640 576664 24 0.0
linux all-clusters-app debug (read only) 5364321 5365561 1240 0.0
(read/write) 447648 447712 64 0.0
.data.rel.ro 306520 306584 64 0.0
.rodata 307964 308028 64 0.0
.text 4652947 4654099 1152 0.0
all-clusters-minimal-app debug (read only) 4949441 4950601 1160 0.0
.rodata 272781 272813 32 0.0
.text 4444211 4445363 1152 0.0
bridge-app debug (read only) 4414177 4415305 1128 0.0
.text 3976499 3977651 1152 0.0
chip-tool debug (read only) 11424113 11424193 80 0.0
(read/write) 496008 496072 64 0.0
.data.rel.ro 389696 389760 64 0.0
.rodata 418281 418313 32 0.0
chip-tool-ipv6only arm64 (read only) 11145520 11145680 160 0.0
.data.rel.ro 428408 428472 64 0.0
.rodata 341016 341096 80 0.0
.text 9950104 9950136 32 0.0
lighting-app debug+rpc+ui (read only) 5300201 5301345 1144 0.0
.rodata 340212 340244 32 0.0
.text 4715219 4716355 1136 0.0
ota-provider-app debug (read only) 4163449 4164561 1112 0.0
.text 3770291 3771427 1136 0.0
ota-requestor-app debug (read only) 4252873 4253985 1112 0.0
.text 3851507 3852643 1136 0.0
shell debug (read only) 2777129 2778273 1144 0.0
.rodata 180992 181024 32 0.0
.text 2425426 2426562 1136 0.0
thermostat-no-ble arm64 (read only) 4401536 4402808 1272 0.0
(read/write) 244824 247656 2832 1.2
.text 3898856 3900184 1328 0.0
tv-app debug (read only) 5381553 5382729 1176 0.0
.rodata 272789 272853 64 0.0
.text 4870931 4872067 1136 0.0
tv-casting-app debug (read only) 9335905 9337033 1128 0.0
.text 8520595 8521747 1152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1060828 1060848 20 0.0
text 779956 779988 32 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1187388 1187408 20 0.0
text 777524 777556 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1046460 1046480 20 0.0
text 770040 770072 32 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1741012 1741132 120 0.0
.text 1535508 1535628 120 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1705316 1705436 120 0.0
.text 1501532 1501652 120 0.0
light cy8ckit_062s2_43012 (read/write) 1630364 1630492 128 0.0
.text 1433268 1433396 128 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1077840 1077884 44 0.0
text 760564 760616 52 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1083084 1083120 36 0.0
text 752574 752626 52 0.0
bridge-app tlsr9518adk80d (read/write) 933820 933864 44 0.0
text 646090 646142 52 0.0
contact-sensor-app tlsr9528a_retention (read/write) 820154 820198 44 0.0
text 612972 613024 52 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 977188 977232 44 0.0
text 693004 693056 52 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1092152 1092196 44 0.0
text 768974 769026 52 0.0
ota-requestor-app tlsr9518adk80d (read/write) 947472 947508 36 0.0
text 662180 662232 52 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 821822 821858 36 0.0
text 615644 615696 52 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 876653 876689 36 0.0
text 629586 629638 52 0.0
thermostat tlsr9518adk80d (read/write) 843796 843832 36 0.0
text 606216 606268 52 0.0
window-covering tlsr9518adk80d (read/write) 838208 838252 44 0.0
text 600350 600402 52 0.0
Decreases (19 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, linux, nrfconnect)
platform target config section 6907eaa 9528dac change % change
bl602 lighting-app bl602 .rodata 156900 156884 -16 -0.0
bl602+mfd .rodata 155860 155844 -16 -0.0
bl602+rpc .rodata 164516 164508 -8 -0.0
bl702 lighting-app bl702 .rodata 106272 106260 -12 -0.0
bl702+mfd (read/write) 1189299 1189287 -12 -0.0
.rodata 105212 105200 -12 -0.0
bl702+rpc .rodata 121692 121680 -12 -0.0
bl706-eth .rodata 99604 99592 -12 -0.0
bl706-wifi .rodata 120584 120572 -12 -0.0
bl702l lighting-app bl702l .rodata 100276 100264 -12 -0.0
bl702l+mfd .rodata 99216 99204 -12 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 .rodata 84656 84640 -16 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1114008 1114000 -8 -0.0
.text 922652 922644 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1670548 1670540 -8 -0.0
.flash.rodata 241152 241144 -8 -0.0
m5stack (read/write) 519736 519728 -8 -0.0
.flash.rodata 272176 272168 -8 -0.0
linux chip-tool-ipv6only arm64 (read/write) 562496 562336 -160 -0.0
thermostat-no-ble arm64 .rodata 162332 162308 -24 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 104172 104160 -12 -0.0
nrf7002dk_nrf5340_cpuapp rodata 138304 138292 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 99436 99424 -12 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6907eaa 9528dac change % change
bl602 lighting-app bl602 (read/write) 1413494 1413734 240 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156900 156884 -16 -0.0
.text 1081370 1081626 256 0.0
bl602+mfd (read/write) 1427958 1428198 240 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155860 155844 -16 -0.0
.text 1096734 1096990 256 0.0
bl602+rpc (read/write) 1461270 1461518 248 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164508 -8 -0.0
.text 1113114 1113370 256 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1178167 1178411 244 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106272 106260 -12 -0.0
.text 950738 950994 256 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1189299 1189287 -12 -0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105212 105200 -12 -0.0
.text 962802 962802 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1270179 1270423 244 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121692 121680 -12 -0.0
.text 1025800 1026056 256 0.0
bl706-eth (read/write) 998121 998365 244 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99604 99592 -12 -0.0
.text 743962 744218 256 0.0
bl706-wifi (read/write) 1234758 1235002 244 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120584 120572 -12 -0.0
.text 969760 970016 256 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1147872 1148116 244 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100276 100264 -12 -0.0
.text 943864 944120 256 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1159324 1159568 244 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99216 99204 -12 -0.0
.text 956240 956496 256 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742268 742284 16 0.0
(read/write) 167116 167116 0 0.0
.bss 89532 89532 0 0.0
.data 3420 3420 0 0.0
.rodata 84656 84640 -16 -0.0
.text 657224 657256 32 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759412 759412 0 0.0
(read/write) 177344 177344 0 0.0
.bss 99708 99708 0 0.0
.data 3448 3448 0 0.0
.rodata 79720 79720 0 0.0
.text 679304 679304 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746396 746396 0 0.0
(read/write) 171800 171800 0 0.0
.bss 94164 94164 0 0.0
.data 3448 3448 0 0.0
.rodata 105496 105496 0 0.0
.text 640508 640508 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 699988 699988 0 0.0
(read/write) 166120 166120 0 0.0
.bss 88312 88312 0 0.0
.data 3408 3408 0 0.0
.rodata 80424 80424 0 0.0
.text 619176 619176 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685508 685508 0 0.0
(read/write) 166292 166292 0 0.0
.bss 88488 88488 0 0.0
.data 3404 3404 0 0.0
.rodata 76264 76264 0 0.0
.text 608856 608856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566562 566562 0 0.0
(read/write) 207620 207620 0 0.0
.bss 201084 201084 0 0.0
.data 1412 1412 0 0.0
.rodata 83906 83906 0 0.0
.text 480536 480536 0 0.0
lock CC3235SF_LAUNCHXL (read only) 619810 619810 0 0.0
(read/write) 208016 208016 0 0.0
.bss 201448 201448 0 0.0
.data 1448 1448 0 0.0
.rodata 105778 105778 0 0.0
.text 511912 511912 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561015 561039 24 0.0
.app_xip_area 451305 451329 24 0.0
.bss 64624 64624 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543071 543071 0 0.0
.app_xip_area 428625 428625 0 0.0
.bss 69320 69320 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561927 561943 16 0.0
.app_xip_area 453673 453689 16 0.0
.bss 63240 63240 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557239 557255 16 0.0
.app_xip_area 445761 445777 16 0.0
.bss 66360 66360 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016380 1016516 136 0.0
.bss 172568 172568 0 0.0
.data 2688 2688 0 0.0
.text 841104 841240 136 0.0
BRD4187C (read/write) 1100676 1100692 16 0.0
.bss 196172 196172 0 0.0
.data 3296 3296 0 0.0
.text 901188 901204 16 0.0
lock-app BRD4161A+wf200 (read/write) 1114008 1114000 -8 -0.0
.bss 188624 188624 0 0.0
.data 2712 2712 0 0.0
.text 922652 922644 -8 -0.0
window-app BRD4187C (read/write) 1135000 1135120 120 0.0
.bss 168204 168204 0 0.0
.data 3168 3168 0 0.0
.text 963608 963728 120 0.0
esp32 all-clusters-app c3devkit (read only) 1136036 1136088 52 0.0
(read/write) 1670548 1670540 -8 -0.0
.dram0.bss 72536 72536 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241152 241144 -8 -0.0
.flash.text 1136036 1136088 52 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1181239 1181279 40 0.0
(read/write) 519736 519728 -8 -0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272176 272168 -8 -0.0
.flash.text 1175855 1175895 40 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594784 594800 16 0.0
(read/write) 88128 88128 0 0.0
.bss 71376 71376 0 0.0
.data 2128 2128 0 0.0
.text 594248 594264 16 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690416 690440 24 0.0
.bss 67584 67584 0 0.0
.data 2716 2716 0 0.0
.text 576640 576664 24 0.0
light k32w0+release (read only) 594496 594496 0 0.0
(read/write) 87804 87804 0 0.0
.bss 71064 71064 0 0.0
.data 2116 2116 0 0.0
.text 593960 593960 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782236 782236 0 0.0
.bss 77252 77252 0 0.0
.data 1928 1928 0 0.0
.text 659600 659600 0 0.0
lock k32w0+release (read only) 565904 565904 0 0.0
(read/write) 85600 85600 0 0.0
.bss 68920 68920 0 0.0
.data 2056 2056 0 0.0
.text 565368 565368 0 0.0
linux air-purifier-app debug (read only) 2524381 2524381 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2169781 2169781 0 0.0
all-clusters-app debug (read only) 5364321 5365561 1240 0.0
(read/write) 447648 447712 64 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 306520 306584 64 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 307964 308028 64 0.0
.text 4652947 4654099 1152 0.0
all-clusters-minimal-app debug (read only) 4949441 4950601 1160 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272781 272813 32 0.0
.text 4444211 4445363 1152 0.0
bridge-app debug (read only) 4414177 4415305 1128 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3976499 3977651 1152 0.0
chip-tool debug (read only) 11424113 11424193 80 0.0
(read/write) 496008 496072 64 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 389696 389760 64 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 418281 418313 32 0.0
.text 10328691 10328691 0 0.0
chip-tool-ipv6only arm64 (read only) 11145520 11145680 160 0.0
(read/write) 562496 562336 -160 -0.0
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 428408 428472 64 0.0
.dynamic 512 512 0 0.0
.got 19584 19584 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 341016 341096 80 0.0
.text 9950104 9950136 32 0.0
lighting-app debug+rpc+ui (read only) 5300201 5301345 1144 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340212 340244 32 0.0
.text 4715219 4716355 1136 0.0
lock-app debug (read only) 4499809 4499809 0 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4042787 4042787 0 0.0
ota-provider-app debug (read only) 4163449 4164561 1112 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3770291 3771427 1136 0.0
ota-requestor-app debug (read only) 4252873 4253985 1112 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3851507 3852643 1136 0.0
shell debug (read only) 2777129 2778273 1144 0.0
(read/write) 149792 149792 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82608 82608 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180992 181024 32 0.0
.text 2425426 2426562 1136 0.0
thermostat-no-ble arm64 (read only) 4401536 4402808 1272 0.0
(read/write) 244824 247656 2832 1.2
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162308 -24 -0.0
.text 3898856 3900184 1328 0.0
tv-app debug (read only) 5381553 5382729 1176 0.0
(read/write) 348896 348896 0 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272789 272853 64 0.0
.text 4870931 4872067 1136 0.0
tv-casting-app debug (read only) 9335905 9337033 1128 0.0
(read/write) 334776 334776 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 169272 169272 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 359976 359976 0 0.0
.text 8520595 8521747 1152 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525648 2525648 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488332 1488332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060828 1060848 20 0.0
bss 129029 129029 0 0.0
rodata 104172 104160 -12 -0.0
text 779956 779988 32 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187388 1187408 20 0.0
bss 121239 121239 0 0.0
rodata 138304 138292 -12 -0.0
text 777524 777556 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046460 1046480 20 0.0
bss 129316 129316 0 0.0
rodata 99436 99424 -12 -0.0
text 770040 770072 32 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836224 836224 0 0.0
(read/write) 1741012 1741132 120 0.0
.bss 194644 194644 0 0.0
.data 2472 2472 0 0.0
.text 1535508 1535628 120 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837944 837944 0 0.0
(read/write) 1705316 1705436 120 0.0
.bss 192924 192924 0 0.0
.data 2472 2472 0 0.0
.text 1501532 1501652 120 0.0
light cy8ckit_062s2_43012 (read only) 844632 844632 0 0.0
(read/write) 1630364 1630492 128 0.0
.bss 186348 186348 0 0.0
.data 2360 2360 0 0.0
.text 1433268 1433396 128 0.0
lock cy8ckit_062s2_43012 (read only) 817512 817512 0 0.0
(read/write) 1657260 1657260 0 0.0
.bss 213444 213444 0 0.0
.data 2384 2384 0 0.0
.text 1433044 1433044 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116356 1116356 0 0.0
.bss 101200 101200 0 0.0
.data 740 740 0 0.0
.text 628732 628732 0 0.0
lock-app qpg6105+debug (read/write) 1079996 1079996 0 0.0
.bss 97336 97336 0 0.0
.data 784 784 0 0.0
.text 592376 592376 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819986 819986 0 0.0
bss 54904 54904 0 0.0
text 612678 612678 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077840 1077884 44 0.0
bss 100072 100072 0 0.0
text 760564 760616 52 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083084 1083120 36 0.0
bss 109764 109764 0 0.0
text 752574 752626 52 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933820 933864 44 0.0
bss 94272 94272 0 0.0
text 646090 646142 52 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820154 820198 44 0.0
bss 54948 54948 0 0.0
text 612972 613024 52 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 977188 977232 44 0.0
bss 78932 78932 0 0.0
text 693004 693056 52 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092152 1092196 44 0.0
bss 99836 99836 0 0.0
text 768974 769026 52 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 963468 963468 0 0.0
bss 97196 97196 0 0.0
text 646710 646710 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 947472 947508 36 0.0
bss 92380 92380 0 0.0
text 662180 662232 52 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878980 878980 0 0.0
bss 68924 68924 0 0.0
text 621014 621014 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819584 819584 0 0.0
bss 57160 57160 0 0.0
text 587890 587890 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705416 705416 0 0.0
bss 73588 73588 0 0.0
text 461916 461916 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821822 821858 36 0.0
bss 55084 55084 0 0.0
text 615644 615696 52 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876653 876689 36 0.0
bss 60636 60636 0 0.0
text 629586 629638 52 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843796 843832 36 0.0
bss 57456 57456 0 0.0
text 606216 606268 52 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838208 838252 44 0.0
bss 57808 57808 0 0.0
text 600350 600402 52 0.0

@yunhanw-google yunhanw-google merged commit ad34317 into project-chip:master Dec 7, 2023
54 checks passed
mkardous-silabs
mkardous-silabs reviewed Dec 7, 2023
View reviewed changes
src/controller/CHIPDeviceController.cpp
auto pairingDelegate = commissioner->GetPairingDelegate();
auto deviceBeingCommissioned = commissioner->mDeviceBeingCommissioned;
if (pairingDelegate != nullptr && deviceBeingCommissioned != nullptr)
if (commissioner->mCommissioningStage != CommissioningStage::kICDRegistration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion if this is touched later
VerifyOrReturn(commissioner->mCommissioningStage == CommissioningStage::kICDRegistration);

mkardous-silabs
mkardous-silabs reviewed Dec 7, 2023
View reviewed changes
src/controller/CHIPDeviceController.cpp
}
else

if (commissioner->mDeviceBeingCommissioned == nullptr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion if this is touched later
VerifyOrReturn(commissioner->mDeviceBeingCommissioned != nullptr);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erjiaqing @yunhanw-google @bzbarsky-apple @mkardous-silabs