Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Finish ICDM server refactor #30703

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[ICD] Finish ICDM server refactor #30703

merged 3 commits into from
Nov 29, 2023

Conversation

mkardous-silabs
Copy link
Contributor

Description

Finishes the ICDM server refactor that was started in the #30618

  • Move commandData processing inside the associated function
  • Move Admin check inside the the associated function
  • rename variables to match SDK casing

fixes #30631

Tests

PR doesn't do any functionnal changes.
Using CI to validate no regressions where caused.

@github-actions github-actions bot added the app label Nov 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

PR #30703: Size comparison from ba504e3 to 58ab5b2

Decreases (1 build for telink)
platform target config section ba504e3 58ab5b2 change % change
telink smoke_co_alarm-app tlsr9528a_retention (read/write) 822482 822450 -32 -0.0
text 615644 615612 -32 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section ba504e3 58ab5b2 change % change
bl602 lighting-app bl602 (read/write) 1411414 1411414 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156860 156860 0 0.0
.text 1079478 1079478 0 0.0
bl602+mfd (read/write) 1425854 1425854 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155820 155820 0 0.0
.text 1094830 1094830 0 0.0
bl602+rpc (read/write) 1458934 1458934 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164476 164476 0 0.0
.text 1110966 1110966 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1175847 1175847 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106232 106232 0 0.0
.text 948626 948626 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1186971 1186971 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105172 105172 0 0.0
.text 960690 960690 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1275915 1275915 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121648 121648 0 0.0
.text 1023688 1023688 0 0.0
bl706-eth (read/write) 995813 995813 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99572 99572 0 0.0
.text 741862 741862 0 0.0
bl706-wifi (read/write) 1231962 1231962 0 0.0
.bss 10641 10641 0 0.0
.data 3568 3568 0 0.0
.rodata 120544 120544 0 0.0
.text 967178 967178 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1145540 1145540 0 0.0
.bss 16392 16392 0 0.0
.data 4920 4920 0 0.0
.rodata 100236 100236 0 0.0
.text 941716 941716 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1157000 1157000 0 0.0
.bss 16568 16568 0 0.0
.data 4904 4904 0 0.0
.rodata 99176 99176 0 0.0
.text 954092 954092 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740147 740147 0 0.0
(read/write) 167056 167056 0 0.0
.bss 89468 89468 0 0.0
.data 3424 3424 0 0.0
.rodata 84607 84607 0 0.0
.text 655148 655148 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757659 757659 0 0.0
(read/write) 177300 177300 0 0.0
.bss 99652 99652 0 0.0
.data 3452 3452 0 0.0
.rodata 79695 79695 0 0.0
.text 677572 677572 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744595 744595 0 0.0
(read/write) 171748 171748 0 0.0
.bss 94100 94100 0 0.0
.data 3452 3452 0 0.0
.rodata 105455 105455 0 0.0
.text 638752 638752 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698483 698483 0 0.0
(read/write) 166092 166092 0 0.0
.bss 88272 88272 0 0.0
.data 3412 3412 0 0.0
.rodata 80383 80383 0 0.0
.text 617708 617708 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 683955 683955 0 0.0
(read/write) 166232 166232 0 0.0
.bss 88424 88424 0 0.0
.data 3408 3408 0 0.0
.rodata 76215 76215 0 0.0
.text 607348 607348 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564986 564986 0 0.0
(read/write) 207512 207512 0 0.0
.bss 200972 200972 0 0.0
.data 1416 1416 0 0.0
.rodata 83858 83858 0 0.0
.text 479004 479004 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617994 617994 0 0.0
(read/write) 207908 207908 0 0.0
.bss 201336 201336 0 0.0
.data 1452 1452 0 0.0
.rodata 105730 105730 0 0.0
.text 510144 510144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558543 558543 0 0.0
.app_xip_area 448945 448945 0 0.0
.bss 64512 64512 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540935 540935 0 0.0
.app_xip_area 426601 426601 0 0.0
.bss 69208 69208 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559911 559911 0 0.0
.app_xip_area 451769 451769 0 0.0
.bss 63128 63128 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 555063 555063 0 0.0
.app_xip_area 443689 443689 0 0.0
.bss 66248 66248 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013344 1013344 0 0.0
.bss 172456 172456 0 0.0
.data 2692 2692 0 0.0
.text 838176 838176 0 0.0
BRD4187C (read/write) 1098264 1098264 0 0.0
.bss 196060 196060 0 0.0
.data 3300 3300 0 0.0
.text 898884 898884 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111240 1111240 0 0.0
.bss 188504 188504 0 0.0
.data 2716 2716 0 0.0
.text 919996 919996 0 0.0
window-app BRD4187C (read/write) 1132596 1132596 0 0.0
.bss 168092 168092 0 0.0
.data 3172 3172 0 0.0
.text 961312 961312 0 0.0
esp32 all-clusters-app c3devkit (read only) 1134038 1134038 0 0.0
(read/write) 1671116 1671116 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241816 241816 0 0.0
.flash.text 1134038 1134038 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178475 1178475 0 0.0
(read/write) 520728 520728 0 0.0
.dram0.bss 79072 79072 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273272 273272 0 0.0
.flash.text 1173091 1173091 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592812 592812 0 0.0
(read/write) 88076 88076 0 0.0
.bss 71320 71320 0 0.0
.data 2132 2132 0 0.0
.text 592276 592276 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688364 688364 0 0.0
.bss 67520 67520 0 0.0
.data 2720 2720 0 0.0
.text 574648 574648 0 0.0
light k32w0+release (read only) 592516 592516 0 0.0
(read/write) 87752 87752 0 0.0
.bss 71008 71008 0 0.0
.data 2120 2120 0 0.0
.text 591980 591980 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780216 780216 0 0.0
.bss 77196 77196 0 0.0
.data 1932 1932 0 0.0
.text 657632 657632 0 0.0
lock k32w0+release (read only) 564340 564340 0 0.0
(read/write) 85572 85572 0 0.0
.bss 68888 68888 0 0.0
.data 2060 2060 0 0.0
.text 563804 563804 0 0.0
linux air-purifier-app debug (read only) 2507693 2507693 0 0.0
(read/write) 126856 126856 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 177512 177512 0 0.0
.text 2155493 2155493 0 0.0
all-clusters-app debug (read only) 5339273 5339273 0 0.0
(read/write) 435776 435776 0 0.0
.bss 130064 130064 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 294608 294608 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 304348 304348 0 0.0
.text 4641523 4641523 0 0.0
all-clusters-minimal-app debug (read only) 4933561 4933561 0 0.0
(read/write) 234464 234464 0 0.0
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95680 95680 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270861 270861 0 0.0
.text 4430707 4430707 0 0.0
bridge-app debug (read only) 4406417 4406417 0 0.0
(read/write) 215736 215736 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85056 85056 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218517 218517 0 0.0
.text 3969683 3969683 0 0.0
chip-tool debug (read only) 10895937 10895937 0 0.0
(read/write) 473768 473768 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 367480 367480 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 403113 403113 0 0.0
.text 9852355 9852355 0 0.0
chip-tool-ipv6only arm64 (read only) 10730104 10730104 0 0.0
(read/write) 539688 539688 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 405688 405688 0 0.0
.dynamic 512 512 0 0.0
.got 19048 19048 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 328640 328640 0 0.0
.text 9585928 9585928 0 0.0
lighting-app debug+rpc+ui (read only) 5281737 5281737 0 0.0
(read/write) 224648 224648 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93312 93312 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 338516 338516 0 0.0
.text 4699123 4699123 0 0.0
lock-app debug (read only) 4491569 4491569 0 0.0
(read/write) 203424 203424 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246517 246517 0 0.0
.text 4035395 4035395 0 0.0
ota-provider-app debug (read only) 4155609 4155609 0 0.0
(read/write) 192536 192536 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69072 69072 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 200789 200789 0 0.0
.text 3763299 3763299 0 0.0
ota-requestor-app debug (read only) 4241833 4241833 0 0.0
(read/write) 196784 196784 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72032 72032 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 204565 204565 0 0.0
.text 3841443 3841443 0 0.0
shell debug (read only) 2767737 2767737 0 0.0
(read/write) 149632 149632 0 0.0
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82440 82440 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180768 180768 0 0.0
.text 2416594 2416594 0 0.0
thermostat-no-ble arm64 (read only) 4392896 4392896 0 0.0
(read/write) 245336 245336 0 0.0
.bss 122232 122232 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102120 102120 0 0.0
.dynamic 512 512 0 0.0
.got 11928 11928 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161980 161980 0 0.0
.text 3891192 3891192 0 0.0
tv-app debug (read only) 5276665 5276665 0 0.0
(read/write) 345232 345232 0 0.0
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90344 90344 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 267285 267285 0 0.0
.text 4774643 4774643 0 0.0
tv-casting-app debug (read only) 8835929 8835929 0 0.0
(read/write) 325016 325016 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 159520 159520 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 349736 349736 0 0.0
.text 8055651 8055651 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523944 2523944 0 0.0
.bss 220072 220072 0 0.0
.data 5144 5144 0 0.0
.text 1486628 1486628 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057980 1057980 0 0.0
bss 128917 128917 0 0.0
rodata 104140 104140 0 0.0
text 777272 777272 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184524 1184524 0 0.0
bss 121127 121127 0 0.0
rodata 138268 138268 0 0.0
text 774800 774800 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043116 1043116 0 0.0
bss 129204 129204 0 0.0
rodata 99316 99316 0 0.0
text 766944 766944 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836336 836336 0 0.0
(read/write) 1738172 1738172 0 0.0
.bss 194532 194532 0 0.0
.data 2472 2472 0 0.0
.text 1532780 1532780 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 838048 0 0.0
(read/write) 1701916 1701916 0 0.0
.bss 192812 192812 0 0.0
.data 2480 2480 0 0.0
.text 1498236 1498236 0 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1628004 1628004 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1431012 1431012 0 0.0
lock cy8ckit_062s2_43012 (read only) 817616 817616 0 0.0
(read/write) 1655204 1655204 0 0.0
.bss 213332 213332 0 0.0
.data 2392 2392 0 0.0
.text 1431092 1431092 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114356 1114356 0 0.0
.bss 101144 101144 0 0.0
.data 744 744 0 0.0
.text 626736 626736 0 0.0
lock-app qpg6105+debug (read/write) 1077476 1077476 0 0.0
.bss 97272 97272 0 0.0
.data 788 788 0 0.0
.text 589852 589852 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820662 820662 0 0.0
bss 55004 55004 0 0.0
text 612692 612692 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075468 1075468 0 0.0
bss 99960 99960 0 0.0
text 758326 758326 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080176 1080176 0 0.0
bss 109652 109652 0 0.0
text 749906 749906 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932404 932404 0 0.0
bss 94160 94160 0 0.0
text 644804 644804 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820774 820774 0 0.0
bss 55056 55056 0 0.0
text 612916 612916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 974940 974940 0 0.0
bss 78900 78900 0 0.0
text 690908 690908 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090064 1090064 0 0.0
bss 99724 99724 0 0.0
text 767036 767036 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 961536 961536 0 0.0
bss 97164 97164 0 0.0
text 644922 644922 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945660 945660 0 0.0
bss 92268 92268 0 0.0
text 660516 660516 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 877136 877136 0 0.0
bss 68892 68892 0 0.0
text 619304 619304 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 817740 817740 0 0.0
bss 57128 57128 0 0.0
text 586180 586180 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705404 705404 0 0.0
bss 73588 73588 0 0.0
text 461922 461922 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822482 822450 -32 -0.0
bss 55184 55184 0 0.0
text 615644 615612 -32 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874589 874589 0 0.0
bss 60604 60604 0 0.0
text 627670 627670 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 841888 841888 0 0.0
bss 57424 57424 0 0.0
text 604438 604438 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836388 836388 0 0.0
bss 57776 57776 0 0.0
text 598666 598666 0 0.0

@woody-apple woody-apple added this to the 1.3 Feature Complete milestone Nov 29, 2023
@mkardous-silabs mkardous-silabs enabled auto-merge (squash) November 29, 2023 18:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

PR #30703: Size comparison from b379158 to 5244958

Decreases (1 build for telink)
platform target config section b379158 5244958 change % change
telink smoke_co_alarm-app tlsr9528a_retention (read/write) 822482 822450 -32 -0.0
text 615644 615612 -32 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b379158 5244958 change % change
bl602 lighting-app bl602 (read/write) 1411414 1411414 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156860 156860 0 0.0
.text 1079478 1079478 0 0.0
bl602+mfd (read/write) 1425854 1425854 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155820 155820 0 0.0
.text 1094830 1094830 0 0.0
bl602+rpc (read/write) 1458934 1458934 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164476 164476 0 0.0
.text 1110966 1110966 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1175847 1175847 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106232 106232 0 0.0
.text 948626 948626 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1186971 1186971 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105172 105172 0 0.0
.text 960690 960690 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1275915 1275915 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121648 121648 0 0.0
.text 1023688 1023688 0 0.0
bl706-eth (read/write) 995813 995813 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99572 99572 0 0.0
.text 741862 741862 0 0.0
bl706-wifi (read/write) 1231962 1231962 0 0.0
.bss 10641 10641 0 0.0
.data 3568 3568 0 0.0
.rodata 120544 120544 0 0.0
.text 967178 967178 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1145540 1145540 0 0.0
.bss 16392 16392 0 0.0
.data 4920 4920 0 0.0
.rodata 100236 100236 0 0.0
.text 941716 941716 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1157000 1157000 0 0.0
.bss 16568 16568 0 0.0
.data 4904 4904 0 0.0
.rodata 99176 99176 0 0.0
.text 954092 954092 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740147 740147 0 0.0
(read/write) 167056 167056 0 0.0
.bss 89468 89468 0 0.0
.data 3424 3424 0 0.0
.rodata 84607 84607 0 0.0
.text 655148 655148 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757659 757659 0 0.0
(read/write) 177300 177300 0 0.0
.bss 99652 99652 0 0.0
.data 3452 3452 0 0.0
.rodata 79695 79695 0 0.0
.text 677572 677572 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744595 744595 0 0.0
(read/write) 171748 171748 0 0.0
.bss 94100 94100 0 0.0
.data 3452 3452 0 0.0
.rodata 105455 105455 0 0.0
.text 638752 638752 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698483 698483 0 0.0
(read/write) 166092 166092 0 0.0
.bss 88272 88272 0 0.0
.data 3412 3412 0 0.0
.rodata 80383 80383 0 0.0
.text 617708 617708 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 683955 683955 0 0.0
(read/write) 166232 166232 0 0.0
.bss 88424 88424 0 0.0
.data 3408 3408 0 0.0
.rodata 76215 76215 0 0.0
.text 607348 607348 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564986 564986 0 0.0
(read/write) 207512 207512 0 0.0
.bss 200972 200972 0 0.0
.data 1416 1416 0 0.0
.rodata 83858 83858 0 0.0
.text 479004 479004 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617994 617994 0 0.0
(read/write) 207908 207908 0 0.0
.bss 201336 201336 0 0.0
.data 1452 1452 0 0.0
.rodata 105730 105730 0 0.0
.text 510144 510144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558543 558543 0 0.0
.app_xip_area 448945 448945 0 0.0
.bss 64512 64512 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540935 540935 0 0.0
.app_xip_area 426601 426601 0 0.0
.bss 69208 69208 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559911 559911 0 0.0
.app_xip_area 451769 451769 0 0.0
.bss 63128 63128 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 555063 555063 0 0.0
.app_xip_area 443689 443689 0 0.0
.bss 66248 66248 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013344 1013344 0 0.0
.bss 172456 172456 0 0.0
.data 2692 2692 0 0.0
.text 838176 838176 0 0.0
BRD4187C (read/write) 1098264 1098264 0 0.0
.bss 196060 196060 0 0.0
.data 3300 3300 0 0.0
.text 898884 898884 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111240 1111240 0 0.0
.bss 188504 188504 0 0.0
.data 2716 2716 0 0.0
.text 919996 919996 0 0.0
window-app BRD4187C (read/write) 1132596 1132596 0 0.0
.bss 168092 168092 0 0.0
.data 3172 3172 0 0.0
.text 961312 961312 0 0.0
esp32 all-clusters-app c3devkit (read only) 1134038 1134038 0 0.0
(read/write) 1671116 1671116 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241816 241816 0 0.0
.flash.text 1134038 1134038 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178475 1178475 0 0.0
(read/write) 520728 520728 0 0.0
.dram0.bss 79072 79072 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273272 273272 0 0.0
.flash.text 1173091 1173091 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592812 592812 0 0.0
(read/write) 88076 88076 0 0.0
.bss 71320 71320 0 0.0
.data 2132 2132 0 0.0
.text 592276 592276 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688364 688364 0 0.0
.bss 67520 67520 0 0.0
.data 2720 2720 0 0.0
.text 574648 574648 0 0.0
light k32w0+release (read only) 592516 592516 0 0.0
(read/write) 87752 87752 0 0.0
.bss 71008 71008 0 0.0
.data 2120 2120 0 0.0
.text 591980 591980 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780216 780216 0 0.0
.bss 77196 77196 0 0.0
.data 1932 1932 0 0.0
.text 657632 657632 0 0.0
lock k32w0+release (read only) 564340 564340 0 0.0
(read/write) 85572 85572 0 0.0
.bss 68888 68888 0 0.0
.data 2060 2060 0 0.0
.text 563804 563804 0 0.0
linux air-purifier-app debug (read only) 2507693 2507693 0 0.0
(read/write) 126856 126856 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 177512 177512 0 0.0
.text 2155493 2155493 0 0.0
all-clusters-app debug (read only) 5339273 5339273 0 0.0
(read/write) 435776 435776 0 0.0
.bss 130064 130064 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 294608 294608 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 304348 304348 0 0.0
.text 4641523 4641523 0 0.0
all-clusters-minimal-app debug (read only) 4933561 4933561 0 0.0
(read/write) 234464 234464 0 0.0
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95680 95680 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270861 270861 0 0.0
.text 4430707 4430707 0 0.0
bridge-app debug (read only) 4406417 4406417 0 0.0
(read/write) 215736 215736 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85056 85056 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218517 218517 0 0.0
.text 3969683 3969683 0 0.0
chip-tool debug (read only) 10895937 10895937 0 0.0
(read/write) 473768 473768 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 367480 367480 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 403113 403113 0 0.0
.text 9852355 9852355 0 0.0
chip-tool-ipv6only arm64 (read only) 10730104 10730104 0 0.0
(read/write) 539688 539688 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 405688 405688 0 0.0
.dynamic 512 512 0 0.0
.got 19048 19048 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 328640 328640 0 0.0
.text 9585928 9585928 0 0.0
lighting-app debug+rpc+ui (read only) 5281737 5281737 0 0.0
(read/write) 224648 224648 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93312 93312 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 338516 338516 0 0.0
.text 4699123 4699123 0 0.0
lock-app debug (read only) 4491569 4491569 0 0.0
(read/write) 203424 203424 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246517 246517 0 0.0
.text 4035395 4035395 0 0.0
ota-provider-app debug (read only) 4155609 4155609 0 0.0
(read/write) 192536 192536 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69072 69072 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 200789 200789 0 0.0
.text 3763299 3763299 0 0.0
ota-requestor-app debug (read only) 4241833 4241833 0 0.0
(read/write) 196784 196784 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72032 72032 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 204565 204565 0 0.0
.text 3841443 3841443 0 0.0
shell debug (read only) 2767737 2767737 0 0.0
(read/write) 149632 149632 0 0.0
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82440 82440 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180768 180768 0 0.0
.text 2416594 2416594 0 0.0
thermostat-no-ble arm64 (read only) 4392896 4392896 0 0.0
(read/write) 245336 245336 0 0.0
.bss 122232 122232 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102120 102120 0 0.0
.dynamic 512 512 0 0.0
.got 11928 11928 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161980 161980 0 0.0
.text 3891192 3891192 0 0.0
tv-app debug (read only) 5276665 5276665 0 0.0
(read/write) 345232 345232 0 0.0
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90344 90344 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 267285 267285 0 0.0
.text 4774643 4774643 0 0.0
tv-casting-app debug (read only) 8835929 8835929 0 0.0
(read/write) 325016 325016 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 159520 159520 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 349736 349736 0 0.0
.text 8055651 8055651 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523944 2523944 0 0.0
.bss 220072 220072 0 0.0
.data 5144 5144 0 0.0
.text 1486628 1486628 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057980 1057980 0 0.0
bss 128917 128917 0 0.0
rodata 104140 104140 0 0.0
text 777272 777272 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184524 1184524 0 0.0
bss 121127 121127 0 0.0
rodata 138268 138268 0 0.0
text 774800 774800 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043116 1043116 0 0.0
bss 129204 129204 0 0.0
rodata 99316 99316 0 0.0
text 766944 766944 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836336 836336 0 0.0
(read/write) 1738172 1738172 0 0.0
.bss 194532 194532 0 0.0
.data 2472 2472 0 0.0
.text 1532780 1532780 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 838048 0 0.0
(read/write) 1701916 1701916 0 0.0
.bss 192812 192812 0 0.0
.data 2480 2480 0 0.0
.text 1498236 1498236 0 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1628004 1628004 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1431012 1431012 0 0.0
lock cy8ckit_062s2_43012 (read only) 817616 817616 0 0.0
(read/write) 1655204 1655204 0 0.0
.bss 213332 213332 0 0.0
.data 2392 2392 0 0.0
.text 1431092 1431092 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114356 1114356 0 0.0
.bss 101144 101144 0 0.0
.data 744 744 0 0.0
.text 626736 626736 0 0.0
lock-app qpg6105+debug (read/write) 1077476 1077476 0 0.0
.bss 97272 97272 0 0.0
.data 788 788 0 0.0
.text 589852 589852 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820662 820662 0 0.0
bss 55004 55004 0 0.0
text 612692 612692 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075468 1075468 0 0.0
bss 99960 99960 0 0.0
text 758326 758326 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080176 1080176 0 0.0
bss 109652 109652 0 0.0
text 749906 749906 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932404 932404 0 0.0
bss 94160 94160 0 0.0
text 644804 644804 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820774 820774 0 0.0
bss 55056 55056 0 0.0
text 612916 612916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 974940 974940 0 0.0
bss 78900 78900 0 0.0
text 690908 690908 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090064 1090064 0 0.0
bss 99724 99724 0 0.0
text 767036 767036 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 961536 961536 0 0.0
bss 97164 97164 0 0.0
text 644922 644922 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945660 945660 0 0.0
bss 92268 92268 0 0.0
text 660516 660516 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 877136 877136 0 0.0
bss 68892 68892 0 0.0
text 619304 619304 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 817740 817740 0 0.0
bss 57128 57128 0 0.0
text 586180 586180 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705404 705404 0 0.0
bss 73588 73588 0 0.0
text 461922 461922 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822482 822450 -32 -0.0
bss 55184 55184 0 0.0
text 615644 615612 -32 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874589 874589 0 0.0
bss 60604 60604 0 0.0
text 627670 627670 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 841888 841888 0 0.0
bss 57424 57424 0 0.0
text 604438 604438 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836388 836388 0 0.0
bss 57776 57776 0 0.0
text 598666 598666 0 0.0

@mkardous-silabs mkardous-silabs merged commit b3ef405 into project-chip:master Nov 29, 2023
54 checks passed
@mkardous-silabs mkardous-silabs deleted the fix/icdm_signature branch November 29, 2023 20:30
bzbarsky-apple
bzbarsky-apple reviewed Dec 6, 2023
View reviewed changes
src/app/clusters/icd-management-server/icd-management-server.cpp
@@ -188,6 +188,30 @@ class IcdManagementFabricDelegate : public FabricTable::Delegate
IcdManagementFabricDelegate gFabricDelegate;
IcdManagementAttributeAccess gAttribute;

/**
* @brief Function checks if the client as admin permissions to the cluster in the commandPath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"has admin", no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll open the pr to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr is open #30848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
[1.3] SDK Feature Complete
Status: Done
Milestone
1.3 Feature Complete
Development

Successfully merging this pull request may close these issues.

[ICD] Refactor ICDManagementServer functions to have less inputs
5 participants
@mkardous-silabs @andy31415 @bzbarsky-apple @jmartinez-silabs @woody-apple