-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle otherwiseConform
tags when parsing CSA datamodel XML
#29953
Handle otherwiseConform
tags when parsing CSA datamodel XML
#29953
Conversation
PR #29953: Size comparison from cdea4cf to a93f3cc Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Mind just helping me understand otherwiseConform meaning a little more. For example DishwasherAlarm has Conformance |
I think I will still have to iterate in time. For now I only found clusters where otherwiseConform generally means there is some form of optionality so I figured treating this as optional is stricly better than considering it mandatory. When I get to clusters using more complex logic, I will iterate. Right now conformance logic is still quite rough since I try to interpret the first string. I can eventually build an AST out of it, however I am trying to defer that as long as possible. |
…t-chip#29953) * Handle otherwiseConform for attributes ... found it in pump cc * Add unit test --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
These conformance tags showed up in Pump Configuration and Control XML.
An otherwiseConform seems to mean that there is a case when the items are not mandatory, so I handle them as optional.