-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable -Wundef by default. #29582
Merged
Merged
Enable -Wundef by default. #29582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
Oct 5, 2023
•
edited
Loading
edited
- Fixes [BUG] CHIP_CONFIG_NON_POSIX_LONG_OPT needs to be defined when false #29216
af8b291
to
bfd6e5e
Compare
andy31415
approved these changes
Oct 5, 2023
PR #29582: Size comparison from f03e9ef to d38be46 Full report (12 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
4174b33
to
e0375d0
Compare
PR #29582: Size comparison from d15daf8 to e0375d0 Full report (19 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
e0375d0
to
5b6352e
Compare
PR #29582: Size comparison from d15daf8 to 5b6352e Decreases (1 build for telink)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
I hope that Tizen can be "enabled" when #29607 will be merged. |
5b6352e
to
64f973e
Compare
PR #29582: Size comparison from 257755e to 64f973e Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 5, 2023
Yes, that would be good! |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Enable -Wundef by default on some platforms. * Fixes project-chip#29216 * Fix a bunch more errors. * Restrict -Wundef to where it actually passes CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.