-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Added a way of activating the report on active mode from icd.gni #29234
Merged
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/ICD_REPORT_ON_ENTER_ACTIVE_MODE
Oct 5, 2023
Merged
[ICD] Added a way of activating the report on active mode from icd.gni #29234
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/ICD_REPORT_ON_ENTER_ACTIVE_MODE
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29234: Size comparison from 3e9de93 to 0690f55 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
4d02496
to
844a7a1
Compare
PR #29234: Size comparison from 2ce5864 to 844a7a1 Increases (10 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 14, 2023
bzbarsky-apple
approved these changes
Oct 5, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
project-chip#29234) * Added a way of activating the report on active mode from icd manager with build flags * Restyled by shfmt * Moved the ICD_REPORT_ON_ENTER_ACTIVE_MODE in the report scheduler implementation * Moved the report on active define to the app BUILD.gn and removed un-necessary #ifdef * Removed preset * Added include AppBuildConfig --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies how to enable report emission on entering active mode, also addresses: #29217