Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] Fix Read Product Appearance #28860

Merged
merged 3 commits into from
Aug 24, 2023
Merged

[Ameba] Fix Read Product Appearance #28860

merged 3 commits into from
Aug 24, 2023

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Aug 24, 2023

Add read product appearance feature for Ameba

@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

PR #28860: Size comparison from 5532798 to a41ec4b

Decreases (1 build for efr32)
platform target config section 5532798 a41ec4b change % change
efr32 lighting-app BRD4187C (read/write) 1065192 1065184 -8 -0.0
.text 888344 888336 -8 -0.0
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5532798 a41ec4b change % change
bl602 lighting-app bl602 (read/write) 1364582 1364582 0 0.0
.bss 73430 73430 0 0.0
.data 9600 9600 0 0.0
.text 1057570 1057570 0 0.0
bl602+rpc (read/write) 1411714 1411714 0 0.0
.bss 81470 81470 0 0.0
.data 9952 9952 0 0.0
.text 1089248 1089248 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168039 1168039 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 3584 3584 0 0.0
.debug_abbrev 1564802 1564802 0 0.0
.debug_aranges 137856 137856 0 0.0
.debug_frame 506916 506916 0 0.0
.debug_info 41443966 41443966 0 0.0
.debug_line 5445422 5445422 0 0.0
.debug_loc 3513715 3513715 0 0.0
.debug_ranges 379880 379880 0 0.0
.debug_str 3946498 3946498 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107116 107116 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589746 589746 0 0.0
.symtab 175840 175840 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955082 955082 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1266583 1266583 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49733 49733 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1741532 1741532 0 0.0
.debug_aranges 146400 146400 0 0.0
.debug_frame 535832 535832 0 0.0
.debug_info 46339902 46339902 0 0.0
.debug_line 5857150 5857150 0 0.0
.debug_loc 3719411 3719411 0 0.0
.debug_ranges 405728 405728 0 0.0
.debug_str 4366384 4366384 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121748 121748 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652688 652688 0 0.0
.symtab 194752 194752 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029500 1029500 0 0.0
bl706-eth (read/write) 1013812 1013812 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 25570 25570 0 0.0
.bss_psram 94415 94415 0 0.0
.comment 48 48 0 0.0
.data 3304 3304 0 0.0
.debug_abbrev 1114132 1114132 0 0.0
.debug_aranges 114168 114168 0 0.0
.debug_frame 423804 423804 0 0.0
.debug_info 23047765 23047765 0 0.0
.debug_line 4402964 4402964 0 0.0
.debug_loc 3011841 3011841 0 0.0
.debug_ranges 316696 316696 0 0.0
.debug_str 3518046 3518046 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 97312 97312 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 454800 454800 0 0.0
.symtab 137888 137888 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
772804 772804 0 0.0
bl706-wifi (read/write) 1085983 1085983 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 9965 9965 0 0.0
.bss_psram 95151 95151 0 0.0
.comment 48 48 0 0.0
.data 3624 3624 0 0.0
.debug_abbrev 1207035 1207035 0 0.0
.debug_aranges 118432 118432 0 0.0
.debug_frame 439248 439248 0 0.0
.debug_info 24212930 24212930 0 0.0
.debug_line 4624093 4624093 0 0.0
.debug_loc 3095948 3095948 0 0.0
.debug_ranges 325592 325592 0 0.0
.debug_str 3579431 3579431 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109588 109588 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 491565 491565 0 0.0
.symtab 150400 150400 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3402 3402 0 0.0
.text 0 0 0 0.0
846510 846510 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153272 1153272 0 0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1567170 1567170 0 0.0
.debug_aranges 132376 132376 0 0.0
.debug_frame 486648 486648 0 0.0
.debug_info 41450771 41450771 0 0.0
.debug_line 5361619 5361619 0 0.0
.debug_loc 3449415 3449415 0 0.0
.debug_ranges 385200 385200 0 0.0
.debug_str 3958941 3958941 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100980 100980 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589940 589940 0 0.0
.symtab 175376 175376 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943582 943582 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 616314 616314 0 0.0
(read/write) 207240 207240 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200680 200680 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 966164 966164 0 0.0
.debug_aranges 106632 106632 0 0.0
.debug_frame 360548 360548 0 0.0
.debug_info 21010135 21010135 0 0.0
.debug_line 2792505 2792505 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1564638 1564638 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 98819 98819 0 0.0
.debug_str 3361572 3361572 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106506 106506 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 498229 498229 0 0.0
.symtab 293728 293728 0 0.0
.text 507688 507688 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550895 550895 0 0.0
.app_xip_area 442305 442305 0 0.0
.bss 63560 63560 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538303 538303 0 0.0
.app_xip_area 424657 424657 0 0.0
.bss 68592 68592 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573535 573535 0 0.0
.app_xip_area 466025 466025 0 0.0
.bss 62552 62552 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558191 558191 0 0.0
.app_xip_area 447465 447465 0 0.0
.bss 65672 65672 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1024216 1024216 0 0.0
.bss 192896 192896 0 0.0
.data 2652 2652 0 0.0
.text 828648 828648 0 0.0
BRD4187C (read/write) 1065192 1065184 -8 -0.0
.bss 173588 173588 0 0.0
.data 3240 3240 0 0.0
.text 888344 888336 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1102460 1102460 0 0.0
.bss 186960 186960 0 0.0
.data 2672 2672 0 0.0
.text 912808 912808 0 0.0
window-app BRD4187C (read/write) 1114704 1114704 0 0.0
.bss 156460 156460 0 0.0
.data 3120 3120 0 0.0
.text 955104 955104 0 0.0
esp32 all-clusters-app c3devkit (read only) 1167224 1167224 0 0.0
(read/write) 1703804 1703804 0 0.0
.dram0.bss 78872 78872 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 267904 267904 0 0.0
.flash.text 1167224 1167224 0 0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1208427 1208427 0 0.0
(read/write) 551778 551778 0 0.0
.dram0.bss 85248 85248 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 298852 298852 0 0.0
.flash.text 1203043 1203043 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 590620 590620 0 0.0
(read/write) 87928 87928 0 0.0
.bss 71176 71176 0 0.0
.data 2128 2128 0 0.0
.text 590084 590084 0 0.0
light k32w0+release (read only) 589404 589404 0 0.0
(read/write) 87580 87580 0 0.0
.bss 70840 70840 0 0.0
.data 2116 2116 0 0.0
.text 588868 588868 0 0.0
lock k32w0+release (read only) 561812 561812 0 0.0
(read/write) 85380 85380 0 0.0
.bss 68696 68696 0 0.0
.data 2060 2060 0 0.0
.text 561276 561276 0 0.0
linux all-clusters-app debug (read only) 5637225 5637225 0 0.0
(read/write) 419720 419720 0 0.0
.bss 130080 130080 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 278232 278232 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 338576 338576 0 0.0
.text 4917443 4917443 0 0.0
all-clusters-minimal-app debug (read only) 4908609 4908609 0 0.0
(read/write) 232008 232008 0 0.0
.bss 126080 126080 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94928 94928 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272454 272454 0 0.0
.text 4405619 4405619 0 0.0
bridge-app debug (read only) 2767793 2767793 0 0.0
(read/write) 132888 132888 0 0.0
.bss 51512 51512 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71440 71440 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214536 214536 0 0.0
.text 2375587 2375587 0 0.0
chip-tool debug (read only) 10347545 10347545 0 0.0
(read/write) 441688 441688 0 0.0
.bss 93688 93688 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 335664 335664 0 0.0
.dynamic 624 624 0 0.0
.got 5816 5816 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 418321 418321 0 0.0
.text 9333747 9333747 0 0.0
chip-tool-ipv6only arm64 (read only) 10188220 10188220 0 0.0
(read/write) 504120 504120 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 373008 373008 0 0.0
.dynamic 512 512 0 0.0
.got 18192 18192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 343496 343496 0 0.0
.text 9080792 9080792 0 0.0
lighting-app debug+rpc+ui (read only) 5237625 5237625 0 0.0
(read/write) 222184 222184 0 0.0
.bss 117808 117808 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92280 92280 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336916 336916 0 0.0
.text 4658515 4658515 0 0.0
lock-app debug (read only) 4472993 4472993 0 0.0
(read/write) 203032 203032 0 0.0
.bss 113392 113392 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 79080 79080 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248486 248486 0 0.0
.text 4015011 4015011 0 0.0
ota-provider-app debug (read only) 4125345 4125345 0 0.0
(read/write) 191968 191968 0 0.0
.bss 113536 113536 0 0.0
.data 4032 4032 0 0.0
.data.rel.ro 68480 68480 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201126 201126 0 0.0
.text 3733779 3733779 0 0.0
ota-requestor-app debug (read only) 4218857 4218857 0 0.0
(read/write) 196280 196280 0 0.0
.bss 114592 114592 0 0.0
.data 4272 4272 0 0.0
.data.rel.ro 71480 71480 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204486 204486 0 0.0
.text 3819603 3819603 0 0.0
shell debug (read only) 3042785 3042785 0 0.0
(read/write) 152488 152488 0 0.0
.bss 60104 60104 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85672 85672 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 213874 213874 0 0.0
.text 2655090 2655090 0 0.0
thermostat-no-ble arm64 (read only) 4353804 4353804 0 0.0
(read/write) 241784 241784 0 0.0
.bss 122120 122120 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 100464 100464 0 0.0
.dynamic 512 512 0 0.0
.got 11848 11848 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161332 161332 0 0.0
.text 3858376 3858376 0 0.0
tv-app debug (read only) 5313801 5313801 0 0.0
(read/write) 349952 349952 0 0.0
.bss 241312 241312 0 0.0
.data 5136 5136 0 0.0
.data.rel.ro 96096 96096 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272310 272310 0 0.0
.text 4797731 4797731 0 0.0
tv-casting-app debug (read only) 8293809 8293809 0 0.0
(read/write) 210672 210672 0 0.0
.bss 54240 54240 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147064 147064 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 367676 367676 0 0.0
.text 7525827 7525827 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522696 2522696 0 0.0
.bss 219408 219408 0 0.0
.data 5128 5128 0 0.0
.text 1485380 1485380 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1239628 1239628 0 0.0
bss 155318 155318 0 0.0
rodata 143088 143088 0 0.0
text 862192 862192 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1357944 1357944 0 0.0
bss 140776 140776 0 0.0
rodata 136992 136992 0 0.0
text 789472 789472 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1159604 1159604 0 0.0
bss 154680 154680 0 0.0
rodata 113632 113632 0 0.0
text 812328 812328 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837336 837336 0 0.0
(read/write) 1792004 1792004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193460 193460 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2544 2544 0 0.0
.debug_abbrev 1417319 1417319 0 0.0
.debug_aranges 144920 144920 0 0.0
.debug_frame 482032 482032 0 0.0
.debug_info 33181257 33181257 0 0.0
.debug_line 4227314 4227314 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2299360 2299360 0 0.0
.debug_rnglists 144371 144371 0 0.0
.debug_str 4522311 4522311 0 0.0
.heap 837336 837336 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 848096 848096 0 0.0
.symtab 514368 514368 0 0.0
.text 1587612 1587612 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840112 840112 0 0.0
(read/write) 1677036 1677036 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190764 190764 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1289828 1289828 0 0.0
.debug_aranges 134792 134792 0 0.0
.debug_frame 453544 453544 0 0.0
.debug_info 28962832 28962832 0 0.0
.debug_line 3940722 3940722 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2115487 2115487 0 0.0
.debug_rnglists 133781 133781 0 0.0
.debug_str 3915048 3915048 0 0.0
.heap 840112 840112 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 717805 717805 0 0.0
.symtab 466768 466768 0 0.0
.text 1475420 1475420 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846424 846424 0 0.0
(read/write) 1605292 1605292 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184564 184564 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1129851 1129851 0 0.0
.debug_aranges 124888 124888 0 0.0
.debug_frame 416588 416588 0 0.0
.debug_info 24100596 24100596 0 0.0
.debug_line 3505735 3505735 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1952272 1952272 0 0.0
.debug_rnglists 123465 123465 0 0.0
.debug_str 3721985 3721985 0 0.0
.heap 846424 846424 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 635139 635139 0 0.0
.symtab 430240 430240 0 0.0
.text 1409988 1409988 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818896 818896 0 0.0
(read/write) 1639492 1639492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212076 212076 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1120976 1120976 0 0.0
.debug_aranges 123816 123816 0 0.0
.debug_frame 412648 412648 0 0.0
.debug_info 23922300 23922300 0 0.0
.debug_line 3461169 3461169 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1933096 1933096 0 0.0
.debug_rnglists 121665 121665 0 0.0
.debug_str 3686438 3686438 0 0.0
.heap 818896 818896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 609924 609924 0 0.0
.symtab 422816 422816 0 0.0
.text 1416660 1416660 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177620 1177620 0 0.0
.bss 101008 101008 0 0.0
.data 744 744 0 0.0
.text 624464 624464 0 0.0
lock-app qpg6105+debug (read/write) 1134972 1134972 0 0.0
.bss 95728 95728 0 0.0
.data 748 748 0 0.0
.text 581812 581812 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1094220 1094220 0 0.0
bss 108016 108016 0 0.0
text 750496 750496 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980060 980060 0 0.0
bss 105168 105168 0 0.0
text 672280 672280 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944264 944264 0 0.0
bss 109500 109500 0 0.0
text 647078 647078 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876196 876196 0 0.0
bss 98680 98680 0 0.0
text 590434 590434 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 922492 922492 0 0.0
bss 99512 99512 0 0.0
text 632090 632090 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 982720 982720 0 0.0
bss 107356 107356 0 0.0
text 686034 686034 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 994084 994084 0 0.0
bss 111604 111604 0 0.0
text 693550 693550 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1052252 1052252 0 0.0
bss 108928 108928 0 0.0
text 730966 730966 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1083796 1083796 0 0.0
bss 120004 120004 0 0.0
text 751242 751242 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934276 934276 0 0.0
bss 99408 99408 0 0.0
text 621588 621588 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898776 898776 0 0.0
bss 99988 99988 0 0.0
text 612282 612282 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881612 881612 0 0.0
bss 98812 98812 0 0.0
text 596060 596060 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868752 868752 0 0.0
bss 98612 98612 0 0.0
text 586486 586486 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744116 744116 0 0.0
bss 97208 97208 0 0.0
text 478532 478532 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879688 879688 0 0.0
bss 98800 98800 0 0.0
text 594796 594796 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864924 864924 0 0.0
bss 98520 98520 0 0.0
text 582124 582124 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890200 890200 0 0.0
bss 98912 98912 0 0.0
text 602208 602208 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885824 885824 0 0.0
bss 99228 99228 0 0.0
text 597536 597536 0 0.0

@mergify mergify bot merged commit 40f0c26 into project-chip:master Aug 24, 2023
@pankore pankore deleted the fix_read_product_appearance branch August 25, 2023 01:30
abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Aug 25, 2023
@pankore @abpoth
[Ameba] Fix Read Product Appearance (project-chip#28860)
2e49616 
* Fix Read Product Appearance

* Updated product finish to other and product color to black

* ran restyle-diff.sh
bzbarsky-apple
bzbarsky-apple reviewed Sep 2, 2023
View reviewed changes
src/platform/Ameba/FactoryDataProvider.cpp
CHIP_ERROR FactoryDataProvider::GetProductPrimaryColor(ColorEnum * primaryColor)
{
CHIP_ERROR err = CHIP_NO_ERROR;
*primaryColor = ColorEnum::kBlack;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankore Is there a reason this is not just returning error? Color is optional to return....

src/platform/Ameba/FactoryDataProvider.cpp
CHIP_ERROR FactoryDataProvider::GetProductFinish(ProductFinishEnum * finish)
{
CHIP_ERROR err = CHIP_NO_ERROR;
*finish = ProductFinishEnum::kOther;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product appearance is optional to implement, and just making up an invalid value is not a useful way of implementing it. Why is this being done?

HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@pankore @HunsupJung
[Ameba] Fix Read Product Appearance (project-chip#28860)
d63db36 
* Fix Read Product Appearance

* Updated product finish to other and product color to black

* ran restyle-diff.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankore @andy31415 @bzbarsky-apple